From: Emil Velikov via igt-dev <igt-dev@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: IGT development <igt-dev@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/core_auth: mount namespace magic to make the test work everywhere
Date: Thu, 14 Feb 2019 13:52:37 +0000 [thread overview]
Message-ID: <20190214135237.GA20918@arch-x1c3> (raw)
In-Reply-To: <20190213203611.24053-1-daniel.vetter@ffwll.ch>
On 2019/02/13, Daniel Vetter wrote:
> We're creating our own namespace and then create a copy of the chardev
> that anyone can access before dropping root. Should hopefully work on
> any system.
>
> This way we're also guaranteed to open the right device again.
>
> v2: mount(2) instead of mount(3).
>
It's an improvement over the current test, so considering it works as
advertised - ship it.
Sadly I'm not too familiar to provide a meaningful review.
Thanks
Emil
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-14 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 18:33 [igt-dev] [PATCH i-g-t] lib/core_auth: mount namespace magic to make the test work everywhere Daniel Vetter
2019-02-13 20:36 ` Daniel Vetter
2019-02-14 13:52 ` Emil Velikov via igt-dev [this message]
2019-02-15 9:51 ` Chris Wilson
2019-02-15 10:16 ` Daniel Vetter
2019-02-14 9:35 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/core_auth: mount namespace magic to make the test work everywhere (rev2) Patchwork
2019-02-14 12:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-14 12:26 ` [igt-dev] [PATCH i-g-t] lib/core_auth: mount namespace magic to make the test work everywhere Chris Wilson
2019-02-14 15:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214135237.GA20918@arch-x1c3 \
--to=igt-dev@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=emil.velikov@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox