From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B1086E952 for ; Thu, 14 Feb 2019 15:30:38 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id f2so5307859edy.13 for ; Thu, 14 Feb 2019 07:30:38 -0800 (PST) Date: Thu, 14 Feb 2019 16:30:34 +0100 From: Daniel Vetter Message-ID: <20190214153034.GE2665@phenom.ffwll.local> References: <20190213161817.18758-1-stanislav.lisovskiy@intel.com> <20190213204131.GM23159@phenom.ffwll.local> <778d2d33955949b984a922585f53dd144d7bb673.camel@intel.com> <20190214082542.GQ23159@phenom.ffwll.local> <729d50520419f53ae843ac495ad467948935b29c.camel@intel.com> <20190214083302.GR23159@phenom.ffwll.local> <01bf7d6793119108f1ac11ed2162ba204ed39ca9.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <01bf7d6793119108f1ac11ed2162ba204ed39ca9.camel@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] igt/tests: Fix error checking in kms_atomic_transition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Lisovskiy, Stanislav" Cc: "igt-dev@lists.freedesktop.org" , "Syrjala, Ville" , "Heikkila, Juha-pekka" , "daniel@ffwll.ch" , "Peres, Martin" List-ID: T24gVGh1LCBGZWIgMTQsIDIwMTkgYXQgMTI6MTQ6MjJQTSArMDAwMCwgTGlzb3Zza2l5LCBTdGFu aXNsYXYgd3JvdGU6Cj4gT24gVGh1LCAyMDE5LTAyLTE0IGF0IDA5OjMzICswMTAwLCBEYW5pZWwg VmV0dGVyIHdyb3RlOgo+ID4gT24gVGh1LCBGZWIgMTQsIDIwMTkgYXQgMDg6MzE6NTJBTSArMDAw MCwgTGlzb3Zza2l5LCBTdGFuaXNsYXYgd3JvdGU6Cj4gPiA+IE9uIFRodSwgMjAxOS0wMi0xNCBh dCAwOToyNSArMDEwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ID4gPiBPbiBUaHUsIEZlYiAx NCwgMjAxOSBhdCAwODoyMjoyOUFNICswMDAwLCBMaXNvdnNraXksIFN0YW5pc2xhdgo+ID4gPiA+ IHdyb3RlOgo+ID4gPiA+ID4gT24gV2VkLCAyMDE5LTAyLTEzIGF0IDIxOjQxICswMTAwLCBEYW5p ZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiA+ID4gPiBPbiBXZWQsIEZlYiAxMywgMjAxOSBhdCAwNjox ODoxN1BNICswMjAwLCBTdGFuaXNsYXYgTGlzb3Zza2l5Cj4gPiA+ID4gPiA+IHZpYQo+ID4gPiA+ ID4gPiBpZ3QtZGV2IHdyb3RlOgo+ID4gPiA+ID4gPiA+IFRoZXJlIGlzIG5vIGd1YXJhbnRlZSB0 aGF0IGVycm9yIHJldHVybiB2YWx1ZSB3aWxsIGJlCj4gPiA+ID4gPiA+ID4gYWx3YXlzIEVJTlZB TCwgbWFkZSBhIGNoZWNrIG1vcmUgZ2VuZXJhbCBhcyBpdCBjYW4gYmUKPiA+ID4gPiA+ID4gPiBF UkFOR0UsIEVOT1NQQywgRUlOVkFMIGFuZCBwcm9iYWJseSBvdGhlcnMsIHdoaWNoIGFsbAo+ID4g PiA+ID4gPiA+IG1lYW4gdGhlIHNhbWUgaW4gY29udGV4dCBvZiB0aGlzIHRlc3QgY2FzZTogaS5l IHRoaXMgc3ByaXRlCj4gPiA+ID4gPiA+ID4gc2l6ZSBpcyBub3QgdmFsaWQuCj4gPiA+ID4gPiA+ ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lk PTEwOTIKPiA+ID4gPiA+ID4gPiAyNQo+ID4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFN0YW5p c2xhdiBMaXNvdnNraXkgPHN0YW5pc2xhdi5saXNvdnNraXlAaW50Cj4gPiA+ID4gPiA+ID4gZWwu Ywo+ID4gPiA+ID4gPiA+IG9tPgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gS2VybmVsIGF0b21p YyBzcGVjIGlzIHByZXR0eSBjbGVhciB0aGF0IGl0J3MgZWl0aGVyIEVJTlZBTCBvcgo+ID4gPiA+ ID4gPiBFUkFOR0UsCj4gPiA+ID4gPiA+IGFuZAo+ID4gPiA+ID4gPiBub3RoaW5nIGVsc2UuIElu IHRoZSBkb2NzIHdlIGV2ZW4gbGltaXQgdG8gRUlOVkFMIChzY3JvbGwKPiA+ID4gPiA+ID4gZG93 biB0bwo+ID4gPiA+ID4gPiBhdG9taWNfY2hlY2spOgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g aHR0cHM6Ly9kcmkuZnJlZWRlc2t0b3Aub3JnL2RvY3MvZHJtL2dwdS9kcm0ta21zLmh0bWw/aGln aGxpZwo+ID4gPiA+ID4gPiBodD1kCj4gPiA+ID4gPiA+IHJtX20KPiA+ID4gPiA+ID4gb2RlX2Nv bmZpZ19mdW5jcyNjLmRybV9tb2RlX2NvbmZpZ19mdW5jcwo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ ID4gV291bGQgYmUgZ3JlYXQgaWYgeW91IGNhbiBzdWJtaXQgYSBrZXJuZWwgcGF0Y2ggdG8gYWRk IHRoZQo+ID4gPiA+ID4gPiBFUkFOR0UuCj4gPiA+ID4gPiA+IEFuZAo+ID4gPiA+ID4gPiBjaGFu Z2UgdGhpcyBvbmUgaGVyZSB0byBvbmx5IGFjY2VwdCBFUkFOR0UgYW5kIEVJTlZBTCBhcwo+ID4g PiA+ID4gPiAic3ByaXRlCj4gPiA+ID4gPiA+IGRvZXNuJ3QKPiA+ID4gPiA+ID4gd29yayIuCj4g PiA+ID4gPiAKPiA+ID4gPiA+IFVuZm9ydHVuYXRlbHksIGluIHJlYWxpdHkgaXQgaXMgbm90IGxp a2UgdGhhdC4gV2UgaGF2ZSBhIGJ1Zwo+ID4gPiA+ID4gZmRvIzEwOTIyNSwgd2hlcmUgaXQgcmV0 dXJucyBFTk9TUEMuIERSTSBkb2VzIHRoaXMgd2hlbiBwbGFuZQo+ID4gPiA+ID4gc2l6ZQo+ID4g PiA+ID4gZXhjZWVkcyB0aGUgZnJhbWVidWZmZXIgc2l6ZShjaGVjayBkcm1fYXRvbWljLmMsCj4g PiA+ID4gPiBkcm1fYXRvbWljX3BsYW5lX2NoZWNrKS4gCj4gPiA+ID4gPiBXZSBoaXQgdGhpcyBp c3N1ZSB3aGVuIHdlIGhhcHBlbiB0byBoYXZlIHJlc29sdXRpb24gbG93ZXIgdGhhbgo+ID4gPiA+ ID4gZXhwZWN0ZWQKPiA+ID4gPiA+IGJ5IElHVCwgc28gd2UgYWN0dWFsbHkgY3JlYXRlIGEgZnJh bWVidWZmZXIgb2Ygc21hbGxlciBzaXplCj4gPiA+ID4gPiB0aGFuIGl0Cj4gPiA+ID4gPiBzZXRz IGZvciB0aGUgcGxhbmUgYW5kIHRoZW4gd2UKPiA+ID4gPiA+IGhpdCBFTk9TUEMgaW5zdGVhZCBF SU5WQUwsIHdoaWNoIGlzIHRyZWF0ZWQgbm93IGFzIE9LIGJ5IHRoZQo+ID4gPiA+ID4gdGVzdAo+ ID4gPiA+ID4gY2FzZS4KPiA+ID4gPiA+IFNvIGFkZGluZyBFUkFOR0Ugd2lsbCBub3QgaGVscCBm b3IgdGhpcyBidWcuIAo+ID4gPiA+ID4gRWl0aGVyIEkgc2hvdWxkIGFkZCBhbGwgdGhyZWUgdG8g SUdUKEVSQU5HRSwgRU5PU1BDLCBFSU5WQUwpIG9yCj4gPiA+ID4gPiBmaXgKPiA+ID4gPiA+IGl0 Cj4gPiA+ID4gPiBpbiB0aGUga2VybmVsLCBzbyB0aGF0IGl0IHJldHVybnMgRUlOVkFMIGluc3Rl YWQgb2YgRU5PU1BDLgo+ID4gPiA+IAo+ID4gPiA+IEhtIHllYWgsIHBscyBkbywgYW5kIHBscyBk byB1cGRhdGUgdGhlIGtlcm5lbCBkb2N1bWVudGF0aW9uLiBJJ20KPiA+ID4gPiBhbHNvCj4gPiA+ ID4gd29uZGVyaW5nIHdoZXRoZXIgd2Ugc2hvdWxkbid0IHdyYXAgc29tZSBjaGVja3MgYXJvdW5k IGNhbGxzIHRvCj4gPiA+ID4gYXRvbWljX2NoZWNrIGluIHRoZSBrZXJuZWwgZm9yIHRoaXMuCj4g PiA+ID4gLURhbmllbAo+ID4gPiAKPiA+ID4gU28gZG8geW91IG1lYW4gSSBzaG91bGQgZml4IHRo ZSBrZXJuZWwgb3IgaWd0PyA6KQo+ID4gCj4gPiBPb3BzIDotKSBJIG1lYW50IHRvIGZpeCB0aGUg aWd0IGxvZ2ljIHRvIGFsc28gYWNjZXB0IEVOT1NQQyBhbmQKPiA+IEVJTlZBTCwKPiA+IHBsdXMg dXBkYXRlIHRoZSBrZXJuZWwncyBkb2N1bWVudGF0aW9uIHNvIHRoYXQgZG9jcyByZWZsZWN0IHJl YWxpdHkuCj4gPiAtRGFuaWVsCj4gCj4gT2ssIEkgd2lsbCBmaXggdGhlIGtlcm5lbCBkb2NzIGFs c28uIEhvd2V2ZXIgcmVnYXJkaW5nIHRoaXMgcGF0Y2gsCj4gc2hvdWxkIEkgc3RpbGwgc2ltcGx5 IGp1c3QgY29tcGFyZSB0byAwIGluIGEgY2hlY2sgcmF0aGVyIHRoYW4gYWRkaW5nCj4gYWxsIHRo cmVlLCBhcyBjb25kaXRpb25zIGxpa2UgImlmICgocmV0ID09IC1FSU5WQUwpIHx8IChyZXQgPT0g LUVSQU5HRSkKPiB8fCAocmV0ID09IC1FTk9TUEMpKSIgd291bGQgbG9vayBhIGJpdCB3ZWlyZCwg SSBndWVzcy4uCgpJZiB5b3Ugd2FudCBpdCBsZXNzIHdpZXJkLCBtYWtlIGl0IGEgc3RhdGljIGlu bGluZSwgZS5nLgoKaXNfYXRvbWljX2NoZWNrX2ZhaWx1cmVfZXJybm8oaW50IGVycm5vKQp7Cgly ZXR1cm4gZXJybm8gPT0gLUVJTlZBTCB8fCBlcnJubyA9PSAtRVJBTkdFIHx8IGVycm5vID09IC1F Tk9TUEM7Cn0KCkNoZWVycywgRGFuaWVsCgoKPiAKPiA+IAo+ID4gPiAKPiA+ID4gPiAKPiA+ID4g PiA+IAo+ID4gPiA+ID4gPiAtRGFuaWVsCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IC0tLQo+ ID4gPiA+ID4gPiA+ICB0ZXN0cy9rbXNfYXRvbWljX3RyYW5zaXRpb24uYyB8IDQgKystLQo+ID4g PiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfYXRv bWljX3RyYW5zaXRpb24uYwo+ID4gPiA+ID4gPiA+IGIvdGVzdHMva21zX2F0b21pY190cmFuc2l0 aW9uLmMKPiA+ID4gPiA+ID4gPiBpbmRleCBlYzVkMjVkZS4uNThiZjYyODAgMTAwNjQ0Cj4gPiA+ ID4gPiA+ID4gLS0tIGEvdGVzdHMva21zX2F0b21pY190cmFuc2l0aW9uLmMKPiA+ID4gPiA+ID4g PiArKysgYi90ZXN0cy9rbXNfYXRvbWljX3RyYW5zaXRpb24uYwo+ID4gPiA+ID4gPiA+IEBAIC0y ODIsNyArMjgyLDcgQEAgcmV0cnk6Cj4gPiA+ID4gPiA+ID4gIAkJd21fc2V0dXBfcGxhbmUoZGlz cGxheSwgcGlwZSwgKDEgPDwKPiA+ID4gPiA+ID4gPiBuX3BsYW5lcykKPiA+ID4gPiA+ID4gPiAt IDEsCj4gPiA+ID4gPiA+ID4gcGFybXMsIGZhbHNlKTsKPiA+ID4gPiA+ID4gPiAgCQlyZXQgPQo+ ID4gPiA+ID4gPiA+IGlndF9kaXNwbGF5X3RyeV9jb21taXRfYXRvbWljKGRpc3BsYXksCj4gPiA+ ID4gPiA+ID4gRFJNX01PREVfQVRPTUlDX1RFU1RfT05MWSB8IERSTV9NT0RFX0FUT01JQ19BTExP V19NT0RFU0VULAo+ID4gPiA+ID4gPiA+IE5VTEwpOwo+ID4gPiA+ID4gPiA+ICAKPiA+ID4gPiA+ ID4gPiAtCQlpZiAocmV0ID09IC1FSU5WQUwpIHsKPiA+ID4gPiA+ID4gPiArCQlpZiAocmV0ICE9 IDApIHsKPiA+ID4gPiA+ID4gPiAgCQkJaWYgKGN1cnNvcl93aWR0aCA9PSBzcHJpdGVfd2lkdGgK PiA+ID4gPiA+ID4gPiAmJgo+ID4gPiA+ID4gPiA+ICAJCQkgICAgY3Vyc29yX2hlaWdodCA9PQo+ ID4gPiA+ID4gPiA+IHNwcml0ZV9oZWlnaHQpIHsKPiA+ID4gPiA+ID4gPiAgCQkJCWlndF9hc3Nl cnRfZihhbHBoYSwKPiA+ID4gPiA+ID4gPiBAQCAtNDcyLDcgKzQ3Miw3IEBAIHJ1bl90cmFuc2l0 aW9uX3Rlc3QoaWd0X2Rpc3BsYXlfdAo+ID4gPiA+ID4gPiA+ICpkaXNwbGF5LAo+ID4gPiA+ID4g PiA+IGVudW0gcGlwZSBwaXBlLCBpZ3Rfb3V0cHV0X3QgKm91dHB1dAo+ID4gPiA+ID4gPiA+ICAJ CQlpZ3RfcGlwZV9yZXF1ZXN0X291dF9mZW5jZShwaXBlX29iCj4gPiA+ID4gPiA+ID4gaik7Cj4g PiA+ID4gPiA+ID4gIAo+ID4gPiA+ID4gPiA+ICAJCXJldCA9Cj4gPiA+ID4gPiA+ID4gaWd0X2Rp c3BsYXlfdHJ5X2NvbW1pdF9hdG9taWMoZGlzcGxheSwKPiA+ID4gPiA+ID4gPiBEUk1fTU9ERV9B VE9NSUNfVEVTVF9PTkxZIHwgRFJNX01PREVfQVRPTUlDX0FMTE9XX01PREVTRVQsCj4gPiA+ID4g PiA+ID4gTlVMTCk7Cj4gPiA+ID4gPiA+ID4gLQkJaWYgKHJldCAhPSAtRUlOVkFMIHx8IHBpcGVf b2JqLT5uX3BsYW5lcyA8Cj4gPiA+ID4gPiA+ID4gMykKPiA+ID4gPiA+ID4gPiArCQlpZiAocmV0 ID09IDAgfHwgcGlwZV9vYmotPm5fcGxhbmVzIDwgMykKPiA+ID4gPiA+ID4gPiAgCQkJYnJlYWs7 Cj4gPiA+ID4gPiA+ID4gIAo+ID4gPiA+ID4gPiA+ICAJCXJldCA9IDA7Cj4gPiA+ID4gPiA+ID4g LS0gCj4gPiA+ID4gPiA+ID4gMi4xNy4xCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gPiA+ID4g PiBpZ3QtZGV2IG1haWxpbmcgbGlzdAo+ID4gPiA+ID4gPiA+IGlndC1kZXZAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gPiA+ID4gPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pZ3QtZGV2Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ IAo+ID4gPiA+ID4gLS0gCj4gPiA+ID4gPiBCZXN0IFJlZ2FyZHMsCj4gPiA+ID4gPiAKPiA+ID4g PiA+IExpc292c2tpeSBTdGFuaXNsYXYKPiA+ID4gPiAKPiA+ID4gPiAKPiA+ID4gCj4gPiA+IC0t IAo+ID4gPiBCZXN0IFJlZ2FyZHMsCj4gPiA+IAo+ID4gPiBMaXNvdnNraXkgU3RhbmlzbGF2Cj4g PiAKPiA+IAo+IC0tIAo+IEJlc3QgUmVnYXJkcywKPiAKPiBMaXNvdnNraXkgU3RhbmlzbGF2Cgot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2