Re: [igt-dev] [PATCH i-g-t 1/2] i915/kms_chamelium: Require gen < 9 for VGA testing

[Petri Latvala <petri.latvala@intel.com>]

On Thu, Feb 14, 2019 at 04:40:42PM -0800, Stuart Summers via igt-dev wrote:
> From: Stuart Summers <jssummer@jssummer-desk1.amr.corp.intel.com>
> 
> VGA not supported on gen 9 and above. Add an explicit requirement
> to skip VGA tests to a Chamelium on later gens.
> 
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> ---
>  tests/kms_chamelium.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> index 64f87d3ae..ab89c5d47 100644
> --- a/tests/kms_chamelium.c
> +++ b/tests/kms_chamelium.c
> @@ -1015,6 +1015,8 @@ igt_main
>  
>  	igt_subtest_group {
>  		igt_fixture {
> +			int gen = intel_gen(intel_get_drm_devid(data.drm_fd));
> +			igt_require_f(gen < 9, "VGA not supported\n");
>  			require_connector_present(
>  			    &data, DRM_MODE_CONNECTOR_VGA);

The obvious first comment is that you're not necessarily running on an
intel device. But let's put that aside, there's a more important
question.

What problem does this solve? The line directly after checks for a VGA
connector being present. VGA via DP not good enough? If there's
problems with that, surely there are better ways to get around it than
ignoring it.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev