public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/3] tests/kms_mmap_write_crc: Fix igt_fixture handling
Date: Wed, 20 Feb 2019 15:24:48 +0100	[thread overview]
Message-ID: <20190220142449.4986-2-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190220142449.4986-1-daniel.vetter@ffwll.ch>

igt_fixture within an igt_simple_test don't really work as advertised.

Minimal fix, the testcase seems fairly questionable already ...

References: https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_222/fi-icl-y/igt@kms_mmap_write_crc.html
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_mmap_write_crc.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/tests/kms_mmap_write_crc.c b/tests/kms_mmap_write_crc.c
index 93c96ef4de08..bf2b0c2991b3 100644
--- a/tests/kms_mmap_write_crc.c
+++ b/tests/kms_mmap_write_crc.c
@@ -268,7 +268,8 @@ static data_t data;
 int main(int argc, char **argv)
 {
 	int i;
-	igt_simple_init_parse_opts(&argc, argv, "n", NULL, NULL, opt_handler, NULL);
+	igt_subtest_init_parse_opts(&argc, argv, "n", NULL, NULL,
+				    opt_handler, NULL);
 
 	igt_skip_on_simulation();
 
@@ -286,10 +287,12 @@ int main(int argc, char **argv)
 		fork_cpuhog_helper();
 	}
 
-	igt_info("Using %d rounds for the test\n", ROUNDS);
+	igt_subtest("main") {
+		igt_info("Using %d rounds for the test\n", ROUNDS);
 
-	for (i = 0; i < ROUNDS; i++)
-		run_test(&data);
+		for (i = 0; i < ROUNDS; i++)
+			run_test(&data);
+	}
 
 	igt_fixture {
 		igt_display_fini(&data.display);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-02-20 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 14:24 [igt-dev] [PATCH i-g-t 1/3] lib/tests: Use ARRAY_SIZE Daniel Vetter
2019-02-20 14:24 ` Daniel Vetter [this message]
2019-02-20 14:31   ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_mmap_write_crc: Fix igt_fixture handling Chris Wilson
2019-02-20 23:44     ` Daniel Vetter
2019-02-20 14:24 ` [igt-dev] [PATCH i-g-t 3/3] lib: disallow fixtures/subtest groups in simple tests Daniel Vetter
2019-02-20 14:51   ` Arkadiusz Hiler
2019-02-20 23:41     ` Daniel Vetter
2019-02-20 15:00 ` [igt-dev] [PATCH i-g-t 1/3] lib/tests: Use ARRAY_SIZE Arkadiusz Hiler
2019-02-20 23:38   ` Daniel Vetter
2019-02-20 15:14 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] " Patchwork
2019-02-20 17:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190220142449.4986-2-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox