From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: Keith Packard <keithp@keithp.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
Date: Wed, 20 Feb 2019 21:33:35 +0100 [thread overview]
Message-ID: <20190220203335.1218-1-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190220162530.31643-9-daniel.vetter@ffwll.ch>
And make sure we get the LEASE=1 value, indicating a lessee change.
v2: Apparently netlink reading can leak EAGAIN out through
udev_monitor_receive_device. No idea what's going on there, so let's
wrap some duct tape around it.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index d082a7988eaa..6fe91615a70d 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -40,6 +40,8 @@
#include <sys/time.h>
#include <sys/wait.h>
+#include <libudev.h>
+
#include <drm.h>
IGT_TEST_DESCRIPTION("Test of CreateLease.");
@@ -976,6 +978,69 @@ static void implicit_plane_lease(data_t *data)
drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
}
+static void lease_uevent(data_t *data)
+{
+ int lease_fd;
+ struct local_drm_mode_list_lessees mll;
+ struct udev_monitor *uevent_monitor;
+ struct udev *udev;
+ struct udev_device *dev;
+ const char *lease;
+ struct pollfd udev_fd;
+
+ udev = udev_new();
+ igt_assert(udev);
+
+ uevent_monitor = udev_monitor_new_from_netlink(udev, "udev");
+ igt_assert(uevent_monitor);
+
+ do_or_die(udev_monitor_filter_add_match_subsystem_devtype(uevent_monitor,
+ "drm",
+ "drm_minor"));
+ do_or_die(udev_monitor_enable_receiving(uevent_monitor));
+
+ /* netlink is not synchronous ... */
+ udev_fd.fd = udev_monitor_get_fd(uevent_monitor);
+ udev_fd.revents = 0;
+ udev_fd.events = POLLIN;
+
+ poll(&udev_fd, 1, 100);
+ dev = udev_monitor_receive_device(uevent_monitor);
+ igt_assert(!dev);
+
+ lease_fd = create_simple_lease(data->master.fd, data);
+
+ poll(&udev_fd, 1, 100);
+ dev = udev_monitor_receive_device(uevent_monitor);
+ igt_assert(!dev);
+
+ mll.pad = 0;
+ mll.count_lessees = 0;
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 1);
+
+ close(lease_fd);
+
+ poll(&udev_fd, 1, 100);
+ do {
+ dev = udev_monitor_receive_device(uevent_monitor);
+ } while (!dev && errno == EAGAIN);
+ igt_assert(dev);
+
+ lease = udev_device_get_property_value(dev, "LEASE");
+ igt_assert(lease);
+ igt_assert(strcmp(lease, "1") == 0);
+
+ udev_device_unref(dev);
+
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 0);
+
+ udev_monitor_unref(uevent_monitor);
+}
+
igt_main
{
data_t data;
@@ -1023,4 +1088,7 @@ igt_main
igt_subtest("implicit-plane-lease")
implicit_plane_lease(&data);
+
+ igt_subtest("lease-uevent")
+ lease_uevent(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-20 20:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 2/9] tests/kms_lease: Run on simulation Daniel Vetter
2019-03-14 9:29 ` Boris Brezillon
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl Daniel Vetter
2019-02-20 20:43 ` Lyude Paul
2019-02-20 21:20 ` Daniel Vetter
2019-02-20 21:23 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-02-21 3:08 ` [igt-dev] [PATCH i-g-t 3/9] " Keith Packard
2019-02-21 9:16 ` Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 4/9] tests/kms_release: invalid checks for revoke-lease ioctl Daniel Vetter
2019-03-14 9:35 ` Boris Brezillon
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 5/9] tests/kms_lease: validate the possible_crtcs filtering Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 6/9] tests/kms_lease: Test drop/set_master interactions Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 7/9] tests/kms_lease: multimaster testcase Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 8/9] tests/kms_lease: validate implicitly added planes Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: exercise uevent Daniel Vetter
2019-02-20 20:33 ` Daniel Vetter [this message]
2019-02-20 22:25 ` [igt-dev] [PATCH i-g-t] " Lyude Paul
2019-02-20 23:33 ` Daniel Vetter
2019-02-20 23:34 ` Lyude Paul
2019-02-20 21:01 ` Daniel Vetter
2019-02-20 21:17 ` Daniel Vetter
2019-02-20 23:42 ` Lyude Paul
2019-02-20 23:48 ` Daniel Vetter
2019-02-21 0:16 ` Lyude Paul
2019-02-20 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests Patchwork
2019-02-20 19:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-20 20:42 ` Daniel Vetter
2019-02-20 21:11 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2) Patchwork
2019-02-20 21:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3) Patchwork
2019-02-20 22:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5) Patchwork
2019-02-20 22:26 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Lyude Paul
2019-02-21 1:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2) Patchwork
2019-02-21 1:52 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3) Patchwork
2019-02-21 2:57 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5) Patchwork
2019-02-21 12:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev6) Patchwork
2019-02-21 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-21 19:28 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev7) Patchwork
2019-02-22 8:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-22 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev8) Patchwork
2019-02-22 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-14 9:26 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220203335.1218-1-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox