From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [HAX 3/5] lib/igt_fb: Use rendercopy for rendering into compressed buffers
Date: Thu, 21 Feb 2019 16:06:13 +0200 [thread overview]
Message-ID: <20190221140613.GL20097@intel.com> (raw)
In-Reply-To: <20190221024123.17516-3-dhinakaran.pandiyan@intel.com>
On Wed, Feb 20, 2019 at 06:41:21PM -0800, Dhinakaran Pandiyan wrote:
> @@ -2397,8 +2523,10 @@ cairo_surface_t *igt_get_cairo_surface(int fd, struct igt_fb *fb)
> ((f->cairo_id == CAIRO_FORMAT_INVALID) &&
> (f->pixman_id != PIXMAN_invalid)))
> create_cairo_surface__convert(fd, fb);
> + else if (is_ccs_modifier(fb->tiling))
> + create_cairo_surface__rendercopy(fd, fb);
> else if (fb->tiling == LOCAL_I915_FORMAT_MOD_Y_TILED ||
> - fb->tiling == LOCAL_I915_FORMAT_MOD_Yf_TILED)
> + fb->tiling == LOCAL_I915_FORMAT_MOD_Yf_TILED)
> create_cairo_surface__blit(fd, fb);
> else
> create_cairo_surface__gtt(fd, fb);
Oh, and this reminds me that we still have the <32k byte blitter stride
problem, which I tried to address a bit in
https://patchwork.freedesktop.org/patch/248543/
by using gtt mmaps instead. However that failed for Yf since fences can't
handle Yf. My initial idea was to cpu mmap and tile/detile manually,
but we could actually consider using rendercopy instead.
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-21 14:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 2:41 [igt-dev] [HAX 1/5] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy Dhinakaran Pandiyan
2019-02-21 2:41 ` [igt-dev] [HAX 2/5] tests/gem_render_copy: Test Yf tiling Dhinakaran Pandiyan
2019-02-21 2:41 ` [igt-dev] [HAX 3/5] lib/igt_fb: Use rendercopy for rendering into compressed buffers Dhinakaran Pandiyan
2019-02-21 13:58 ` Ville Syrjälä
2019-02-21 14:06 ` Ville Syrjälä [this message]
2019-02-21 23:20 ` Dhinakaran Pandiyan
2019-02-22 17:12 ` Ville Syrjälä
2019-02-22 17:26 ` Ville Syrjälä
2019-02-22 17:29 ` Pandiyan, Dhinakaran
2019-02-22 18:37 ` Dhinakaran Pandiyan
2019-02-22 18:54 ` Ville Syrjälä
2019-02-22 19:12 ` Pandiyan, Dhinakaran
2019-02-22 19:34 ` Ville Syrjälä
2019-02-23 2:16 ` Dhinakaran Pandiyan
2019-02-21 2:41 ` [igt-dev] [HAX 4/5] lib/igt_fb: s/tiling/modifier/ where appropriate Dhinakaran Pandiyan
2019-02-21 2:41 ` [igt-dev] [HAX 5/5] tests/kms_ccs: Generate compressed surfaces with renderopy Dhinakaran Pandiyan
2019-02-21 10:41 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [HAX,1/5] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy Patchwork
2019-02-21 15:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-21 18:25 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [HAX,1/5] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy (rev2) Patchwork
2019-02-22 7:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221140613.GL20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox