From: Katarzyna Dec <katarzyna.dec@intel.com>
To: "Dhinakaran Pandiyan" <dhinakaran.pandiyan@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/7] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy
Date: Mon, 25 Feb 2019 14:39:23 +0100 [thread overview]
Message-ID: <20190225133923.GC20992@kdec5-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190221144109.28220-2-dhinakaran.pandiyan@intel.com>
On Thu, Feb 21, 2019 at 06:41:03AM -0800, Dhinakaran Pandiyan wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Set up the surface state accordingly to support Yf/Ys tiling.
>
> From DK:
> Rebase.
>
> Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
> Cc: Katarzyna Dec <katarzyna.dec@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> lib/gen8_render.h | 6 ++++--
> lib/rendercopy_gen9.c | 8 +++++++-
> 2 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/lib/gen8_render.h b/lib/gen8_render.h
> index c62047d8..372c5267 100644
> --- a/lib/gen8_render.h
> +++ b/lib/gen8_render.h
I do not like the idea of adding gen9+ things to gen8 library. We have
gen9_render.h already, maybe you could add this stuct there?
Kasia
> @@ -121,9 +121,11 @@ struct gen8_surface_state
> struct {
> uint32_t mip_count:4;
> uint32_t min_lod:4;
> - uint32_t pad3:6;
> + uint32_t mip_tail_start_lod:4; /* gen9+ */
> + uint32_t pad3:2;
> uint32_t coherency_type:1;
> - uint32_t pad2:5;
> + uint32_t pad2:3;
> + uint32_t trmode:2; /* gen9+ */
> uint32_t ewa_disable_for_cube:1;
> uint32_t y_offset:3;
> uint32_t pad0:1;
> diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
> index e3d95a68..8514c991 100644
> --- a/lib/rendercopy_gen9.c
> +++ b/lib/rendercopy_gen9.c
> @@ -204,9 +204,15 @@ gen8_bind_buf(struct intel_batchbuffer *batch, const struct igt_buf *buf,
> ss->ss0.horizontal_alignment = 1; /* align 4 */
> if (buf->tiling == I915_TILING_X)
> ss->ss0.tiled_mode = 2;
> - else if (buf->tiling == I915_TILING_Y)
> + else if (buf->tiling != I915_TILING_NONE)
> ss->ss0.tiled_mode = 3;
>
> + if (buf->tiling == I915_TILING_Yf)
> + ss->ss5.trmode = 1;
> + else if (buf->tiling == I915_TILING_Ys)
> + ss->ss5.trmode = 2;
> + ss->ss5.mip_tail_start_lod = 1; /* needed with trmode */
> +
> ss->ss8.base_addr = buf->bo->offset64;
> ss->ss9.base_addr_hi = buf->bo->offset64 >> 32;
>
> --
> 2.17.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-25 13:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 14:41 [igt-dev] [PATCH i-g-t 0/7] Use rendercopy for generating CCS buffers Dhinakaran Pandiyan
2019-02-21 14:41 ` [igt-dev] [PATCH i-g-t 1/7] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy Dhinakaran Pandiyan
2019-02-25 13:39 ` Katarzyna Dec [this message]
2019-02-26 21:00 ` Pandiyan, Dhinakaran
2019-02-27 12:56 ` Katarzyna Dec
2019-03-01 20:17 ` Dhinakaran Pandiyan
2019-02-21 14:41 ` [igt-dev] [PATCH i-g-t 2/7] tests/gem_render_copy: Test Yf tiling Dhinakaran Pandiyan
2019-02-25 13:49 ` Katarzyna Dec
2019-03-05 1:50 ` Dhinakaran Pandiyan
2019-02-21 14:41 ` [igt-dev] [PATCH i-g-t 3/7] lib/igt_fb: Use rendercopy for rendering into compressed buffers Dhinakaran Pandiyan
2019-02-21 18:04 ` [igt-dev] [PATCH i-g-t v2 3/8] " Dhinakaran Pandiyan
2019-02-21 14:41 ` [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: s/tiling/modifier/ where appropriate Dhinakaran Pandiyan
2019-02-21 18:05 ` [igt-dev] [PATCH i-g-t v2 4/8] " Dhinakaran Pandiyan
2019-02-21 14:41 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_fb: Function to create a bo for passed in igt_fb Dhinakaran Pandiyan
2019-02-22 16:20 ` Ville Syrjälä
2019-02-21 14:41 ` [igt-dev] [PATCH i-g-t 6/7] tests/kms_ccs: Generate compressed surfaces with rendercopy Dhinakaran Pandiyan
2019-02-22 16:13 ` Ville Syrjälä
2019-02-21 14:41 ` [igt-dev] [PATCH i-g-t 7/7] tests/kms_ccs: Larger fb to fully cover up the primary plane Dhinakaran Pandiyan
2019-02-22 14:19 ` Juha-Pekka Heikkila
2019-02-22 16:18 ` Clinton Taylor
2019-02-23 13:43 ` Juha-Pekka Heikkilä
2019-02-27 7:50 ` Dhinakaran Pandiyan
2019-02-27 14:18 ` Ville Syrjälä
2019-02-21 22:37 ` [igt-dev] ✓ Fi.CI.BAT: success for Use rendercopy for generating CCS buffers Patchwork
2019-02-22 10:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225133923.GC20992@kdec5-desk.ger.corp.intel.com \
--to=katarzyna.dec@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox