Re: [igt-dev] [PATCH i-g-t v1] meson: missed dependency of liblzma

Sergii Romantsov
2019-04-12T13:41:25Z

[-- Attachment #1.1: Type: text/plain, Size: 2220 bytes --]

>
> I'll welcome a patch that makes dependency failures point to the
> Dockerfiles, though

Seems it can be done with meson >= 0.50 - here we can dump a message if
dependency failure.
But it seems to be look as not good solution (one dependency - one message).

As i see in the Dockerfiles listed dependency on liblzma.
So if meson-change is not preferable in that case - so at least readme-file
has to point us about dependencies.

On Tue, Feb 26, 2019 at 12:21 PM Petri Latvala <petri.latvala@intel.com>
wrote:

> On Tue, Feb 26, 2019 at 12:03:07PM +0200, Sergii Romantsov wrote:
> > Hello, Petri.
> >
> >
> > > As I understood you, just installing liblzma-dev makes the build
> > > successful, right?
> >
> >
> > If to be more specific, installing liblzma-dev makes meson-configuration
> > successful.
> >
> > Making this change just lead to better error messages when it's not
> > > installed?
> >
> >
> > Yes, it will show which package exactly leaked instead of unclear error.
> >
> > What is the distro you're using?
> >
> >
> > 4.15.0-45-generic #48~16.04.1-Ubuntu SMP Tue Jan 29 18:03:48 UTC 2019
> > x86_64 x86_64 x86_64 GNU/Linux
> >
> > I think it happens due to specific of meson-dependency - how it looks
> for a
> > package.
> > So command (when liblzma-dev is absent, but liblzma5 is installed)
> > 'pkg-config --cflags --libs libdw'
> > gives:
> > "Package liblzma was not found in the pkg-config search path.
> > Perhaps you should add the directory containing `liblzma.pc'
> > to the PKG_CONFIG_PATH environment variable
> > Package 'liblzma', required by 'libdw', not found"
> >
> > So in my understanding its just because of lack of liblzma.pc
>
>
> Indeed. I checked Ubuntu 16.04's libdw-dev and it:
>
> 1) Has liblzma in Requires.private in libdw.pc
> 2) Does not depend on liblzma-dev
>
> I don't see the bug reported, and I suspect it won't be fixed, with
> 16.04's support ending this year for the desktop version...
>
>
> However, on the patch, I'll have to nak the meson.build change. Having
> better error messages is not a good reason for useless dependency
> declarations. I'll welcome a patch that makes dependency failures
> point to the Dockerfiles, though.
>
>
> --
> Petri Latvala
>

[-- Attachment #1.2: Type: text/html, Size: 3068 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]