From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D55F58997C for ; Mon, 25 Feb 2019 17:25:34 +0000 (UTC) Date: Mon, 25 Feb 2019 19:25:31 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20190225172531.GH20097@intel.com> References: <20190225130237.31592-3-maarten.lankhorst@linux.intel.com> <20190225151300.2631-1-maarten.lankhorst@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190225151300.2631-1-maarten.lankhorst@linux.intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Add flip tests to ensure basic CRC sanity checking, v2. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst Cc: igt-dev@lists.freedesktop.org List-ID: T24gTW9uLCBGZWIgMjUsIDIwMTkgYXQgMDQ6MTM6MDBQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gV2FybiBpZiBhIENSQyBmb3IgZXZlcnkgdW5pcXVlIGNvbG9yIHdpbGwgZW5k IHVwIGJlaW5nIGlkZW50aWNhbCwgaXQncwo+IG5vdCBjb3VudGVkIGFzIGEgdGVzdCBmYWlsdXJl IGJlY2F1c2UgaW50ZWwgbWlnaHQgbm90IGhhbmRsZSBpdCBjb3JyZWN0bHkuCj4gCj4gQWZ0ZXIg dGhpcywgZmxpcCBhbmQgZGlydHlmYiBhIG51bWJlciBvZiB0aW1lcyB0byBlbnN1cmUgdGhhdCBi YXNpYyBDUkMKPiByZWFkaW5nIHdvcmtzIGFzIGludGVuZGVkLgo+IAo+IENoYW5nZXMgc2luY2Ug djE6Cj4gLSBGaXggY2FsbGluZyB3aGVuIG91dHB1dCBpcyBOVUxMLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+ Cj4gU3VnZ2VzdGVkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IC0tLQo+ICB0ZXN0 cy9rbXNfcGlwZV9jcmNfYmFzaWMuYyB8IDg3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA4NCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfcGlwZV9jcmNfYmFzaWMuYyBiL3Rlc3Rz L2ttc19waXBlX2NyY19iYXNpYy5jCj4gaW5kZXggMzZjZTYyNGU0ZTllLi44YTFiNDIwOGRhMjkg MTAwNjQ0Cj4gLS0tIGEvdGVzdHMva21zX3BpcGVfY3JjX2Jhc2ljLmMKPiArKysgYi90ZXN0cy9r bXNfcGlwZV9jcmNfYmFzaWMuYwo+IEBAIC0yOSw3ICsyOSw3IEBACj4gICNpbmNsdWRlIDxzdGRp by5oPgo+ICAjaW5jbHVkZSA8c3RyaW5nLmg+Cj4gICNpbmNsdWRlIDxmY250bC5oPgo+IC0KPiAr I2luY2x1ZGUgImlndF9yYW5kLmgiCj4gIAo+ICB0eXBlZGVmIHN0cnVjdCB7Cj4gIAlpbnQgZHJt X2ZkOwo+IEBAIC00MSw5ICs0MSwxNSBAQCB0eXBlZGVmIHN0cnVjdCB7Cj4gIHN0YXRpYyBzdHJ1 Y3Qgewo+ICAJZG91YmxlIHIsIGcsIGI7Cj4gIAlpZ3RfY3JjX3QgY3JjOwo+IC19IGNvbG9yc1sy XSA9IHsKPiArfSBjb2xvcnNbXSA9IHsKPiArCXsgLnIgPSAwLjAsIC5nID0gMC4wLCAuYiA9IDAu MCB9LAo+ICsJeyAuciA9IDAuMCwgLmcgPSAwLjAsIC5iID0gMS4wIH0sCj4gIAl7IC5yID0gMC4w LCAuZyA9IDEuMCwgLmIgPSAwLjAgfSwKPiAgCXsgLnIgPSAwLjAsIC5nID0gMS4wLCAuYiA9IDEu MCB9LAo+ICsJeyAuciA9IDEuMCwgLmcgPSAwLjAsIC5iID0gMC4wIH0sCj4gKwl7IC5yID0gMS4w LCAuZyA9IDAuMCwgLmIgPSAxLjAgfSwKPiArCXsgLnIgPSAxLjAsIC5nID0gMS4wLCAuYiA9IDAu MCB9LAo+ICsJeyAuciA9IDEuMCwgLmcgPSAxLjAsIC5iID0gMS4wIH0sCj4gIH07Cj4gIAo+ICBz dGF0aWMgdm9pZCB0ZXN0X2JhZF9zb3VyY2UoZGF0YV90ICpkYXRhKQo+IEBAIC0xNTMsMTAgKzE1 OSw4MiBAQCBzdGF0aWMgdm9pZCB0ZXN0X3JlYWRfY3JjKGRhdGFfdCAqZGF0YSwgZW51bSBwaXBl IHBpcGUsIHVuc2lnbmVkIGZsYWdzKQo+ICAJfQo+ICB9Cj4gIAo+IC1kYXRhX3QgZGF0YSA9IHsw LCB9Owo+ICtzdGF0aWMgdm9pZCB0ZXN0X2ZsaXBfY3JjKGRhdGFfdCAqZGF0YSwgZW51bSBwaXBl IHBpcGUpCj4gK3sKPiArCWlndF9kaXNwbGF5X3QgKmRpc3BsYXkgPSAmZGF0YS0+ZGlzcGxheTsK PiArCWlndF9vdXRwdXRfdCAqb3V0cHV0ID0gaWd0X2dldF9zaW5nbGVfb3V0cHV0X2Zvcl9waXBl KGRpc3BsYXksIHBpcGUpOwo+ICsJaWd0X3BsYW5lX3QgKnByaW1hcnk7Cj4gKwlkcm1Nb2RlTW9k ZUluZm8gKm1vZGU7Cj4gKwlpZ3RfY3JjX3QgcmVmX2NyY3NbQVJSQVlfU0laRShjb2xvcnMpXSwg Y3JjOwo+ICsJaW50IGMsIGksIGo7Cj4gKwlzdHJ1Y3QgaWd0X2ZiIGZic1tBUlJBWV9TSVpFKGNv bG9ycyldID0ge307Cj4gKwlpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmM7Cj4gKwl1bnNpZ25lZCBz ZWVkID0gMHgxMjM0NTY3ICogKHBpcGUgKyAxKTsKPiArCWludCBwcmV2Owo+ICsKPiArCWlndF9z a2lwX29uKHBpcGUgPj0gZGlzcGxheS0+bl9waXBlcyk7Cj4gKwlpZ3RfcmVxdWlyZV9mKG91dHB1 dCwgIk5vIGNvbm5lY3RvciBmb3VuZCBmb3IgcGlwZSAlc1xuIiwKPiArCQkgICAgICBrbXN0ZXN0 X3BpcGVfbmFtZShwaXBlKSk7Cj4gKwo+ICsJaWd0X2Rpc3BsYXlfcmVzZXQoZGlzcGxheSk7Cj4g KwlpZ3Rfb3V0cHV0X3NldF9waXBlKG91dHB1dCwgcGlwZSk7Cj4gKwltb2RlID0gaWd0X291dHB1 dF9nZXRfbW9kZShvdXRwdXQpOwo+ICsJcHJpbWFyeSA9IGlndF9vdXRwdXRfZ2V0X3BsYW5lKG91 dHB1dCwgMCk7Cj4gKwo+ICsJZm9yIChjID0gMDsgYyA8IEFSUkFZX1NJWkUoY29sb3JzKTsgYysr KSB7Cj4gKwkJaWd0X2NyZWF0ZV9jb2xvcl9mYihkaXNwbGF5LT5kcm1fZmQsCj4gKwkJCQkgICAg bW9kZS0+aGRpc3BsYXksIG1vZGUtPnZkaXNwbGF5LAo+ICsJCQkJICAgIERSTV9GT1JNQVRfWFJH Qjg4ODgsCj4gKwkJCQkgICAgTE9DQUxfRFJNX0ZPUk1BVF9NT0RfTk9ORSwKPiArCQkJCSAgICBj b2xvcnNbY10uciwKPiArCQkJCSAgICBjb2xvcnNbY10uZywKPiArCQkJCSAgICBjb2xvcnNbY10u YiwKPiArCQkJCSAgICAmZmJzW2NdKTsKPiArCj4gKwkJaWd0X3BsYW5lX3NldF9mYihwcmltYXJ5 LCAmZmJzW2NdKTsKPiArCQlpZ3RfZGlzcGxheV9jb21taXQyKGRpc3BsYXksIGMgPyBDT01NSVRf VU5JVkVSU0FMIDogQ09NTUlUX0xFR0FDWSk7Cj4gKwkJaWYgKCFjKQo+ICsJCQlwaXBlX2NyYyA9 IGlndF9waXBlX2NyY19uZXcoZGlzcGxheS0+ZHJtX2ZkLCBwaXBlLAo+ICsJCQkJCQkgICAgSU5U RUxfUElQRV9DUkNfU09VUkNFX0FVVE8pOwo+ICsKPiArCQlpZ3RfcGlwZV9jcmNfY29sbGVjdF9j cmMocGlwZV9jcmMsICZyZWZfY3Jjc1tjXSk7Cj4gKwo+ICsJCWZvciAoaiA9IGMgLSAxOyBqID49 IDA7IGotLSkKPiArCQkJaWd0X3dhcm5fb25fZihpZ3RfY2hlY2tfY3JjX2VxdWFsKCZyZWZfY3Jj c1tjXSwgJnJlZl9jcmNzW2pdKSwKPiArCQkJCSJJZGVudGljYWwgQ1JDIGZvciB2ZXJ5IGRpZmZl cmVudCBjb2xvcnMsICVnICVnICVnIHZzICVnICVnICVnXG4iLAo+ICsJCQkJY29sb3JzW2NdLnIs IGNvbG9yc1tjXS5nLCBjb2xvcnNbY10uYiwKPiArCQkJCWNvbG9yc1tqXS5yLCBjb2xvcnNbal0u ZywgY29sb3JzW2pdLmIpOwo+ICsJfQo+ICsKPiArCWlndF9waXBlX2NyY19zdGFydChwaXBlX2Ny Yyk7Cj4gKwo+ICsJcHJldiA9IGM7Cj4gKwlmb3IgKGkgPSAwOyBpIDwgMTAgKiBBUlJBWV9TSVpF KGNvbG9ycyk7IGkrKykgewo+ICsJCWMgPSBoYXJzX3BldHJ1c2thX2Y1NF8xX3JhbmRvbSgmc2Vl ZCkgJSBBUlJBWV9TSVpFKGNvbG9ycyk7Cj4gKwkJaWd0X2RlYnVnKCJUZXN0aW5nIGNvbG9yICVn ICVnICVnIHdpdGggJXNcbiIsCj4gKwkJCSAgY29sb3JzW2NdLnIsIGNvbG9yc1tjXS5nLCBjb2xv cnNbY10uYiwKPiArCQkJICBjID09IHByZXYgPyAiZGlydHlmYiIgOiAiY29tbWl0Iik7Cj4gKwo+ ICsJCWlmIChjICE9IHByZXYpIHsKPiArCQkJaWd0X3BsYW5lX3NldF9mYihwcmltYXJ5LCAmZmJz W2NdKTsKPiArCQkJaWd0X2Rpc3BsYXlfY29tbWl0MihkaXNwbGF5LCBDT01NSVRfVU5JVkVSU0FM KTsKPiArCQl9IGVsc2Ugewo+ICsJCQlpZ3RfZGlydHlfZmIoZGlzcGxheS0+ZHJtX2ZkLCAmZmJz W2NdKTsKPiArCQkJaWd0X3dhaXRfZm9yX3ZibGFuayhkaXNwbGF5LT5kcm1fZmQsIHBpcGUpOwo+ ICsJCX0KPiArCj4gKwkJaWd0X3BpcGVfY3JjX2dldF9jdXJyZW50KGRpc3BsYXktPmRybV9mZCwg cGlwZV9jcmMsICZjcmMpOwoKV2hlbiBmbGlwcGluZyBpdCBtaWdodCBiZSBuaWNlIHRvIGNoZWNr IGV2ZXJ5IGNyYyB0byBtYWtlIHN1cmUKdGhlcmUgYXJlIG5vIGJhZCBvbmVzIGluIHRoZSBtaWRk bGUgb2YgdGhlIHNlcXVlbmNlLgoKPiArCQlpZ3RfYXNzZXJ0X2NyY19lcXVhbCgmcmVmX2NyY3Nb Y10sICZjcmMpOwo+ICsJCXByZXYgPSBjOwo+ICsJfQo+ICsKPiArCWZvciAoYyA9IDA7IGMgPCBB UlJBWV9TSVpFKGNvbG9ycyk7IGMrKykKPiArCQlpZ3RfcmVtb3ZlX2ZiKGRpc3BsYXktPmRybV9m ZCwgJmZic1tjXSk7Cj4gK30KPiAgCj4gIGlndF9tYWluCj4gIHsKPiArCWRhdGFfdCBkYXRhID0g e307Cj4gIAllbnVtIHBpcGUgcGlwZTsKPiAgCj4gIAlpZ3RfZml4dHVyZSB7Cj4gQEAgLTIxMCw2 ICsyODgsOSBAQCBpZ3RfbWFpbgo+ICAKPiAgCQkJaWd0X2Rpc2FsbG93X2hhbmcoZGF0YS5kcm1f ZmQsIGhhbmcpOwo+ICAJCX0KPiArCj4gKwkJaWd0X3N1YnRlc3RfZigiZmxpcC1jcmMtcGlwZS0l cyIsIGttc3Rlc3RfcGlwZV9uYW1lKHBpcGUpKQo+ICsJCQl0ZXN0X2ZsaXBfY3JjKCZkYXRhLCBw aXBlKTsKPiAgCX0KPiAgCj4gIAlpZ3RfZml4dHVyZSB7Cj4gLS0gCj4gMi4yMC4xCj4gCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBpZ3QtZGV2IG1h aWxpbmcgbGlzdAo+IGlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2CgotLSAKVmlsbGUgU3ly asOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==