From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: IGT development <igt-dev@lists.freedesktop.org>,
Keith Packard <keithp@keithp.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH 2/7] drm/lease: Drop recursive leads checks
Date: Thu, 28 Feb 2019 15:49:05 +0100 [thread overview]
Message-ID: <20190228144910.26488-3-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190228144910.26488-1-daniel.vetter@ffwll.ch>
We disallow subleasing, so no point checking whether the master holds
all the leases - it will.
Spotted while typing exhaustive igt coverage for all these corner
cases.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/drm_lease.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c
index 1176d814cf7f..cce5d9dd52ff 100644
--- a/drivers/gpu/drm/drm_lease.c
+++ b/drivers/gpu/drm/drm_lease.c
@@ -220,8 +220,6 @@ static struct drm_master *drm_lease_create(struct drm_master *lessor, struct idr
error = 0;
if (!idr_find(&dev->mode_config.object_idr, object))
error = -ENOENT;
- else if (!_drm_lease_held_master(lessor, object))
- error = -EACCES;
else if (_drm_has_leased(lessor, object))
error = -EBUSY;
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-28 14:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 14:49 [igt-dev] [PATCH 0/7] some cleanups and uapi clarification for leases Daniel Vetter
2019-02-28 14:49 ` [igt-dev] [PATCH 1/7] drm/leases: Drop object_id validation for negative ids Daniel Vetter
2019-03-14 7:54 ` Boris Brezillon
2019-03-29 4:46 ` Dave Airlie
2019-03-29 8:28 ` Daniel Vetter
2019-02-28 14:49 ` Daniel Vetter [this message]
2019-03-14 8:44 ` [igt-dev] [PATCH 2/7] drm/lease: Drop recursive leads checks Boris Brezillon
2019-02-28 14:49 ` [igt-dev] [PATCH 3/7] drm/leases: Don't init to 0 in drm_master_create Daniel Vetter
2019-03-14 7:56 ` Boris Brezillon
2019-03-29 4:47 ` Dave Airlie
2019-02-28 14:49 ` [igt-dev] [PATCH 4/7] drm/lease: Check for lessor outside of locks Daniel Vetter
2019-03-14 8:07 ` Boris Brezillon
2019-04-03 1:33 ` Dave Airlie
2019-04-03 7:04 ` Daniel Vetter
2019-04-03 7:50 ` Boris Brezillon
2019-02-28 14:49 ` [igt-dev] [PATCH 5/7] drm/lease: Make sure implicit planes are leased Daniel Vetter
2019-03-05 13:35 ` Sasha Levin
2019-02-28 14:49 ` [igt-dev] [PATCH 6/7] drm/atomic: Wire file_priv through for property changes Daniel Vetter
2019-02-28 14:49 ` [igt-dev] [PATCH 7/7] drm/atomic: -EACCESS for lease-denied crtc lookup Daniel Vetter
2019-03-14 8:58 ` [igt-dev] [PATCH 0/7] some cleanups and uapi clarification for leases Boris Brezillon
2019-04-05 2:40 ` Dave Airlie
2019-04-24 9:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228144910.26488-3-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox