From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT development <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master
Date: Fri, 1 Mar 2019 08:55:00 +0100 [thread overview]
Message-ID: <20190301075500.GS2665@phenom.ffwll.local> (raw)
In-Reply-To: <155137641692.5847.3262521320199157636@skylake-alporthouse-com>
On Thu, Feb 28, 2019 at 05:53:42PM +0000, Chris Wilson wrote:
> Quoting Daniel Vetter (2019-02-28 17:17:23)
> > Suggested by Chris.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > tests/core_setmaster_vs_auth.c | 6 ++++--
> > tests/kms_flip_event_leak.c | 10 ++++------
> > tests/kms_lease.c | 11 ++++++-----
> > 3 files changed, 14 insertions(+), 13 deletions(-)
> >
> > diff --git a/tests/core_setmaster_vs_auth.c b/tests/core_setmaster_vs_auth.c
> > index c335ddff3a2d..f9e97c7a57ef 100644
> > --- a/tests/core_setmaster_vs_auth.c
> > +++ b/tests/core_setmaster_vs_auth.c
> > @@ -39,6 +39,8 @@
> > #include <stdio.h>
> > #include <string.h>
> >
> > +#include <igt_device.h>
>
> "igt_device.h" for a local header?
Polished and merged, thanks for your review.
-Daniel
>
> Conversions look fine otherwise.
>
> With "",
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-01 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 17:17 [igt-dev] [PATCH i-g-t 1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Daniel Vetter
2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 2/4] tests:core_prop_blob: Drop local_ prefixes Daniel Vetter
2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 3/4] tests: s/core_prop_blob/kms_prop_blob Daniel Vetter
2019-02-28 17:17 ` [igt-dev] [PATCH i-g-t 4/4] tests: Use igt_device_set/drop_master Daniel Vetter
2019-02-28 17:53 ` Chris Wilson
2019-03-01 7:55 ` Daniel Vetter [this message]
2019-02-28 17:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_addfb_basic: Check that only the owner can rmfb Patchwork
2019-02-28 20:42 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301075500.GS2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox