From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/7] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy
Date: Mon, 4 Mar 2019 17:47:37 -0800 [thread overview]
Message-ID: <20190305014742.3598-2-dhinakaran.pandiyan@intel.com> (raw)
In-Reply-To: <20190305014742.3598-1-dhinakaran.pandiyan@intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Set up the surface state accordingly to support Yf/Ys tiling.
From DK:
Rebase.
Move support to gen-9 surface state
Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
Cc: Katarzyna Dec <katarzyna.dec@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
lib/gen9_render.h | 6 ++++--
lib/rendercopy_gen9.c | 8 +++++++-
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/gen9_render.h b/lib/gen9_render.h
index 48945019..9ee5782b 100644
--- a/lib/gen9_render.h
+++ b/lib/gen9_render.h
@@ -67,9 +67,11 @@ struct gen9_surface_state {
struct {
uint32_t mip_count:4;
uint32_t min_lod:4;
- uint32_t pad3:6;
+ uint32_t mip_tail_start_lod:4;
+ uint32_t pad3:2;
uint32_t coherency_type:1;
- uint32_t pad2:5;
+ uint32_t pad2:3;
+ uint32_t trmode:2;
uint32_t ewa_disable_for_cube:1;
uint32_t y_offset:3;
uint32_t pad0:1;
diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
index b21b43c0..2cf1ab16 100644
--- a/lib/rendercopy_gen9.c
+++ b/lib/rendercopy_gen9.c
@@ -204,9 +204,15 @@ gen8_bind_buf(struct intel_batchbuffer *batch, const struct igt_buf *buf,
ss->ss0.horizontal_alignment = 1; /* align 4 */
if (buf->tiling == I915_TILING_X)
ss->ss0.tiled_mode = 2;
- else if (buf->tiling == I915_TILING_Y)
+ else if (buf->tiling != I915_TILING_NONE)
ss->ss0.tiled_mode = 3;
+ if (buf->tiling == I915_TILING_Yf)
+ ss->ss5.trmode = 1;
+ else if (buf->tiling == I915_TILING_Ys)
+ ss->ss5.trmode = 2;
+ ss->ss5.mip_tail_start_lod = 1; /* needed with trmode */
+
ss->ss8.base_addr = buf->bo->offset64;
ss->ss9.base_addr_hi = buf->bo->offset64 >> 32;
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-05 1:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 1:47 [igt-dev] [PATCH i-g-t 1/7] lib/rendercopy: Copy gen8 surface state definition to gen-9 header Dhinakaran Pandiyan
2019-03-05 1:47 ` Dhinakaran Pandiyan [this message]
2019-03-05 10:14 ` [igt-dev] [PATCH i-g-t 2/7] lib/rendercopy: Add support for Yf/Ys tiling to gen9 rendercopy Katarzyna Dec
2019-03-07 1:39 ` Pandiyan, Dhinakaran
2019-03-05 1:47 ` [igt-dev] [PATCH i-g-t 3/7] tests/gem_render_copy: Test Yf tiling Dhinakaran Pandiyan
2019-03-05 14:26 ` Katarzyna Dec
2019-03-07 0:58 ` Dhinakaran Pandiyan
2019-03-08 9:59 ` Katarzyna Dec
2019-03-07 1:33 ` [igt-dev] [PATCH i-g-t v2 " Dhinakaran Pandiyan
2019-03-09 3:36 ` [igt-dev] [PATCH i-g-t v3 " Dhinakaran Pandiyan
2019-03-05 1:47 ` [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Use rendercopy for rendering into compressed buffers Dhinakaran Pandiyan
2019-03-06 22:42 ` Clinton Taylor
2019-03-05 1:47 ` [igt-dev] [PATCH i-g-t 5/7] lib/igt_fb: s/tiling/modifier/ where appropriate Dhinakaran Pandiyan
2019-03-05 1:47 ` [igt-dev] [PATCH i-g-t 6/7] lib/igt_fb: Function to create a bo for passed in igt_fb Dhinakaran Pandiyan
2019-03-05 1:47 ` [igt-dev] [PATCH i-g-t 7/7] tests/kms_ccs: Generate compressed surfaces with rendercopy Dhinakaran Pandiyan
2019-03-05 2:47 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/7] lib/rendercopy: Copy gen8 surface state definition to gen-9 header Patchwork
2019-03-05 8:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-05 10:12 ` [igt-dev] [PATCH i-g-t 1/7] " Katarzyna Dec
2019-03-07 2:07 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/7] lib/rendercopy: Copy gen8 surface state definition to gen-9 header (rev2) Patchwork
2019-03-07 3:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-09 4:18 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/7] lib/rendercopy: Copy gen8 surface state definition to gen-9 header (rev3) Patchwork
2019-03-09 9:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-12 10:13 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/7] lib/rendercopy: Copy gen8 surface state definition to gen-9 header (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305014742.3598-2-dhinakaran.pandiyan@intel.com \
--to=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox