From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t 3/5] lib/debugfs: Ensure null-termination in igt_hpd_storm_detected
Date: Thu, 7 Mar 2019 13:24:25 +0200 [thread overview]
Message-ID: <20190307112427.29146-3-petri.latvala@intel.com> (raw)
In-Reply-To: <20190307112427.29146-1-petri.latvala@intel.com>
Read sizeof - 1 to buf so it stays null-terminated.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
lib/igt_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 640c78e9..b0e5cfa5 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -628,7 +628,7 @@ bool igt_hpd_storm_detected(int drm_fd)
if (fd < 0)
return false;
- igt_assert_lt(0, read(fd, buf, sizeof(buf)));
+ igt_assert_lt(0, read(fd, buf, sizeof(buf) - 1));
igt_assert(start_loc = strstr(buf, "Detected: "));
igt_assert_eq(sscanf(start_loc, "Detected: %s\n", detected_str), 1);
--
2.19.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-07 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 11:24 [igt-dev] [PATCH i-g-t 1/5] lib/aux: Plug memory leak in __igt_lsof_fds Petri Latvala
2019-03-07 11:24 ` [igt-dev] [PATCH i-g-t 2/5] lib/aux: Plug memory leak in get_suspend_test Petri Latvala
2019-03-07 12:09 ` Chris Wilson
2019-03-07 12:10 ` Chris Wilson
2019-03-07 12:37 ` [igt-dev] [PATCH i-g-t v2 " Petri Latvala
2019-03-07 12:39 ` Chris Wilson
2019-03-07 11:24 ` Petri Latvala [this message]
2019-03-07 12:11 ` [igt-dev] [PATCH i-g-t 3/5] lib/debugfs: Ensure null-termination in igt_hpd_storm_detected Chris Wilson
2019-03-07 11:24 ` [igt-dev] [PATCH i-g-t 4/5] lib/fb: Add missing break in get_yuv_parameters Petri Latvala
2019-03-07 11:24 ` [igt-dev] [PATCH i-g-t 5/5] lib/igt_pm: Avoid out-of-bounds reads and writes Petri Latvala
2019-03-07 12:16 ` Chris Wilson
2019-03-07 13:01 ` [igt-dev] [PATCH i-g-t v2 " Petri Latvala
2019-03-07 13:13 ` Chris Wilson
2019-03-07 12:08 ` [igt-dev] [PATCH i-g-t 1/5] lib/aux: Plug memory leak in __igt_lsof_fds Chris Wilson
2019-03-07 17:04 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/aux: Plug memory leak in __igt_lsof_fds (rev4) Patchwork
2019-03-07 18:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307112427.29146-3-petri.latvala@intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox