public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/3] lib/drmtest: Add helpers to check and require amdgpu
Date: Fri, 8 Mar 2019 09:36:01 -0500	[thread overview]
Message-ID: <20190308143603.3620-1-nicholas.kazlauskas@amd.com> (raw)

These helpers will be used to address amdgpu specific quirks and
features. They're implemented like the i915 and VC4 helpers.

In order for the string comparison to pick up "amdgpu" the buffer size
had to be expanded for __is_device. I've gone ahead and made it 12 bytes
to cover everything that's there right now.

Cc: Leo Li <sunpeng.li@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 lib/drmtest.c | 12 +++++++++++-
 lib/drmtest.h |  2 ++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 6506791b..d09638e8 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -93,7 +93,7 @@ static int __get_drm_device_name(int fd, char *name, int name_size)
 
 static bool __is_device(int fd, const char *expect)
 {
-	char name[5] = "";
+	char name[12] = "";
 
 	if (__get_drm_device_name(fd, name, sizeof(name) - 1))
 		return false;
@@ -101,6 +101,11 @@ static bool __is_device(int fd, const char *expect)
 	return strcmp(expect, name) == 0;
 }
 
+bool is_amdgpu_device(int fd)
+{
+	return __is_device(fd, "amdgpu");
+}
+
 bool is_i915_device(int fd)
 {
 	return __is_device(fd, "i915");
@@ -485,6 +490,11 @@ int drm_open_driver_render(int chipset)
 	return fd;
 }
 
+void igt_require_amdgpu(int fd)
+{
+	igt_require(is_amdgpu_device(fd));
+}
+
 void igt_require_intel(int fd)
 {
 	igt_require(is_i915_device(fd) && has_known_intel_chipset(fd));
diff --git a/lib/drmtest.h b/lib/drmtest.h
index ca347a71..f509e0d4 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -79,9 +79,11 @@ int __drm_open_driver(int chipset);
 
 void gem_quiescent_gpu(int fd);
 
+void igt_require_amdgpu(int fd);
 void igt_require_intel(int fd);
 void igt_require_vc4(int fd);
 
+bool is_amdgpu_device(int fd);
 bool is_i915_device(int fd);
 bool is_vc4_device(int fd);
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-03-08 14:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 14:36 Nicholas Kazlauskas [this message]
2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 2/3] lib/debugfs: Don't do CRC sanity checks on amdgpu Nicholas Kazlauskas
2019-03-08 14:36 ` [igt-dev] [PATCH i-g-t 3/3] lib/fb: Clear framebuffer " Nicholas Kazlauskas
2019-03-08 14:40   ` Chris Wilson
2019-03-08 15:00     ` Kazlauskas, Nicholas
2019-03-08 15:08       ` Chris Wilson
2019-03-08 15:10         ` Kazlauskas, Nicholas
2019-03-08 17:45 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] lib/drmtest: Add helpers to check and require amdgpu Patchwork
2019-03-08 21:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190308143603.3620-1-nicholas.kazlauskas@amd.com \
    --to=nicholas.kazlauskas@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox