Re: [igt-dev] [PATCH v2 0/1] Skip 2x-cursor-vs-flip subtests for gen > 9

Chris Wilson
2019-03-12T16:26:28Z

Quoting Chris Wilson (2019-03-12 16:21:55)
> Quoting Neel Desai (2019-03-12 16:12:43)
> > Skip the following for gen > 9
> >
> > 1.) tests/kms_cursor_legacy@2x-cursor-vs-flip-atomic
> > 2.) tests/kms_cursor_legacy@2x-cursor-vs-flip-legacy
> > 3.) tests/kms_cursor_legacy@2x-long-cursor-vs-flip-atomic
> > 4.) tests/kms_cursor_legacy@2x-long-cursor-vs-flip-legacy
> >
> > Due to DDB allocation changes, we have to add all the planes to the
> > drm_atomic_state post gen 9. When the watermarks are computed by the
> > kernel, the cursor plane is added to the drm_atomic_state which
> > introduces a dependency on hw_done object when the kernel processes
> > DRM_IOCTL_MODE_ATOMIC and DRM_IOCTL_MODE_CURSOR in parallel. There is no
> > race-free way to handle this corner case. These subtests made sense for
> > older generations but not anymore. Hence, skipping these sub-tests post
> > gen 9.
>
> Or fail. Mark it as expected; come back when problem is solved or HW has
> moved on.

To be a little more verbose, the user expectations haven't changed, and
so the failure is a valid indication that the UX is subpar.
-Chris