From: Andi Shyti <andi.shyti@intel.com>
To: IGT dev <igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi@etezian.org>
Subject: [igt-dev] [PATCH v11 3/6] lib/igt_gt: use for_each_engine2 to loop through engines
Date: Tue, 12 Mar 2019 19:17:25 +0200 [thread overview]
Message-ID: <20190312171728.3352-4-andi.shyti@intel.com> (raw)
In-Reply-To: <20190312171728.3352-1-andi.shyti@intel.com>
'for_each_engine2()' defines a loop through the gpu engines.
It can work with both active and pre-defined engines.
In case we are looping through active engines (i.e. the running
kernel has the query and get/setparam ioctls), the
intel_active_engines2 points to an array that contains only the
list engines dynamically allocated after having interrogated the
driver.
While, if we are looping through pre-defined engines,
intel_active_engines2 points to the 'intel_execution_engines2'
array and works exactly as for_each_engine() but using the
new 'struct intel_execution_engine2' data type.
Signed-off-by: Andi Shyti <andi.shyti@intel.com>
---
Hi Tvrtko,
after this series goes in, I will cleanup the other for_each...
like the one you recommended, "for_each_engine_class_instance()".
(BTW, I was anaware of it :) ).
Andi
lib/igt_gt.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/lib/igt_gt.h b/lib/igt_gt.h
index f4bd6c22a81a..39768b5148ef 100644
--- a/lib/igt_gt.h
+++ b/lib/igt_gt.h
@@ -30,6 +30,8 @@
#include "i915_drm.h"
+#include "i915/gem_engine_topology.h"
+
void igt_require_hang_ring(int fd, int ring);
typedef struct igt_hang {
@@ -86,6 +88,12 @@ extern const struct intel_execution_engine {
e__++) \
for_if (gem_ring_has_physical_engine(fd__, flags__ = e__->exec_id | e__->flags))
+#define for_each_engine2(fd, ctx) \
+ for (struct intel_execution_engine2 *e2__ = \
+ __gem_prepare_context_engines(fd, ctx); e2__->name; e2__++) \
+ for_if (get_active_engines(fd) || \
+ gem_has_engine(fd, e2__->class, e2__->instance))
+
bool gem_ring_is_physical_engine(int fd, unsigned int ring);
bool gem_ring_has_physical_engine(int fd, unsigned int ring);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-12 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 17:17 [igt-dev] [PATCH v11 0/6] new engine discovery interface Andi Shyti
2019-03-12 17:17 ` [igt-dev] [PATCH v11 1/6] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-03-12 17:17 ` [igt-dev] [PATCH v11 2/6] lib/i915: add gem_engine_topology library Andi Shyti
2019-03-13 7:41 ` Tvrtko Ursulin
2019-03-13 8:44 ` Andi Shyti
2019-03-12 17:17 ` Andi Shyti [this message]
2019-03-12 17:17 ` [igt-dev] [PATCH v11 4/6] lib: ioctl_wrappers: reach engines by index as well Andi Shyti
2019-03-12 17:17 ` [igt-dev] [PATCH v11 5/6] lib: move gem_context_has_engine from ioctl_wrappers to gem_context Andi Shyti
2019-03-12 17:17 ` [igt-dev] [PATCH v11 6/6] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test Andi Shyti
2019-03-13 12:53 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-03-13 16:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312171728.3352-4-andi.shyti@intel.com \
--to=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox