public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [RFC 3/4] tests/i915/gem_mmap_wc: Add invalid params tests
Date: Tue, 12 Mar 2019 14:57:37 -0700	[thread overview]
Message-ID: <20190312215738.5598-4-antonio.argenziano@intel.com> (raw)
In-Reply-To: <20190312215738.5598-1-antonio.argenziano@intel.com>

Add some invalid parameters tests for the MMAP IOCTL when the MMAP_WC
flag is supplied.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
---
 tests/i915/gem_mmap_wc.c | 52 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/tests/i915/gem_mmap_wc.c b/tests/i915/gem_mmap_wc.c
index baa68aa8..66945c87 100644
--- a/tests/i915/gem_mmap_wc.c
+++ b/tests/i915/gem_mmap_wc.c
@@ -463,6 +463,58 @@ igt_main
 		gem_require_mmap_wc(fd);
 	}
 
+	igt_subtest_group {
+
+		igt_subtest("bad-object") {
+			int ret;
+			struct drm_i915_gem_mmap arg;
+
+			memset(&arg, 0, sizeof(arg));
+			arg.handle = 0x10101010;
+			arg.offset = 0;
+			arg.size = 4096;
+			arg.flags = I915_MMAP_WC;
+
+			errno = 0;
+
+			ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+			igt_assert(ret == -1 && errno == ENOENT);
+		}
+
+		igt_subtest("bad-offset") {
+			int ret;
+			struct drm_i915_gem_mmap arg;
+
+			memset(&arg, 0, sizeof(arg));
+			arg.handle = gem_create(fd, 4096);
+			arg.offset = 4096 + 1;
+			arg.size = 4096;
+			arg.flags = I915_MMAP_WC;
+
+			errno = 0;
+
+			ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+			arg.flags = I915_MMAP_WC;
+			igt_assert(ret == -1 && errno == EINVAL);
+		}
+
+		igt_subtest("bad-size") {
+			int ret;
+			struct drm_i915_gem_mmap arg;
+
+			memset(&arg, 0, sizeof(arg));
+			arg.handle = gem_create(fd, 4096);
+			arg.offset = 4096;
+			arg.size = 0;
+			arg.flags = I915_MMAP_WC;
+
+			errno = 0;
+
+			ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+			igt_assert(ret == -1 && errno == EINVAL);
+		}
+	}
+
 	igt_subtest("invalid-flags")
 		test_invalid_flags(fd);
 	igt_subtest("close")
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-03-12 21:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 21:57 [igt-dev] [RFC 0/4] Improve mmap interface coverage Antonio Argenziano
2019-03-12 21:57 ` [igt-dev] [RFC 1/4] tests/i915/gem_mmap_gtt: Add invalid parameters test Antonio Argenziano
2019-03-12 22:04   ` Chris Wilson
2019-03-12 22:11     ` Antonio Argenziano
2019-03-12 22:18       ` Chris Wilson
2019-03-12 21:57 ` [igt-dev] [RFC 2/4] tests/i915/gem_mmap: Add invalid parameters tests Antonio Argenziano
2019-03-12 22:02   ` Chris Wilson
2019-03-12 22:13     ` Antonio Argenziano
2019-03-13 22:18     ` Antonio Argenziano
2019-03-13 22:52       ` Chris Wilson
2019-03-12 21:57 ` Antonio Argenziano [this message]
2019-03-12 21:57 ` [igt-dev] [RFC 4/4] tests/i915/prime_mmap: Add WC correctness test Antonio Argenziano
2019-03-12 22:07   ` Chris Wilson
2019-03-13 13:38 ` [igt-dev] ✓ Fi.CI.BAT: success for Improve mmap interface coverage Patchwork
2019-03-13 16:12 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190312215738.5598-4-antonio.argenziano@intel.com \
    --to=antonio.argenziano@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox