public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane: Set output to PIPE_NONE at end of test_format_plane
Date: Wed, 13 Mar 2019 16:12:19 -0400	[thread overview]
Message-ID: <20190313201219.7804-1-nicholas.kazlauskas@amd.com> (raw)

AMDGPU rejects commits that have an active CRTC without an active
primary plane.

The pixel-format-pipe-* tests fail on AMDGPU during the cleanup at
the end of the test due to the final commit disabling all the planes but
not the CRTC.

Disable the CRTC when cleaning up by setting the output to PIPE_NONE.

Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 tests/kms_plane.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 9c330ae4..969a61c8 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -586,6 +586,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
 
 	igt_plane_set_fb(primary, NULL);
 	igt_plane_set_fb(plane, NULL);
+	igt_output_set_pipe(output, PIPE_NONE);
 	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 
 	igt_remove_fb(data->drm_fd, &fb);
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-03-13 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 20:12 Nicholas Kazlauskas [this message]
2019-03-13 21:13 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: Set output to PIPE_NONE at end of test_format_plane Patchwork
2019-03-14  4:32 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-03-14 12:31 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190313201219.7804-1-nicholas.kazlauskas@amd.com \
    --to=nicholas.kazlauskas@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox