public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 3/3] tests/i915/gem_mmap_wc: Add invalid params tests
Date: Wed, 13 Mar 2019 16:27:21 -0700	[thread overview]
Message-ID: <20190313232721.6212-3-antonio.argenziano@intel.com> (raw)
In-Reply-To: <20190313232721.6212-1-antonio.argenziano@intel.com>

Add some invalid parameters tests for the MMAP IOCTL when the MMAP_WC
flag is supplied.

v2:
	- Expand test space. (Chris)

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
---
 tests/i915/gem_mmap_wc.c | 90 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 90 insertions(+)

diff --git a/tests/i915/gem_mmap_wc.c b/tests/i915/gem_mmap_wc.c
index baa68aa8..ba05bb50 100644
--- a/tests/i915/gem_mmap_wc.c
+++ b/tests/i915/gem_mmap_wc.c
@@ -463,6 +463,96 @@ igt_main
 		gem_require_mmap_wc(fd);
 	}
 
+	igt_subtest_group {
+
+		igt_subtest("bad-object") {
+			int ret;
+			struct drm_i915_gem_mmap arg;
+			uint32_t real_handle = gem_create(fd, 4096);
+			uint32_t handles[20];
+			int i = 0;
+
+			handles[i++] = 0xdeadbeef;
+			for(int bit = 0; bit < 16; bit++)
+				handles[i++] = real_handle | (1 << (bit + 16));
+			handles[i] = real_handle + 1;
+
+			for (; i < 0; i--) {
+
+				memset(&arg, 0, sizeof(arg));
+				arg.handle = handles[i];
+				arg.offset = 0;
+				arg.size = 4096;
+				arg.flags = I915_MMAP_WC;
+
+				errno = 0;
+
+				ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+				igt_assert_eq(errno, EINVAL);
+				igt_assert_eq(ret, -1);
+			}
+		}
+
+		igt_subtest("bad-offset") {
+			int ret;
+			struct drm_i915_gem_mmap arg;
+			struct bad_offset {
+				uint64_t size;
+				uint64_t offset;
+			} bad_offsets[] = {
+				{4096, 4096 + 1},
+				{4096, -4096},
+				{ 2 * 4096, -4096},
+				{ 4096, ~0},
+				{}
+			};
+
+			for (int i = 0; i < ARRAY_SIZE(bad_offsets); i++) {
+
+				memset(&arg, 0, sizeof(arg));
+				arg.handle = gem_create(fd, 4096);
+
+				arg.offset = bad_offsets[i].offset;
+				arg.size = bad_offsets[i].size;
+
+				arg.flags = I915_MMAP_WC;
+
+				errno = 0;
+				ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+
+				igt_assert_eq(errno, EINVAL);
+				igt_assert_eq(ret, -1);
+			}
+		}
+
+		igt_subtest("bad-size") {
+			int ret;
+			struct drm_i915_gem_mmap arg;
+			uint64_t bad_size[] = {
+				0,
+				-4096,
+				4096 + 1,
+				2 * 4096,
+				~0,
+			};
+
+			for (int i = 0; i < ARRAY_SIZE(bad_size); i++) {
+
+				memset(&arg, 0, sizeof(arg));
+				arg.handle = gem_create(fd, 4096);
+				arg.offset = 4096;
+				arg.size = bad_size[i];
+				arg.flags = I915_MMAP_WC;
+
+				errno = 0;
+
+				ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+				igt_assert_eq(errno, EINVAL);
+				igt_assert_eq(ret, -1);
+			}
+		}
+	}
+
 	igt_subtest("invalid-flags")
 		test_invalid_flags(fd);
 	igt_subtest("close")
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-03-13 23:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 23:27 [igt-dev] [PATCH i-g-t v2 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Antonio Argenziano
2019-03-13 23:27 ` [igt-dev] [PATCH i-g-t v2 2/3] tests/i915/gem_mmap: Add invalid parameters tests Antonio Argenziano
2019-03-13 23:27 ` Antonio Argenziano [this message]
2019-03-13 23:59 ` [igt-dev] [PATCH i-g-t v2 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Chris Wilson
2019-03-14  0:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] " Patchwork
2019-03-14  7:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-18 14:44 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v2,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test (rev2) Patchwork
2019-03-18 17:06 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test (rev3) Patchwork
2019-03-19  1:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-19 17:28   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190313232721.6212-3-antonio.argenziano@intel.com \
    --to=antonio.argenziano@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox