[igt-dev] [PATCH i-g-t v2 2/3] tests/i915/gem_mmap: Add invalid parameters tests

Antonio Argenziano
2019-03-13T23:27:32Z

Add a couple of tests that supply invalid parameters to the mmap IOCTL.

v2:
- Expand test space. (Chris)

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
---
tests/i915/gem_mmap.c | 78 +++++++++++++++++++++++++++++++++++++++----
1 file changed, 72 insertions(+), 6 deletions(-)

diff --git a/tests/i915/gem_mmap.c b/tests/i915/gem_mmap.c
index 0ed15878..f6229cc5 100644
--- a/tests/i915/gem_mmap.c
+++ b/tests/i915/gem_mmap.c
@@ -35,6 +35,7 @@
#include <errno.h>
#include <sys/stat.h>
#include <sys/ioctl.h>
+//#include <linux/bitops.h>
#include "drm.h"

#define OBJECT_SIZE 16384
@@ -128,12 +129,77 @@ igt_main
fd = drm_open_driver(DRIVER_INTEL);

igt_subtest("bad-object") {
- memset(&arg, 0, sizeof(arg));
- arg.handle = 0x10101010;
- arg.offset = 0;
- arg.size = 4096;
- ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
- igt_assert(ret == -1 && errno == ENOENT);
+ uint32_t real_handle = gem_create(fd, 4096);
+ uint32_t handles[20];
+ int i = 0;
+
+ handles[i++] = 0xdeadbeef;
+ for(int bit = 0; bit < 16; bit++)
+ handles[i++] = real_handle | (1 << (bit + 16));
+ handles[i] = real_handle + 1;
+
+ for (; i < 0; i--) {
+ memset(&arg, 0, sizeof(arg));
+ arg.handle = handles[i];
+ arg.offset = 0;
+ arg.size = 4096;
+
+ igt_debug("Trying MMAP IOCTL with handle %x\n", handles[i]);
+ ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+
+ igt_assert_eq(errno, EINVAL);
+ igt_assert_eq(ret, -1);
+ }
+ }
+
+ igt_subtest("bad-offset") {
+ struct bad_offset {
+ uint64_t size;
+ uint64_t offset;
+ } bad_offsets[] = {
+ {4096, 4096 + 1},
+ {4096, -4096},
+ { 2 * 4096, -4096},
+ { 4096, ~0},
+ {}
+ };
+
+ for (int i = 0; i < ARRAY_SIZE(bad_offsets); i++) {
+ memset(&arg, 0, sizeof(arg));
+ arg.handle = gem_create(fd, 4096);
+ arg.offset = bad_offsets[i].offset;
+ arg.size = bad_offsets[i].size;
+
+ igt_debug("Trying to mmap bad offset; size: %llu, offset: %llu\n",
+ bad_offsets[i].size, bad_offsets[i].offset);
+
+ ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+ igt_assert_eq(errno, EINVAL);
+ igt_assert_eq(ret, -1);
+ }
+ }
+
+ igt_subtest("bad-size") {
+ uint64_t bad_size[] = {
+ 0,
+ -4096,
+ 4096 + 1,
+ 2 * 4096,
+ ~0,
+ };
+
+ for (int i = 0; i < ARRAY_SIZE(bad_size); i++) {
+ memset(&arg, 0, sizeof(arg));
+ arg.handle = gem_create(fd, 4096);
+ arg.offset = 4096;
+ arg.size = bad_size[i];
+
+ igt_debug("Trying to mmap bad size; size: %llu\n", bad_size[i]);
+ ret = ioctl(fd, DRM_IOCTL_I915_GEM_MMAP, &arg);
+
+ igt_assert_eq(errno, EINVAL);
+ igt_assert_eq(ret, -1);
+ }
}

igt_subtest("basic") {
--
2.20.1