public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test
Date: Thu, 14 Mar 2019 13:21:31 -0700	[thread overview]
Message-ID: <20190314202133.19311-1-antonio.argenziano@intel.com> (raw)

Add a test for an invalid handle being passed to the IOCTL.

v2:
	- Expand test space. (Chris)

v3:
	- Add local IOCTL wrapper. (Chris)

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_mmap_gtt.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index f6fbbe19..237308a2 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -821,6 +821,23 @@ run_without_prefault(int fd,
 	igt_enable_prefault();
 }
 
+static int
+err_gem_mmap_gtt(int i915, uint32_t handle, uint64_t size, uint64_t offset)
+{
+	struct drm_i915_gem_mmap arg = {
+				.handle = handle,
+				.size = size,
+				.offset = offset
+	};
+	int err = 0;
+
+	if(ioctl(i915, DRM_IOCTL_I915_GEM_MMAP_GTT, &arg))
+		err = -errno;
+
+	errno = 0;
+	return err;
+}
+
 int fd;
 
 igt_main
@@ -831,6 +848,25 @@ igt_main
 	igt_fixture
 		fd = drm_open_driver(DRIVER_INTEL);
 
+	igt_subtest("bad-object") {
+		int ret;
+
+		uint32_t real_handle = gem_create(fd, 4096);
+		uint32_t handles[20];
+		int i = 0;
+
+		handles[i++] = 0xdeadbeef;
+		for(int bit = 0; bit < 16; bit++)
+			handles[i++] = real_handle | (1 << (bit + 16));
+		handles[i] = real_handle + 1;
+
+		for (; i < 0; i--) {
+			igt_debug("Trying to mmap_gtt invalid handle: %x.\n", handles[i]);
+			ret = err_gem_mmap_gtt(fd, handles[i], 0, 4096);
+			igt_assert_eq(ret, -ENOENT);
+		}
+	}
+
 	igt_subtest("basic")
 		test_access(fd);
 	igt_subtest("basic-short")
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-03-14 20:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 20:21 Antonio Argenziano [this message]
2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/i915/gem_mmap: Add invalid parameters tests Antonio Argenziano
2019-03-14 20:21 ` [igt-dev] [PATCH i-g-t v3 3/3] tests/i915/gem_mmap_wc: Add invalid params tests Antonio Argenziano
2019-03-14 20:54 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/3] tests/i915/gem_mmap_gtt: Add invalid parameters test Patchwork
2019-03-14 22:46 ` [igt-dev] [PATCH i-g-t v3 1/3] " Chris Wilson
2019-03-15  7:54 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/3] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190314202133.19311-1-antonio.argenziano@intel.com \
    --to=antonio.argenziano@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox