From: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 3/3] lib/igt_fb: Align min_stride to 256 bytes for YUV buffers on amdgpu
Date: Fri, 15 Mar 2019 11:04:42 -0400 [thread overview]
Message-ID: <20190315150442.10237-3-nicholas.kazlauskas@amd.com> (raw)
In-Reply-To: <20190315150442.10237-1-nicholas.kazlauskas@amd.com>
The chroma address needs to be 256 byte aligned on amdgpu and the
easiest way to do so is to align the minimum stride for the luma.
v2: added this patch
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
lib/igt_fb.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 6a9a9341..e86b5cbc 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -467,6 +467,12 @@ static uint32_t calc_plane_stride(struct igt_fb *fb, int plane)
stride = roundup_power_of_two(stride);
return stride;
+ } else if (igt_format_is_yuv(fb->drm_format) && is_amdgpu_device(fb->fd)) {
+ /*
+ * Chroma address needs to be aligned to 256 bytes on AMDGPU
+ * so the easiest way is to align the luma stride to 256.
+ */
+ return ALIGN(min_stride, 256);
} else {
unsigned int tile_width, tile_height;
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-15 15:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 15:04 [igt-dev] [PATCH i-g-t v2 1/3] lib/drmtest: Add helpers to check and require amdgpu Nicholas Kazlauskas
2019-03-15 15:04 ` [igt-dev] [PATCH i-g-t v2 2/3] lib/debugfs: Don't do CRC sanity checks on amdgpu Nicholas Kazlauskas
2019-03-27 15:10 ` Wentland, Harry
2019-03-27 17:09 ` Daniel Vetter
2019-03-27 17:17 ` Kazlauskas, Nicholas
2019-03-28 9:11 ` Daniel Vetter
2019-03-15 15:04 ` Nicholas Kazlauskas [this message]
2019-03-27 15:15 ` [igt-dev] [PATCH i-g-t v2 3/3] lib/igt_fb: Align min_stride to 256 bytes for YUV buffers " Wentland, Harry
2019-03-18 10:13 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] lib/drmtest: Add helpers to check and require amdgpu (rev2) Patchwork
2019-03-18 11:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-27 15:09 ` [igt-dev] [PATCH i-g-t v2 1/3] lib/drmtest: Add helpers to check and require amdgpu Wentland, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315150442.10237-3-nicholas.kazlauskas@amd.com \
--to=nicholas.kazlauskas@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox