From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 18 Mar 2019 10:41:28 +0000 From: Liviu Dudau Message-ID: <20190318104128.GH26454@e110455-lin.cambridge.arm.com> References: <20190115174747.3138-1-liviu.dudau@arm.com> <20190115174747.3138-2-liviu.dudau@arm.com> <20190204133134.a6cpke3h6x53eeo3@DESKTOP-E1NTVVP.localdomain> <20190306213005.7hvbnwl7dohr3vuv@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190306213005.7hvbnwl7dohr3vuv@smtp.gmail.com> Subject: Re: [igt-dev] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Rodrigo Siqueira Cc: Boris Brezillon , Petri Latvala , Intel GFX ML , IGT GPU Tools , Daniel Vetter , nd , Brian Starkey List-ID: T24gV2VkLCBNYXIgMDYsIDIwMTkgYXQgMDY6MzA6MDVQTSAtMDMwMCwgUm9kcmlnbyBTaXF1ZWly YSB3cm90ZToKPiBIaSBMaXZpdSwKPiAKPiBJ4oCZbSB1c2luZyB5b3VyIHBhdGNoc2V0IHRvIGd1 aWRlIG15IGltcGxlbWVudGF0aW9uIG9mIHdyaXRlYmFjayBpbiB0aGUKPiBWS01TLCBzbywgZmly c3Qgb2YgYWxsLCB0aGFua3MgOikKPiAKPiBEdXJpbmcgbXkgd29yaywgSSBub3RpY2VkIHRoYXQg eW914oCZcmUgc2V0dGluZyB0aGUgZHJtU2V0Q2xpZW50Q2FwKCkKPiBiZWZvcmUgZHJtTW9kZUdl dFJlc291cmNlcygpIHdoaWNoIG1ha2UgdGhlIHdyaXRlYmFjayBjYXBhYmlsaXR5CgpiZWZvcmU/ IEkgYmVsaWV2ZSB5b3VyIHBhdGNoc2V0IG1vdmVzIGl0IHRvIGJlIGJlZm9yZSwgd2hpY2ggbWFr ZXMKc2Vuc2UsIGFzIHRoZSB3cml0ZWJhY2sgYXBwbGllcyB0byBjb25uZWN0b3JzLCBub3QgcGxh bmVzIChzb3JyeSBmb3IgdGhlCmNvbmZ1c2lvbiwgSSB0aGluayBJIHdyb3RlIHRoZSBjb2RlIHdo ZW4gd2Ugd2VyZSB0b3lpbmcgd2l0aCB0aGUgaWRlYQp0aGF0IHdyaXRlYmFjayB3YXMgZ29pbmcg dG8gYmUgYSBwbGFuZSBwcm9wZXJ0eSkuCgo+IOKAmGludmlzaWJsZeKAmSBmb3IgZHJtTW9kZUdl dFJlc291cmNlcygpLiBJIG1hZGUgdGhlIGZvbGxvd2luZyBjaGFuZ2UsIGFuZAo+IEkgY291bGQg cGFzcyB0aGUgaWd0X2Rpc3BsYXlfcmVxdWlyZSgpOgo+IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0 X2ttcy5jIGIvbGliL2lndF9rbXMuYwo+IGluZGV4IGY0ZmYzYTk2Li5iYjJkOGUwNiAxMDA2NDQK PiAtLS0gYS9saWIvaWd0X2ttcy5jCj4gKysrIGIvbGliL2lndF9rbXMuYwo+IEBAIC0xOTEyLDYg KzE5MTIsMTIgQEAgdm9pZCBpZ3RfZGlzcGxheV9yZXF1aXJlKGlndF9kaXNwbGF5X3QgKmRpc3Bs YXksIGludCBkcm1fZmQpCj4gIAo+ICAgICAgICAgZGlzcGxheS0+ZHJtX2ZkID0gZHJtX2ZkOwo+ ICAKPiArICAgICAgIGRybVNldENsaWVudENhcChkcm1fZmQsIERSTV9DTElFTlRfQ0FQX1VOSVZF UlNBTF9QTEFORVMsIDEpOwo+ICsgICAgICAgaWYgKGRybVNldENsaWVudENhcChkcm1fZmQsIERS TV9DTElFTlRfQ0FQX0FUT01JQywgMSkgPT0gMCkKPiArICAgICAgICAgICAgICAgZGlzcGxheS0+ aXNfYXRvbWljID0gMTsKPiArCj4gKyAgICAgICBkcm1TZXRDbGllbnRDYXAoZHJtX2ZkLCBEUk1f Q0xJRU5UX0NBUF9XUklURUJBQ0tfQ09OTkVDVE9SUywgMSk7Cj4gKwo+ICAgICAgICAgcmVzb3Vy Y2VzID0gZHJtTW9kZUdldFJlc291cmNlcyhkaXNwbGF5LT5kcm1fZmQpOwo+ICAgICAgICAgaWYg KCFyZXNvdXJjZXMpCj4gICAgICAgICAgICAgICAgIGdvdG8gb3V0Owo+IEBAIC0xOTI0LDEyICsx OTMwLDYgQEAgdm9pZCBpZ3RfZGlzcGxheV9yZXF1aXJlKGlndF9kaXNwbGF5X3QgKmRpc3BsYXks IGludCBkcm1fZmQpCj4gICAgICAgICBkaXNwbGF5LT5waXBlcyA9IGNhbGxvYyhzaXplb2YoaWd0 X3BpcGVfdCksIGRpc3BsYXktPm5fcGlwZXMpOwo+ICAgICAgICAgaWd0X2Fzc2VydF9mKGRpc3Bs YXktPnBpcGVzLCAiRmFpbGVkIHRvIGFsbG9jYXRlIG1lbW9yeSBmb3IgJWQgcGlwZXNcbiIsIGRp c3BsYXktPm5fcGlwZXMpOwo+ICAKPiAtICAgICAgIGRybVNldENsaWVudENhcChkcm1fZmQsIERS TV9DTElFTlRfQ0FQX1VOSVZFUlNBTF9QTEFORVMsIDEpOwo+IC0gICAgICAgaWYgKGRybVNldENs aWVudENhcChkcm1fZmQsIERSTV9DTElFTlRfQ0FQX0FUT01JQywgMSkgPT0gMCkKPiAtICAgICAg ICAgICAgICAgZGlzcGxheS0+aXNfYXRvbWljID0gMTsKPiAtCj4gLSAgICAgICBkcm1TZXRDbGll bnRDYXAoZHJtX2ZkLCBEUk1fQ0xJRU5UX0NBUF9XUklURUJBQ0tfQ09OTkVDVE9SUywgMSk7Cj4g LQo+ICAgICAgICAgcGxhbmVfcmVzb3VyY2VzID0gZHJtTW9kZUdldFBsYW5lUmVzb3VyY2VzKGRp c3BsYXktPmRybV9mZCk7Cj4gICAgICAgICBpZ3RfYXNzZXJ0KHBsYW5lX3Jlc291cmNlcyk7Cj4g Cj4gSSdtIG5vdCAxMDAlIGNvbmZpZGVudCBhYm91dCB0aGlzIGlzc3VlLCBiZWNhdXNlIG9mIHRo aXMgSSB3aWxsIHNlbmQgYW4KPiBSRkMgYW5kIHNlZSBpZiBJIGNhbiBnZXQgbW9yZSBkZXRhaWxz IGFib3V0IHRoaXMgaXNzdWUuCgpJdCBhY3R1YWxseSBsb29rcyBjb3JyZWN0IHRvIG1lLCBzbyAK CkFja2VkLWJ5OiBMaXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVAYXJtLmNvbT4KCj4gCj4gQWRkaXRp b25hbGx5LCBpZiB5b3UgbmVlZCBhbnkgaGVscCB3aXRoIHRoaXMgcGF0Y2hzZXQgSSB3aWxsIGJl IGdsYWQgdG8KPiBoZWxwIHNpbmNlIEnigJltIHVzaW5nIGl0IFxvLwoKV2VsbCwgSSBuZWVkIHRv IHNlbmQgYW4gdXBkYXRlZCB2ZXJzaW9uIGFuZCBpZiB5b3UgY291bGQgcmV2aWV3IHRoYXQKdGhl biBJIGNhbiBtZXJnZSBpdCBpbnRvIGlndC4KCkJlc3QgcmVnYXJkcywKTGl2aXUKCj4gCj4gQmVz dCBSZWdhcmRzCj4gUm9kcmlnbyBTaXF1ZWlyYQo+IAo+IE9uIDAyLzA0LCBCcmlhbiBTdGFya2V5 IHdyb3RlOgo+ID4gSGkgTGl2aXUsCj4gPiAKPiA+IE9uIFR1ZSwgSmFuIDE1LCAyMDE5IGF0IDA1 OjQ3OjQyUE0gKzAwMDAsIExpdml1IER1ZGF1IHdyb3RlOgo+ID4gPiBGcm9tOiBCcmlhbiBTdGFy a2V5IDxicmlhbi5zdGFya2V5QGFybS5jb20+Cj4gPiAKPiA+IFtzbmlwXQo+ID4gCj4gPiA+ICAK PiA+ID4gKy8qKgo+ID4gPiArICogaWd0X291dHB1dF9zZXRfd3JpdGViYWNrX2ZiOgo+ID4gPiAr ICogQG91dHB1dDogVGFyZ2V0IG91dHB1dAo+ID4gPiArICogQGZiOiBUYXJnZXQgZnJhbWVidWZm ZXIKPiA+ID4gKyAqCj4gPiA+ICsgKiBUaGlzIGZ1bmN0aW9uIHNldHMgdGhlIGdpdmVuIEBmYiB0 byBiZSB1c2VkIGFzIHRoZSB0YXJnZXQgZnJhbWVidWZmZXIgZm9yIHRoZQo+ID4gPiArICogd3Jp dGViYWNrIGVuZ2luZSBhdCB0aGUgbmV4dCBhdG9taWMgY29tbWl0LiBJdCB3aWxsIGFsc28gcmVx dWVzdCBhIHdyaXRlYmFjawo+ID4gPiArICogb3V0IGZlbmNlIHRoYXQgd2lsbCBjb250YWluIHRo ZSBmZCBudW1iZXIgb2YgdGhlIG91dCBmZW5jZSBjcmVhdGVkIGJ5IEtNUyBpZgo+ID4gPiArICog dGhlIGdpdmVuIEBmYiBpcyB2YWxpZC4KPiA+ID4gKyAqLwo+ID4gPiArdm9pZCBpZ3Rfb3V0cHV0 X3NldF93cml0ZWJhY2tfZmIoaWd0X291dHB1dF90ICpvdXRwdXQsIHN0cnVjdCBpZ3RfZmIgKmZi KQo+ID4gPiArewo+ID4gPiArCWlndF9kaXNwbGF5X3QgKmRpc3BsYXkgPSBvdXRwdXQtPmRpc3Bs YXk7Cj4gPiA+ICsKPiA+ID4gKwlMT0coZGlzcGxheSwgIiVzOiBvdXRwdXRfc2V0X3dyaXRlYmFj a19mYiglZClcbiIsIG91dHB1dC0+bmFtZSwgZmIgPyBmYi0+ZmJfaWQgOiAwKTsKPiA+ID4gKwo+ ID4gPiArCWlndF9vdXRwdXRfc2V0X3Byb3BfdmFsdWUob3V0cHV0LCBJR1RfQ09OTkVDVE9SX1dS SVRFQkFDS19GQl9JRCwgZmIgPyBmYi0+ZmJfaWQgOiAwKTsKPiA+ID4gKwkvKiBvbmx5IHJlcXVl c3QgYSB3cml0ZWJhY2sgb3V0IGZlbmNlIGlmIHRoZSBmcmFtZWJ1ZmZlciBpcyB2YWxpZCAqLwo+ ID4gPiArCWlmIChmYikKPiA+ID4gKwkJaWd0X291dHB1dF9zZXRfcHJvcF92YWx1ZShvdXRwdXQs IElHVF9DT05ORUNUT1JfV1JJVEVCQUNLX09VVF9GRU5DRV9QVFIsCj4gPiA+ICsJCQkJCSAgKHB0 cmRpZmZfdCkmb3V0cHV0LT53cml0ZWJhY2tfb3V0X2ZlbmNlX2ZkKTsKPiA+IAo+ID4gSSdtIHN0 aWxsIG5vdCBzdXJlIChwdHJkaWZmX3QpIGlzIHRoZSByaWdodCB0eXBlIGhlcmUsICh1aW50cHRy X3QpCj4gPiBzZWVtcyBiZXR0ZXIuCj4gPiAKPiA+IFRoYW5rcywKPiA+IC1Ccmlhbgo+ID4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGlndC1kZXYg bWFpbGluZyBsaXN0Cj4gPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cj4gCj4gLS0g Cj4gUm9kcmlnbyBTaXF1ZWlyYQo+IGh0dHBzOi8vc2lxdWVpcmEudGVjaAo+IEdyYWR1YXRlIFN0 dWRlbnQKPiBEZXBhcnRtZW50IG9mIENvbXB1dGVyIFNjaWVuY2UKPiBVbml2ZXJzaXR5IG9mIFPD o28gUGF1bG8KCgoKLS0gCj09PT09PT09PT09PT09PT09PT09CnwgSSB3b3VsZCBsaWtlIHRvIHwK fCBmaXggdGhlIHdvcmxkLCAgfAp8IGJ1dCB0aGV5J3JlIG5vdCB8CnwgZ2l2aW5nIG1lIHRoZSAg IHwKIFwgc291cmNlIGNvZGUhICAvCiAgLS0tLS0tLS0tLS0tLS0tCiAgICDCr1xfKOODhClfL8Kv Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYg bWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==