From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg
Date: Mon, 18 Mar 2019 15:14:19 +0200 [thread overview]
Message-ID: <20190318131419.GP4038@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20190318081322.20657-1-chris@chris-wilson.co.uk>
On Mon, Mar 18, 2019 at 08:13:22AM +0000, Chris Wilson wrote:
> sendmsg/recvmsg return the number of bytes transferred, not just an
> error code.
>
> Fixes: 520b6f7fbb6c ("sw_sync: Wait until the end")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110150
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> tests/sw_sync.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/sw_sync.c b/tests/sw_sync.c
> index 26457ce76..950b8b614 100644
> --- a/tests/sw_sync.c
> +++ b/tests/sw_sync.c
> @@ -197,7 +197,7 @@ static void test_sync_busy_fork_unixsocket(void)
> msg.msg_control = c_buffer;
> msg.msg_controllen = sizeof(c_buffer);
>
> - igt_assert(recvmsg(socket, &msg, 0) == 0);
> + igt_assert(recvmsg(socket, &msg, 0) > 0);
>
> cmsg = CMSG_FIRSTHDR(&msg);
> data = CMSG_DATA(cmsg);
> @@ -233,7 +233,7 @@ static void test_sync_busy_fork_unixsocket(void)
> igt_assert_f(sync_fence_wait(fence, 0) == -ETIME,
> "Fence signaled (it should not have been signalled yet)\n");
>
> - igt_assert(sendmsg(socket, &msg, 0) == 0);
> + igt_assert(sendmsg(socket, &msg, 0) > 0);
>
> igt_assert_f(sync_fence_wait(fence, 2*1000) == 0,
> "Fence not signaled (timeline value 1 fence seqno 1)\n");
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-18 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 8:13 [igt-dev] [PATCH i-g-t] tests/sw_sync: Accept bytes transferred between sendmsg/recvmsg Chris Wilson
2019-03-18 12:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-18 13:14 ` Petri Latvala [this message]
2019-03-18 15:21 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318131419.GP4038@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox