From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_kms: reset plane alpha and blend in igt_plane_reset()
Date: Mon, 18 Mar 2019 16:32:30 +0200 [thread overview]
Message-ID: <20190318143230.GN3888@intel.com> (raw)
In-Reply-To: <1552907710-4345-2-git-send-email-juhapekka.heikkila@gmail.com>
On Mon, Mar 18, 2019 at 01:15:10PM +0200, Juha-Pekka Heikkila wrote:
> plane alpha and blend would affect other tests if left
> in unexpected states
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> lib/igt_kms.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index e1eacc1..cdb5aba 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1781,6 +1781,13 @@ static void igt_plane_reset(igt_plane_t *plane)
> if (igt_plane_has_prop(plane, IGT_PLANE_ROTATION))
> igt_plane_set_prop_value(plane, IGT_PLANE_ROTATION, IGT_ROTATION_0);
>
> + if (igt_plane_has_prop(plane, IGT_PLANE_PIXEL_BLEND_MODE))
> + igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
"Pre-multiplied" is the default value for this prop.
> +
> + if (igt_plane_has_prop(plane, IGT_PLANE_ALPHA))
> + igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0xffff);
> +
> +
> igt_plane_clear_prop_changed(plane, IGT_PLANE_IN_FENCE_FD);
> plane->values[IGT_PLANE_IN_FENCE_FD] = ~0ULL;
> plane->gem_handle = 0;
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-18 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 11:15 [igt-dev] [PATCH i-g-t 1/2] tests/kms_available_modes_crc limit tested fb formats Juha-Pekka Heikkila
2019-03-18 11:15 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_kms: reset plane alpha and blend in igt_plane_reset() Juha-Pekka Heikkila
2019-03-18 14:32 ` Ville Syrjälä [this message]
2019-03-18 21:21 ` Juha-Pekka Heikkilä
2019-03-18 21:42 ` Dhinakaran Pandiyan
2019-03-19 14:25 ` Ville Syrjälä
2019-03-18 13:04 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_available_modes_crc limit tested fb formats Patchwork
2019-03-18 17:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-03-19 10:57 [igt-dev] [PATCH i-g-t 1/2] " Juha-Pekka Heikkila
2019-03-19 10:57 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_kms: reset plane alpha and blend in igt_plane_reset() Juha-Pekka Heikkila
2019-03-19 11:22 ` Ville Syrjälä
2019-03-15 15:42 [igt-dev] [PATCH i-g-t 1/2] tests/kms_available_modes_crc limit tested fb formats Juha-Pekka Heikkila
2019-03-15 15:42 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_kms: reset plane alpha and blend in igt_plane_reset() Juha-Pekka Heikkila
2019-03-18 7:32 ` Pandiyan, Dhinakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318143230.GN3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox