From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70A568926F for ; Wed, 20 Mar 2019 10:19:19 +0000 (UTC) Date: Wed, 20 Mar 2019 12:19:15 +0200 From: Petri Latvala Message-ID: <20190320101915.GQ4038@platvala-desk.ger.corp.intel.com> References: <16366e407a6f744610a14d208b7ba26c64f7411c.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <16366e407a6f744610a14d208b7ba26c64f7411c.camel@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] runner/executor: refactor error handling List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Ser, Simon" Cc: "igt-dev@lists.freedesktop.org" List-ID: T24gV2VkLCBNYXIgMjAsIDIwMTkgYXQgMDk6MzM6NTVBTSArMDAwMCwgU2VyLCBTaW1vbiB3cm90 ZToKPiAqIFJlZmFjdG9yIHRvIHVzZSBnb3RvIGVycm9yIGhhbmRsaW5nCj4gKiBNYWtlIGV4ZWN1 dGVfdGVzdF9wcm9jZXNzIG5vcmV0dXJuIHRvIHJlbW92ZSB1bmluaXRpYWxpemVkIHZhcmlhYmxl Cj4gICB3YXJuaW5nCj4gKiBDaGVjayBmb3JrKCkgcmV0dXJuIHZhbHVlCj4gCj4gU2lnbmVkLW9m Zi1ieTogU2ltb24gU2VyIDxzaW1vbi5zZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBydW5uZXIvZXhl Y3V0b3IuYyB8IDYzICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAzMSBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvcnVubmVyL2V4ZWN1dG9yLmMgYi9ydW5uZXIvZXhlY3V0b3IuYwo+ IGluZGV4IGQ1MzVjMjc2Li42YmY3Y2UxYyAxMDA2NDQKPiAtLS0gYS9ydW5uZXIvZXhlY3V0b3Iu Ywo+ICsrKyBiL3J1bm5lci9leGVjdXRvci5jCj4gQEAgLTc1Myw5ICs3NTMsMTAgQEAgc3RhdGlj IGludCBtb25pdG9yX291dHB1dChwaWRfdCBjaGlsZCwKPiAgCXJldHVybiBraWxsZWQ7Cj4gIH0K PiAgCj4gLXN0YXRpYyB2b2lkIGV4ZWN1dGVfdGVzdF9wcm9jZXNzKGludCBvdXRmZCwgaW50IGVy cmZkLAo+IC0JCQkJIHN0cnVjdCBzZXR0aW5ncyAqc2V0dGluZ3MsCj4gLQkJCQkgc3RydWN0IGpv Yl9saXN0X2VudHJ5ICplbnRyeSkKPiArc3RhdGljIHZvaWQgX19hdHRyaWJ1dGVfXygobm9yZXR1 cm4pKQo+ICtleGVjdXRlX3Rlc3RfcHJvY2VzcyhpbnQgb3V0ZmQsIGludCBlcnJmZCwKPiArCQkg ICAgIHN0cnVjdCBzZXR0aW5ncyAqc2V0dGluZ3MsCj4gKwkJICAgICBzdHJ1Y3Qgam9iX2xpc3Rf ZW50cnkgKmVudHJ5KQo+ICB7Cj4gIAljaGFyICphcmd2WzRdID0ge307Cj4gIAlzaXplX3Qgcm9v dGxlbjsKPiBAQCAtODg0LDkgKzg4NSw5IEBAIHN0YXRpYyBpbnQgZXhlY3V0ZV9uZXh0X2VudHJ5 KHN0cnVjdCBleGVjdXRlX3N0YXRlCj4gKnN0YXRlLAo+ICAJfQo+ICAKPiAgCWlmICghb3Blbl9v dXRwdXRfZmlsZXMoZGlyZmQsIG91dHB1dHMsIHRydWUpKSB7Cj4gLQkJY2xvc2UoZGlyZmQpOwo+ ICAJCWZwcmludGYoc3RkZXJyLCAiRXJyb3Igb3BlbmluZyBvdXRwdXQgZmlsZXNcbiIpOwo+IC0J CXJldHVybiAtMTsKPiArCQlyZXN1bHQgPSAtMTsKPiArCQlnb3RvIG91dF9kaXJmZDsKPiAgCX0K PiAgCj4gIAlpZiAoc2V0dGluZ3MtPnN5bmMpIHsKPiBAQCAtODk1LDE0ICs4OTYsOSBAQCBzdGF0 aWMgaW50IGV4ZWN1dGVfbmV4dF9lbnRyeShzdHJ1Y3QgZXhlY3V0ZV9zdGF0ZQo+ICpzdGF0ZSwK PiAgCX0KPiAgCj4gIAlpZiAocGlwZShvdXRwaXBlKSB8fCBwaXBlKGVycnBpcGUpKSB7Cj4gLQkJ Y2xvc2Vfb3V0cHV0cyhvdXRwdXRzKTsKPiAtCQljbG9zZShkaXJmZCk7Cj4gLQkJY2xvc2Uob3V0 cGlwZVswXSk7Cj4gLQkJY2xvc2Uob3V0cGlwZVsxXSk7Cj4gLQkJY2xvc2UoZXJycGlwZVswXSk7 Cj4gLQkJY2xvc2UoZXJycGlwZVsxXSk7Cj4gIAkJZnByaW50ZihzdGRlcnIsICJFcnJvciBjcmVh dGluZyBwaXBlczogJXNcbiIsCj4gc3RyZXJyb3IoZXJybm8pKTsKPiAtCQlyZXR1cm4gLTE7Cj4g KwkJcmVzdWx0ID0gLTE7Cj4gKwkJZ290byBvdXRfcGlwZTsKPiAgCX0KPiAgCj4gIAlpZiAoKGtt c2dmZCA9IG9wZW4oIi9kZXYva21zZyIsIE9fUkRPTkxZIHwgT19DTE9FWEVDKSkgPCAwKSB7Cj4g QEAgLTkyMywxNCArOTE5LDggQEAgc3RhdGljIGludCBleGVjdXRlX25leHRfZW50cnkoc3RydWN0 IGV4ZWN1dGVfc3RhdGUKPiAqc3RhdGUsCj4gIAlpZiAoc2lnZmQgPCAwKSB7Cj4gIAkJLyogVE9E TzogSGFuZGxlIGJldHRlciAqLwo+ICAJCWZwcmludGYoc3RkZXJyLCAiQ2Fubm90IG1vbml0b3Ig Y2hpbGQgcHJvY2VzcyB3aXRoCj4gc2lnbmFsZmRcbiIpOwo+IC0JCWNsb3NlKG91dHBpcGVbMF0p Owo+IC0JCWNsb3NlKGVycnBpcGVbMF0pOwo+IC0JCWNsb3NlKG91dHBpcGVbMV0pOwo+IC0JCWNs b3NlKGVycnBpcGVbMV0pOwo+IC0JCWNsb3NlKGttc2dmZCk7Cj4gLQkJY2xvc2Vfb3V0cHV0cyhv dXRwdXRzKTsKPiAtCQljbG9zZShkaXJmZCk7Cj4gLQkJcmV0dXJuIC0xOwo+ICsJCXJlc3VsdCA9 IC0xOwo+ICsJCWdvdG8gb3V0X2ttc2dmZDsKPiAgCX0KPiAgCj4gIAlpZiAoc2V0dGluZ3MtPmxv Z19sZXZlbCA+PSBMT0dfTEVWRUxfTk9STUFMKSB7Cj4gQEAgLTk1MSwxOSArOTQxLDE1IEBAIHN0 YXRpYyBpbnQgZXhlY3V0ZV9uZXh0X2VudHJ5KHN0cnVjdAo+IGV4ZWN1dGVfc3RhdGUgKnN0YXRl LAo+ICAJICogRmx1c2ggb3V0cHV0cyBiZWZvcmUgZm9ya2luZyBzbyBvdXIgKGJ1ZmZlcmVkKSBv dXRwdXQgd29uJ3QKPiAgCSAqIGVuZCB1cCBpbiB0aGUgdGVzdCBvdXRwdXRzLgo+ICAJICovCj4g LQo+ICAJZmZsdXNoKHN0ZG91dCk7Cj4gIAlmZmx1c2goc3RkZXJyKTsKPiAgCj4gLQlpZiAoKGNo aWxkID0gZm9yaygpKSkgewo+IC0JCWludCBvdXRmZCA9IG91dHBpcGVbMF07Cj4gLQkJaW50IGVy cmZkID0gZXJycGlwZVswXTsKPiAtCQljbG9zZShvdXRwaXBlWzFdKTsKPiAtCQljbG9zZShlcnJw aXBlWzFdKTsKPiAtCj4gLQkJcmVzdWx0ID0gbW9uaXRvcl9vdXRwdXQoY2hpbGQsIG91dGZkLCBl cnJmZCwga21zZ2ZkLAo+IHNpZ2ZkLAo+IC0JCQkJCW91dHB1dHMsIHRpbWVfc3BlbnQsIHNldHRp bmdzKTsKPiAtCX0gZWxzZSB7Cj4gKwljaGlsZCA9IGZvcmsoKTsKPiArCWlmIChjaGlsZCA8IDAp IHsKPiArCQlmcHJpbnRmKHN0ZGVyciwgIkZhaWxlZCB0byBmb3JrKCkiKTsKPiArCQlyZXN1bHQg PSAtMTsKPiArCQlnb3RvIG91dF9rbXNnZmQ7Cj4gKwl9IGVsc2UgaWYgKGNoaWxkID09IDApIHsK PiAgCQlpbnQgb3V0ZmQgPSBvdXRwaXBlWzFdOwo+ICAJCWludCBlcnJmZCA9IGVycnBpcGVbMV07 Cj4gIAkJY2xvc2Uob3V0cGlwZVswXSk7Cj4gQEAgLTk3NCwxMyArOTYwLDI4IEBAIHN0YXRpYyBp bnQgZXhlY3V0ZV9uZXh0X2VudHJ5KHN0cnVjdAo+IGV4ZWN1dGVfc3RhdGUgKnN0YXRlLAo+ICAJ CXNldGVudigiSUdUX1NFTlRJTkVMX09OX1NUREVSUiIsICIxIiwgMSk7Cj4gIAo+ICAJCWV4ZWN1 dGVfdGVzdF9wcm9jZXNzKG91dGZkLCBlcnJmZCwgc2V0dGluZ3MsIGVudHJ5KTsKPiArCQkvKiB1 bnJlYWNoYWJsZSAqLwo+ICAJfQo+ICAKPiAtCS8qIFRPRE86IFJlZmFjdG9yIHRoaXMgd2hvbGUg ZnVuY3Rpb24gdG8gdXNlIG9uaW9uIHRlYXJkb3duICovCj4gKwlpbnQgb3V0ZmQgPSBvdXRwaXBl WzBdOwo+ICsJaW50IGVycmZkID0gZXJycGlwZVswXTsKClRyeSB0byBrZWVwIHZhcmlhYmxlIGRl Y2xhcmF0aW9ucyBhdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBibG9jay4KCgpPdGhlcndpc2UgTEdU TSwKClJldmlld2VkLWJ5OiBQZXRyaSBMYXR2YWxhIDxwZXRyaS5sYXR2YWxhQGludGVsLmNvbT4K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2