From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AA5E89C27 for ; Wed, 20 Mar 2019 11:13:20 +0000 (UTC) Date: Wed, 20 Mar 2019 13:13:16 +0200 From: Andi Shyti Message-ID: <20190320111316.GB1276@intel.intel> References: <20190319234441.1449-1-andi.shyti@intel.com> <20190319234441.1449-7-andi.shyti@intel.com> <155307576136.8718.13835996725226599017@skylake-alporthouse-com> <20190320104913.GA1276@intel.intel> <155307954524.8718.11135284483961823682@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <155307954524.8718.11135284483961823682@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH v13 6/9] lib/i915: add gem_engine_topology library List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: IGT dev , Andi Shyti List-ID: T24gV2VkLCBNYXIgMjAsIDIwMTkgYXQgMTA6NTk6MDVBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgQW5kaSBTaHl0aSAoMjAxOS0wMy0yMCAxMDo0OToxMykKPiA+ID4gPiAr ICAgICAgIHVpbnQ4X3QgYnVmZltTSVpFT0ZfQ1RYX1BBUkFNXSA9IHsgfTsKPiA+ID4gPiArICAg ICAgIHN0cnVjdCBpOTE1X2NvbnRleHRfcGFyYW1fZW5naW5lcyAqY2VuZ2luZSA9Cj4gPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RydWN0IGk5MTVfY29udGV4dF9wYXJh bV9lbmdpbmVzICopIGJ1ZmY7Cj4gPiA+IAo+ID4gPiBPaSwgbm9ldC4gQW5kIGp1c3QgYSBzaW5n bGUgdGFiIGluZGVudC4KPiA+IAo+ID4gWWVzLCBJIG1lc3NlZCB1cCBhIGZldyB0aGluZ3MgaW4g dGhpcyB2ZXJzaW9uIGFuZCBhcyBJIHdhcyB3cml0aW5nCj4gPiB0byBUdnJ0a28sIGFsc28gdGhl IGtlcm5lbCBJIHdhcyBydW5uaW5nIGhhZCBzb21lIHN0dWZmIHRoYXQgd2VyZQo+ID4gc2NyZXdp bmcgdXAgdGhlIGlvY3RscyB2YWx1ZXMuCj4gPiAKPiA+ID4gPiArICAgICAgIHN0cnVjdCBkcm1f aTkxNV9nZW1fY29udGV4dF9wYXJhbSBjcGFyYW0gPSB7Cj4gPiA+ID4gKyAgICAgICAgICAgICAg IC5wYXJhbSA9IEk5MTVfQ09OVEVYVF9QQVJBTV9FTkdJTkVTLAo+ID4gPiA+ICsgICAgICAgICAg ICAgICAuY3R4X2lkID0gY3R4X2lkLAo+ID4gPiA+ICsgICAgICAgICAgICAgICAuc2l6ZSA9IFNJ WkVPRl9DVFhfUEFSQU0sCj4gPiA+ID4gKyAgICAgICAgICAgICAgIC52YWx1ZSA9IHRvX3VzZXJf cG9pbnRlcihjZW5naW5lKSwKPiA+ID4gPiArICAgICAgIH07Cj4gPiA+ID4gKyAgICAgICBpbnQg cmV0LCBpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgIGNwYXJhbS52YWx1ZSA9IHRvX3VzZXJf cG9pbnRlcihjZW5naW5lKTsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAgICByZXQgPSBfX2dlbV9j b250ZXh0X2dldF9wYXJhbShmZCwgJmNwYXJhbSk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAg aWYgKHJldCkgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAvKiBpZiBrZXJuZWwgZG9lcyBub3Qg c3VwcG9ydCBlbmdpbmUvY29udGV4dCBtYXBwaW5nICovCj4gPiA+ID4gKyAgICAgICAgICAgICAg IGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZTI7Cj4gPiA+IAo+ID4gPiBI bW0sIGhvdyBkb2VzIHRoaXMgZGlzdGluZ3Vpc2ggYWdhaW5zdCB0b28gbWFueSBlbmdpbmVzICht b3JlIHRoYW4gY2FuCj4gPiA+IGZpdCBpbnRvIGJ1Zj8pLiBCb3RoIHJldHVybiAtRUlOVkFMIGlp cmM/Cj4gPiAKPiA+IEkgaGF2ZW4ndCBmb3VuZCBpbiB0aGUgZHJpdmVyIHdoZXJlIHdlIHJldHVy biAtRUlOVkFMIGZvciBoYXZpbmcKPiA+IHRvbyBtYW55IGVuZ2luZXMuIEhhdmUgSSBtaXNzZWQg aXQgc29tZXdoZXJlPwo+IAo+IElmIHdlIGNhbm5vdCBmaXQgdGhlIGN0eC0+ZW5naW5lc1tdIGlu dG8gdGhlIGNwYXJhbS5zaXplIHdlIGFsc28gcmVwb3J0Cj4gLUVJTlZBTC4gSSdtIHdvbmRlcmlu ZyBpZiB3ZSBzaG91bGQgZXN0YWJsaXNoIGEgZGlmZmVyZW50IGVycm5vCj4gY29udmVudGlvbiBm b3IgdGhhdC4KPiAKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBkdXBfZW5naW5lKCZl bmdpbmVfZGF0YS5lbmdpbmVzW2ldLCBOVUxMLAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY2VuZ2luZS0+Y2xhc3NfaW5zdGFuY2VbaV0uZW5naW5lX2NsYXNzLAo+ ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2VuZ2luZS0+Y2xhc3Nf aW5zdGFuY2VbaV0uZW5naW5lX2luc3RhbmNlLAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgaSArIDEpOwo+ID4gPiAKPiA+ID4gVGhpcyBzZWVtcyB2ZXJ5IHN1c3Bl Y3QuIElmIGNsYXNzL2luc3RhbmNlIGRvZXNuJ3QgbWFwIHRvIGEga25vd24KPiA+ID4gZW5naW5l LCBkdXBfZW5naW5lKCkgc2hvdWxkIGJlIGZpZ3VyaW5nIGl0IG91dCwgYXMgdGhlIGVuZ2luZVtd IGlzCj4gPiA+IGVudGlyZWx5IGF0IHRoZSBhcmJpdHJhcnkgd2hpbSBvZiB0aGUgdXNlci4KPiA+ IAo+ID4gaXQgZG9lcywgcmlnaHQ/IHdlIGtub3cgdGhlIGxpc3Qgb2YgZW5naW5lcyBhbmQgd2Ug YXNzaWduCj4gPiAidW5rPGNsYXNzPjo8aW5zdGFuY2U+IiBpZiB0aGUgZW5naW5lIGlzIG5vdCBy ZWNvZ25pc2VkLgo+ID4gCj4gPiBBbSBJIG1pc3Npbmcgc29tZXRoaW5nPwo+IAo+IEkgd2FudCB0 byBoYW5kbGUgdmlydHVhbCBlbmdpbmVzIHNvbWVob3cgOikKPiAKPiA+IEluIGFueSBjYXNlLCBJ J20gc3RpbGwgZ29pbmcgdG8gY2hhbmdlIGl0IGFuZCBjb21wYXJlIGFsbCBjbGFzcwo+ID4gaW5z dGFuY2VzIGFnYWluc3QgdGhlIGludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMiBhcnJheS4KPiA+IAo+ ID4gT3IgZG8geW91IG1lYW4gdGhhdCB3ZSBzaG91bGRuJ3QgaGF2ZSB0aGUgZW5naW5lIGF0IGFs bCBpbiB0aGUKPiA+IGxpc3QgSSBhbSBjcmVhdGluZy4uLiBhdCB0aGUgZW5kIHRoYXQncyB3aGF0 IGNvbWVzIGZyb20gdGhlCj4gPiBkcml2ZXIuCj4gCj4gSGVyZSBJIHdhcyBqdXN0IHNheWluZyAn KzEnIGlzIG9ic29sZXRlLgo+IAo+ID4gPiA+ICtzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEgewo+ ID4gPiA+ICsgICAgICAgaW50IGZkOwo+ID4gPiA+ICsgICAgICAgdWludDMyX3QgY3R4Owo+ID4g PiA+ICsKPiA+ID4gPiArICAgICAgIHVpbnQzMl90IG5lbmdpbmVzOwo+ID4gPiA+ICsgICAgICAg dWludDMyX3QgbjsKPiA+ID4gPiArICAgICAgIHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5l MiBlbmdpbmVzW0k5MTVfRVhFQ19SSU5HX01BU0sgKyAxXTsKPiA+ID4gPiArfTsKPiA+ID4gCj4g PiA+IFRoaXMgaXMgdGhlIF9pdGVyLiBQdWxsIHRoZSBmb3JfZWFjaF9mb28oKSBpbnRvIHRoaXMg cGF0Y2ggc28gd2UgY2FuIHNlZQo+ID4gPiBob3cgaXQgaXMgcHV0IHRvZ2V0aGVyLgo+ID4gPiAK PiA+ID4gQXQgd2hpY2ggcG9pbnQsIGRvIHdlIG5lZWQgdGhlIChmZCxjdHgpIGhlcmUgc2luY2Ug dGhleSBhcmUgcGFyYW1ldGVycyB0bwo+ID4gPiB0aGUgZm9yX2VhY2goKSBhbmQgc28gYXZhaWxh YmxlIGxhdGVyPwo+ID4gCj4gPiB0aGV5IGFyZSB1c2VmdWwgZm9yIG15IGZ1bmN0aW9ucy4uLiB3 ZWxsLi4uIGxpdHRsZSBhZHZhbnRhZ2UsIG5vCj4gPiBuZWVkIGluZGVlZC4KPiA+IAo+ID4gSSBk aWRuJ3Qgc2VlIHRoaXMgYXMgYW4gaXRlciBzdHJ1Y3R1cmUgcmF0aGVyIHRoYW4gYSBkYXRhCj4g PiBzdHJ1Y3R1cmUgKGp1c3QgYW4gJ24nIHRoYXQgaW5jcmVtZW50cyBmb3IgaGVscGluZyB0aGUg Zm9yX2VhY2gpLAo+ID4gdGhhdCB3ZSBjb3VsZCB1c2UgaW4gb3RoZXIgb2NjYXNpb25zIG90aGVy IHRoYW4gbG9vcGluZyB0aG9ydWdoLgo+ID4gCj4gPiA+IE1pc3NpbmcgX2l0ZXJfZmluaS4gUG9s aXNoIHRoZSBmb3JfZWFjaF9mb28oKSBhIGJpdCBtb3JlLgo+ID4gCj4gPiBfaXRlcl9maW5pPyBZ b3UgbWVhbiBhbiBpdGVyX2VuZCB0byBjbGVhbiB1cCB0aGluZ3M/IERvIHdlIG5lZWQKPiA+IGl0 PyBJcyB0aGVyZSBhbnl0aGluZyB0byBjbGVhbiB1cD8KPiAKPiBEaWQgSSBub3Qgc2VlIGFzcHJp bnRmPyBBbnl3YXkgVHZydGtvIHN1Z2dlc3RlZCB0aGF0IHRoZXkgY2FuIGFsbCBiZQo+IHN0YXRp YyBuYW1lcywgc28gbm8sIHRoZXJlIHNob3VsZG4ndCBiZSBtdWNoIHRvIGNsZWFuIHVwLCBidXQg dGhhdCBpcwo+IG9uZSBodWdlIHN0cnVjdCB0byBiZSBwYXNzaW5nIGFyb3VuZCB0aGUgc3RhY2sh ISEKCmluIGFueSBjYXNlLCBJIHRob3VnaHQgYWJvdXQgdGhlIGNsZWFuIHVwLCBidXQgaXQgd291 bGRuJ3QgZml4CmFueXRoaW5nIGFueXdheSwgYmVjYXVzZSBpZiB0aGUgZm9yX2VhY2ggaXMgaW50 ZXJydXB0ZWQsIHdlIHdvdWxkCm5ldmVyIGV2ZXIgY2xlYW4gdXAgYW5kIGxlYWsgYW55dGhpbmcg aW5zaWRlLgoKSSBzb21laG93IGlnbm9yZWQgYXNwcmludGYgYmVjYXVzZSBJIGFsd2F5cyB0aG91 Z2h0IHRoYXQgcG9pbnRpbmcKdG8gc3RhdGljIG5hbWVzIGlzIG5vdCBmdXR1cmUgcHJvb2YgZW5v dWdoIChJIGNvbnNpZGVyZWQgdGhhdCBvbmUKZGF5IHdlIHdpbGwgZ2V0IHJpZCBvZiBpbnRlbF9l eGVjdXRpb25fZW5naW5lczIgYXJyYXksIHdoaWxlCnRoaXMgd2F5IHdlIGFyZSBiaW5kaW5nIHRv IGl0IGV2ZW4gbW9yZS4gSSBkb24ndCBrbm93IHdoYXQgaXMKd29yc2UgOikgKS4KCkEgc29sdXRp b24gaXMgdG8gZXhwYW5kIHRoZSBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIsIGJ5CnJl bW92aW5nIHRoZSAiY29uc3QiIGluIGZyb250IG9mIHRoZSBuYW1lIHNvIHRoYXQgd2UgY2FuIGhh dmUKbW9yZSBmbGV4aWJpbGl0eSBhdCBhc3NpZ25pbmcgbmFtZXMuCgpBbm90aGVyIHNvbHV0aW9u IHdvdWxkIGJlIGhhdmluZyB0aGUgZW5naW5lX2RhdGEgc3RydWN0dXJlIGFzIGEKZ2xvYmFsIHN0 cnVjdHVyZSB0aGF0IGNvbnRhaW5zIGFsbCBpbmZvcm1hdGlvbnMgYW5kIGl0J3MKYWxsb2NhdGVk IG91dHNpZGUgdGhlIGZvcl9lYWNoLiBXZSBjYW4gaGF2ZSBmdW5jdGlvbnMgaW5zaWRlIGl0Cmxp a2UgaW5pdCwgZ2V0X25leHQsIGFuZCBzbyBvbiwgaW5zdGVhZCBvZiB1c2luZyBpdCBqdXN0IGFz IGEKbWVyZSBsZWFraW5nIGl0ZXJhdG9yLgoKPiAtQ2hyaXMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pZ3QtZGV2