Re: [igt-dev] [PATCH i-g-t] meson: add -Wno-missing-braces

Jani Nikula
2019-03-20T09:36:42Z

On Wed, 20 Mar 2019, "Ser, Simon" <simon.ser@intel.com> wrote:
> Enabling -Werror=missing-braces results in this error with Clang:
>
> ../tests/kms_vrr.c:203:20: error: suggest braces around
> initialization of subobject [-Werror,-Wmissing-braces]
> drmVBlank vbl = { 0 };
> ^
> {}
>
> I don't believe there is any value in keeping this, so let's just
> disable it.

I fail to come up with examples right now, but I think there are
legitimate cases for the warning.

Arguably the above initializer should be written as simply {} instead of
having the 0 value for initializing the first member which happens to be
a substruct.

BR,
Jani.

>
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/meson.build b/meson.build
> index 557400a5..bb100b75 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -38,6 +38,7 @@ cc_args = [
> '-Wno-type-limits',
> '-Wno-unused-parameter',
> '-Wno-unused-result',
> + '-Wno-missing-braces',
> '-Werror=address',
> '-Werror=array-bounds',
> @@ -45,7 +46,6 @@ cc_args = [
> '-Werror=init-self',
> '-Werror=int-to-pointer-cast',
> '-Werror=main',
> - '-Werror=missing-braces',
> '-Werror=nonnull',
> '-Werror=pointer-to-int-cast',
> '-Werror=return-type',

--
Jani Nikula, Intel Open Source Graphics Center