From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 20 Mar 2019 14:46:59 +0000 From: Liviu Dudau Message-ID: <20190320144658.GQ26454@e110455-lin.cambridge.arm.com> References: <20190115174747.3138-1-liviu.dudau@arm.com> <20190115174747.3138-2-liviu.dudau@arm.com> <20190204133134.a6cpke3h6x53eeo3@DESKTOP-E1NTVVP.localdomain> <20190306213005.7hvbnwl7dohr3vuv@smtp.gmail.com> <20190318104128.GH26454@e110455-lin.cambridge.arm.com> <20190318220529.jqbvi6amvfe3c7es@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190318220529.jqbvi6amvfe3c7es@smtp.gmail.com> Subject: Re: [igt-dev] [PATCH i-g-t v5 1/6] lib/igt_kms: Add writeback support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Rodrigo Siqueira Cc: Boris Brezillon , Petri Latvala , Intel GFX ML , IGT GPU Tools , Daniel Vetter , nd , Brian Starkey List-ID: T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMDc6MDU6MjlQTSAtMDMwMCwgUm9kcmlnbyBTaXF1ZWly YSB3cm90ZToKPiBPbiAwMy8xOCwgTGl2aXUgRHVkYXUgd3JvdGU6Cj4gPiBPbiBXZWQsIE1hciAw NiwgMjAxOSBhdCAwNjozMDowNVBNIC0wMzAwLCBSb2RyaWdvIFNpcXVlaXJhIHdyb3RlOgo+ID4g PiBIaSBMaXZpdSwKPiA+ID4gCj4gPiA+IEnigJltIHVzaW5nIHlvdXIgcGF0Y2hzZXQgdG8gZ3Vp ZGUgbXkgaW1wbGVtZW50YXRpb24gb2Ygd3JpdGViYWNrIGluIHRoZQo+ID4gPiBWS01TLCBzbywg Zmlyc3Qgb2YgYWxsLCB0aGFua3MgOikKPiA+ID4gCj4gPiA+IER1cmluZyBteSB3b3JrLCBJIG5v dGljZWQgdGhhdCB5b3XigJlyZSBzZXR0aW5nIHRoZSBkcm1TZXRDbGllbnRDYXAoKQo+ID4gPiBi ZWZvcmUgZHJtTW9kZUdldFJlc291cmNlcygpIHdoaWNoIG1ha2UgdGhlIHdyaXRlYmFjayBjYXBh YmlsaXR5Cj4gPiAKPiA+IGJlZm9yZT8gSSBiZWxpZXZlIHlvdXIgcGF0Y2hzZXQgbW92ZXMgaXQg dG8gYmUgYmVmb3JlLCB3aGljaCBtYWtlcwo+ID4gc2Vuc2UsIGFzIHRoZSB3cml0ZWJhY2sgYXBw bGllcyB0byBjb25uZWN0b3JzLCBub3QgcGxhbmVzIChzb3JyeSBmb3IgdGhlCj4gPiBjb25mdXNp b24sIEkgdGhpbmsgSSB3cm90ZSB0aGUgY29kZSB3aGVuIHdlIHdlcmUgdG95aW5nIHdpdGggdGhl IGlkZWEKPiA+IHRoYXQgd3JpdGViYWNrIHdhcyBnb2luZyB0byBiZSBhIHBsYW5lIHByb3BlcnR5 KS4KPiA+IAo+ID4gPiDigJhpbnZpc2libGXigJkgZm9yIGRybU1vZGVHZXRSZXNvdXJjZXMoKS4g SSBtYWRlIHRoZSBmb2xsb3dpbmcgY2hhbmdlLCBhbmQKPiA+ID4gSSBjb3VsZCBwYXNzIHRoZSBp Z3RfZGlzcGxheV9yZXF1aXJlKCk6Cj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9r bXMuYyBiL2xpYi9pZ3Rfa21zLmMKPiA+ID4gaW5kZXggZjRmZjNhOTYuLmJiMmQ4ZTA2IDEwMDY0 NAo+ID4gPiAtLS0gYS9saWIvaWd0X2ttcy5jCj4gPiA+ICsrKyBiL2xpYi9pZ3Rfa21zLmMKPiA+ ID4gQEAgLTE5MTIsNiArMTkxMiwxMiBAQCB2b2lkIGlndF9kaXNwbGF5X3JlcXVpcmUoaWd0X2Rp c3BsYXlfdCAqZGlzcGxheSwgaW50IGRybV9mZCkKPiA+ID4gIAo+ID4gPiAgICAgICAgIGRpc3Bs YXktPmRybV9mZCA9IGRybV9mZDsKPiA+ID4gIAo+ID4gPiArICAgICAgIGRybVNldENsaWVudENh cChkcm1fZmQsIERSTV9DTElFTlRfQ0FQX1VOSVZFUlNBTF9QTEFORVMsIDEpOwo+ID4gPiArICAg ICAgIGlmIChkcm1TZXRDbGllbnRDYXAoZHJtX2ZkLCBEUk1fQ0xJRU5UX0NBUF9BVE9NSUMsIDEp ID09IDApCj4gPiA+ICsgICAgICAgICAgICAgICBkaXNwbGF5LT5pc19hdG9taWMgPSAxOwo+ID4g PiArCj4gPiA+ICsgICAgICAgZHJtU2V0Q2xpZW50Q2FwKGRybV9mZCwgRFJNX0NMSUVOVF9DQVBf V1JJVEVCQUNLX0NPTk5FQ1RPUlMsIDEpOwo+ID4gPiArCj4gPiA+ICAgICAgICAgcmVzb3VyY2Vz ID0gZHJtTW9kZUdldFJlc291cmNlcyhkaXNwbGF5LT5kcm1fZmQpOwo+ID4gPiAgICAgICAgIGlm ICghcmVzb3VyY2VzKQo+ID4gPiAgICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4gPiA+IEBAIC0x OTI0LDEyICsxOTMwLDYgQEAgdm9pZCBpZ3RfZGlzcGxheV9yZXF1aXJlKGlndF9kaXNwbGF5X3Qg KmRpc3BsYXksIGludCBkcm1fZmQpCj4gPiA+ICAgICAgICAgZGlzcGxheS0+cGlwZXMgPSBjYWxs b2Moc2l6ZW9mKGlndF9waXBlX3QpLCBkaXNwbGF5LT5uX3BpcGVzKTsKPiA+ID4gICAgICAgICBp Z3RfYXNzZXJ0X2YoZGlzcGxheS0+cGlwZXMsICJGYWlsZWQgdG8gYWxsb2NhdGUgbWVtb3J5IGZv ciAlZCBwaXBlc1xuIiwgZGlzcGxheS0+bl9waXBlcyk7Cj4gPiA+ICAKPiA+ID4gLSAgICAgICBk cm1TZXRDbGllbnRDYXAoZHJtX2ZkLCBEUk1fQ0xJRU5UX0NBUF9VTklWRVJTQUxfUExBTkVTLCAx KTsKPiA+ID4gLSAgICAgICBpZiAoZHJtU2V0Q2xpZW50Q2FwKGRybV9mZCwgRFJNX0NMSUVOVF9D QVBfQVRPTUlDLCAxKSA9PSAwKQo+ID4gPiAtICAgICAgICAgICAgICAgZGlzcGxheS0+aXNfYXRv bWljID0gMTsKPiA+ID4gLQo+ID4gPiAtICAgICAgIGRybVNldENsaWVudENhcChkcm1fZmQsIERS TV9DTElFTlRfQ0FQX1dSSVRFQkFDS19DT05ORUNUT1JTLCAxKTsKPiA+ID4gLQo+ID4gPiAgICAg ICAgIHBsYW5lX3Jlc291cmNlcyA9IGRybU1vZGVHZXRQbGFuZVJlc291cmNlcyhkaXNwbGF5LT5k cm1fZmQpOwo+ID4gPiAgICAgICAgIGlndF9hc3NlcnQocGxhbmVfcmVzb3VyY2VzKTsKPiA+ID4g Cj4gPiA+IEknbSBub3QgMTAwJSBjb25maWRlbnQgYWJvdXQgdGhpcyBpc3N1ZSwgYmVjYXVzZSBv ZiB0aGlzIEkgd2lsbCBzZW5kIGFuCj4gPiA+IFJGQyBhbmQgc2VlIGlmIEkgY2FuIGdldCBtb3Jl IGRldGFpbHMgYWJvdXQgdGhpcyBpc3N1ZS4KPiA+IAo+ID4gSXQgYWN0dWFsbHkgbG9va3MgY29y cmVjdCB0byBtZSwgc28gCj4gPiAKPiA+IEFja2VkLWJ5OiBMaXZpdSBEdWRhdSA8bGl2aXUuZHVk YXVAYXJtLmNvbT4KPiA+IAo+ID4gPiAKPiA+ID4gQWRkaXRpb25hbGx5LCBpZiB5b3UgbmVlZCBh bnkgaGVscCB3aXRoIHRoaXMgcGF0Y2hzZXQgSSB3aWxsIGJlIGdsYWQgdG8KPiA+ID4gaGVscCBz aW5jZSBJ4oCZbSB1c2luZyBpdCBcby8KPiA+IAo+ID4gV2VsbCwgSSBuZWVkIHRvIHNlbmQgYW4g dXBkYXRlZCB2ZXJzaW9uIGFuZCBpZiB5b3UgY291bGQgcmV2aWV3IHRoYXQKPiA+IHRoZW4gSSBj YW4gbWVyZ2UgaXQgaW50byBpZ3QuCj4gCj4gU3VyZSEgSSB3aWxsIGJlIGdsYWQgdG8gdGFrZSBz b21lIHRpbWUgdG8gcmV2aWV3IHlvdXIgY29kZSA6KQo+IAo+IEkgY2FuIGFsc28gdHJ5IHRvIHRl c3QgaXQgb24gbXkgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBvZiBWS01TLgo+IE9uZSBxdWVzdGlv biwgSSBoYXZlIGEgTmFub1BjLVQxIGRldmljZSBbMV0gd2hpY2ggaGFzIGEgTWFsaSBHUFUsIGNh biBJCj4gdGVzdCB0aGUgd3JpdGViYWNrIGZlYXR1cmUgaW4gdGhpcyBkZXZpY2U/IEFsbCBraW5k IG9mIE1hbGkgR1BVIGhhcwo+IHN1cHBvcnQgZm9yIHRoZSB3cml0ZWJhY2sgZmVhdHVyZT8KPiAK PiAxLiBodHRwOi8vd2lraS5mcmllbmRseWFybS5jb20vd2lraS9pbmRleC5waHAvTmFub1BDLVQx Cgooc29ycnksIGVtYWlsIGZlbGwgdGhyb3VnaCB0aGUgY3JhY2tzKQoKVGhlIHdyaXRlYmFjayBp cyBhIE1hbGkgRGlzcGxheSBQcm9jZXNzb3IgZmVhdHVyZSwgbm90IEdQVS4gQXMgc3VjaCB5b3UK bmVlZCBhIGRldmljZSB0aGF0IGhhcyBNYWxpIERQIGluIGl0LiBDb21tZXJjaWFsbHkgdGhlcmUg d2lsbCBiZSBhCnBsYXRmb3JtIGxhdGVyIHRoaXMgeWVhciwgYnV0IHVudGlsIGl0IGlzIGFubm91 bmNlZCBJIGNhbm5vdCBzYXkgbW9yZQphYm91dCBpdC4KCkJlc3QgcmVnYXJkcywKTGl2aXUKCj4g Cj4gVGhhbmtzIQo+IEJlc3QgUmVnYXJkcwo+ICAKPiA+IEJlc3QgcmVnYXJkcywKPiA+IExpdml1 Cj4gPiAKPiA+ID4gCj4gPiA+IEJlc3QgUmVnYXJkcwo+ID4gPiBSb2RyaWdvIFNpcXVlaXJhCj4g PiA+IAo+ID4gPiBPbiAwMi8wNCwgQnJpYW4gU3RhcmtleSB3cm90ZToKPiA+ID4gPiBIaSBMaXZp dSwKPiA+ID4gPiAKPiA+ID4gPiBPbiBUdWUsIEphbiAxNSwgMjAxOSBhdCAwNTo0Nzo0MlBNICsw MDAwLCBMaXZpdSBEdWRhdSB3cm90ZToKPiA+ID4gPiA+IEZyb206IEJyaWFuIFN0YXJrZXkgPGJy aWFuLnN0YXJrZXlAYXJtLmNvbT4KPiA+ID4gPiAKPiA+ID4gPiBbc25pcF0KPiA+ID4gPiAKPiA+ ID4gPiA+ICAKPiA+ID4gPiA+ICsvKioKPiA+ID4gPiA+ICsgKiBpZ3Rfb3V0cHV0X3NldF93cml0 ZWJhY2tfZmI6Cj4gPiA+ID4gPiArICogQG91dHB1dDogVGFyZ2V0IG91dHB1dAo+ID4gPiA+ID4g KyAqIEBmYjogVGFyZ2V0IGZyYW1lYnVmZmVyCj4gPiA+ID4gPiArICoKPiA+ID4gPiA+ICsgKiBU aGlzIGZ1bmN0aW9uIHNldHMgdGhlIGdpdmVuIEBmYiB0byBiZSB1c2VkIGFzIHRoZSB0YXJnZXQg ZnJhbWVidWZmZXIgZm9yIHRoZQo+ID4gPiA+ID4gKyAqIHdyaXRlYmFjayBlbmdpbmUgYXQgdGhl IG5leHQgYXRvbWljIGNvbW1pdC4gSXQgd2lsbCBhbHNvIHJlcXVlc3QgYSB3cml0ZWJhY2sKPiA+ ID4gPiA+ICsgKiBvdXQgZmVuY2UgdGhhdCB3aWxsIGNvbnRhaW4gdGhlIGZkIG51bWJlciBvZiB0 aGUgb3V0IGZlbmNlIGNyZWF0ZWQgYnkgS01TIGlmCj4gPiA+ID4gPiArICogdGhlIGdpdmVuIEBm YiBpcyB2YWxpZC4KPiA+ID4gPiA+ICsgKi8KPiA+ID4gPiA+ICt2b2lkIGlndF9vdXRwdXRfc2V0 X3dyaXRlYmFja19mYihpZ3Rfb3V0cHV0X3QgKm91dHB1dCwgc3RydWN0IGlndF9mYiAqZmIpCj4g PiA+ID4gPiArewo+ID4gPiA+ID4gKwlpZ3RfZGlzcGxheV90ICpkaXNwbGF5ID0gb3V0cHV0LT5k aXNwbGF5Owo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKwlMT0coZGlzcGxheSwgIiVzOiBvdXRwdXRf c2V0X3dyaXRlYmFja19mYiglZClcbiIsIG91dHB1dC0+bmFtZSwgZmIgPyBmYi0+ZmJfaWQgOiAw KTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsJaWd0X291dHB1dF9zZXRfcHJvcF92YWx1ZShvdXRw dXQsIElHVF9DT05ORUNUT1JfV1JJVEVCQUNLX0ZCX0lELCBmYiA/IGZiLT5mYl9pZCA6IDApOwo+ ID4gPiA+ID4gKwkvKiBvbmx5IHJlcXVlc3QgYSB3cml0ZWJhY2sgb3V0IGZlbmNlIGlmIHRoZSBm cmFtZWJ1ZmZlciBpcyB2YWxpZCAqLwo+ID4gPiA+ID4gKwlpZiAoZmIpCj4gPiA+ID4gPiArCQlp Z3Rfb3V0cHV0X3NldF9wcm9wX3ZhbHVlKG91dHB1dCwgSUdUX0NPTk5FQ1RPUl9XUklURUJBQ0tf T1VUX0ZFTkNFX1BUUiwKPiA+ID4gPiA+ICsJCQkJCSAgKHB0cmRpZmZfdCkmb3V0cHV0LT53cml0 ZWJhY2tfb3V0X2ZlbmNlX2ZkKTsKPiA+ID4gPiAKPiA+ID4gPiBJJ20gc3RpbGwgbm90IHN1cmUg KHB0cmRpZmZfdCkgaXMgdGhlIHJpZ2h0IHR5cGUgaGVyZSwgKHVpbnRwdHJfdCkKPiA+ID4gPiBz ZWVtcyBiZXR0ZXIuCj4gPiA+ID4gCj4gPiA+ID4gVGhhbmtzLAo+ID4gPiA+IC1Ccmlhbgo+ID4g PiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ ID4gaWd0LWRldiBtYWlsaW5nIGxpc3QKPiA+ID4gPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+ID4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaWd0LWRldgo+ID4gPiAKPiA+ID4gLS0gCj4gPiA+IFJvZHJpZ28gU2lxdWVpcmEKPiA+ID4g aHR0cHM6Ly9zaXF1ZWlyYS50ZWNoCj4gPiA+IEdyYWR1YXRlIFN0dWRlbnQKPiA+ID4gRGVwYXJ0 bWVudCBvZiBDb21wdXRlciBTY2llbmNlCj4gPiA+IFVuaXZlcnNpdHkgb2YgU8OjbyBQYXVsbwo+ ID4gCj4gPiAKPiA+IAo+ID4gLS0gCj4gPiA9PT09PT09PT09PT09PT09PT09PQo+ID4gfCBJIHdv dWxkIGxpa2UgdG8gfAo+ID4gfCBmaXggdGhlIHdvcmxkLCAgfAo+ID4gfCBidXQgdGhleSdyZSBu b3QgfAo+ID4gfCBnaXZpbmcgbWUgdGhlICAgfAo+ID4gIFwgc291cmNlIGNvZGUhICAvCj4gPiAg IC0tLS0tLS0tLS0tLS0tLQo+ID4gICAgIMKvXF8o44OEKV8vwq8KPiAKPiAtLSAKPiBSb2RyaWdv IFNpcXVlaXJhCj4gaHR0cHM6Ly9zaXF1ZWlyYS50ZWNoCj4gR3JhZHVhdGUgU3R1ZGVudAo+IERl cGFydG1lbnQgb2YgQ29tcHV0ZXIgU2NpZW5jZQo+IFVuaXZlcnNpdHkgb2YgU8OjbyBQYXVsbwoK CgotLSAKPT09PT09PT09PT09PT09PT09PT0KfCBJIHdvdWxkIGxpa2UgdG8gfAp8IGZpeCB0aGUg d29ybGQsICB8CnwgYnV0IHRoZXkncmUgbm90IHwKfCBnaXZpbmcgbWUgdGhlICAgfAogXCBzb3Vy Y2UgY29kZSEgIC8KICAtLS0tLS0tLS0tLS0tLS0KICAgIMKvXF8o44OEKV8vwq8KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxp c3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2