From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_shrink: Open the device before using it!
Date: Wed, 20 Mar 2019 21:26:29 +0200 [thread overview]
Message-ID: <20190320192629.GW3888@intel.com> (raw)
In-Reply-To: <20190320160151.32659-1-chris@chris-wilson.co.uk>
On Wed, Mar 20, 2019 at 04:01:51PM +0000, Chris Wilson wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110212
> Fixes: 8ae86621d6ff ("lib/igt_device: Move intel_get_pci_device under igt_device")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> ---
> tests/i915/gem_shrink.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c
> index 73b6be725..51d1343ba 100644
> --- a/tests/i915/gem_shrink.c
> +++ b/tests/i915/gem_shrink.c
> @@ -403,7 +403,12 @@ igt_main
> unsigned int engine;
> int fd;
>
> - /* Spawn enough processes to use all memory, but each only
> + fd = drm_open_driver(DRIVER_INTEL);
> + igt_require_gem(fd);
> +
> +
Bonus newline?
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + /*
> + * Spawn enough processes to use all memory, but each only
> * uses half the available mappable aperture ~128MiB.
> * Individually the processes would be ok, but en masse
> * we expect the shrinker to start purging objects,
> @@ -418,9 +423,6 @@ igt_main
> intel_require_memory(num_processes, alloc_size,
> CHECK_SWAP | CHECK_RAM);
>
> - fd = drm_open_driver(DRIVER_INTEL);
> - igt_require_gem(fd);
> -
> nengine = 0;
> for_each_engine(fd, engine)
> engines[nengine++] = engine;
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-20 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 16:01 [igt-dev] [PATCH i-g-t] i915/gem_shrink: Open the device before using it! Chris Wilson
2019-03-20 17:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-20 19:26 ` Ville Syrjälä [this message]
2019-03-20 20:38 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2019-03-20 23:51 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320192629.GW3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox