From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A47F89F27 for ; Thu, 21 Mar 2019 11:23:45 +0000 (UTC) Date: Thu, 21 Mar 2019 13:23:43 +0200 From: Andi Shyti Message-ID: <20190321112343.GA1774@intel.intel> References: <20190321010015.1317-1-andi.shyti@intel.com> <20190321010015.1317-5-andi.shyti@intel.com> <34e42d43-c18b-d832-6971-505146fbec71@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <34e42d43-c18b-d832-6971-505146fbec71@linux.intel.com> Subject: Re: [igt-dev] [PATCH v14 4/5] lib/i915: add gem_engine_topology library and for_each loop definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin Cc: IGT dev , Andi Shyti List-ID: PiA+ICtzdGF0aWMgdm9pZCBpbml0X2VuZ2luZShzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2lu ZTIgKmUyLCBjb25zdCBjaGFyICpuYW1lLAo+ID4gKwkJCXVpbnQxNl90IGNsYXNzLCB1aW50MTZf dCBpbnN0YW5jZSwgdWludDhfdCBmbGFncykKPiAKPiBJJ2QgcHJvYmFibHkgdXNlIHU2NCBmb3Ig ZmxhZ3MgdG8gbWF0Y2ggdGhlIHN0cnVjdHVyZS4KCnllcywgZmxhZ3MgaXQncyB1NjQsIEkgdXNl ZCB1OCBiZWNhdXNlIHRoZSBmbGFncyB3ZSB1c2UgaXMgbmV2ZXIKc3VwcG9zZWQgdG8gYmUgaGln aGVyIHRoYW4gdGhhbiAzZi4gQnV0IHN1cmUsIGNhbiBtYWtlIGl0IHU2NC4KCj4gPiArewo+ID4g KwlzdGF0aWMgY29uc3QgY2hhciAqdW5rX25hbWUgPSAidW5rIjsKPiA+ICsKPiA+ICsJZTItPmNs YXNzICAgID0gY2xhc3M7Cj4gPiArCWUyLT5pbnN0YW5jZSA9IGluc3RhbmNlOwo+ID4gKwllMi0+ ZmxhZ3MgICAgPSBmbGFnczsKPiA+ICsKPiA+ICsJaWYgKG5hbWUpIHsKPiA+ICsJCWUyLT5uYW1l ID0gbmFtZTsKPiAKPiBUaGlzIHBhdGggaXMgdXNlZCBvbmx5IGZvciB0aGUgbGVnYWN5IGZhbGwg YmFjayBtb2RlIHNvIEkgYW0gY29udGVtcGxhdGluZwo+IHdoZXRoZXIgaXMgaXMgZXZlbiB3b3J0 aCBoYXZpbmcgdGhlIG5hbWUgcGFzc2VkIGluLgoKeWVzLCBqdXN0IHdhbnRlZCB0byBiZSBjb25z aXN0ZW50LiBBdCB0aGUgYmlnaW5uaW5nIHRoZQpkdXBfZW5naW5lIGhhZCBhIGJpZ2dlciByb2xl LCBidXQgdGhlbiBJIGRlbW90ZWQgaXQgdG8ganVzdCBkb2luZwp0aGlzLgoKPiBUaGUgaWYgeW91 IGZpbmQgYSB2aXJ0dWFsIGVuZ2luZSBpbiB0aGUgbGlzdCAoCj4gSTkxNV9FTkdJTkVfQ0xBU1Nf SU5WQUxJRC9JOTE1X0VOR0lORV9DTEFTU19JTlZBTElEX1ZJUlRVQUwpIHlvdSBjb3VsZCBzZXQK PiB0aGUgbmFtZSB0byAidmlydHVhbCIgb3Igc29tZXRoaW5nLgoKZG8gd2UgcmVhbGx5IG5lZWQg YSBuYW1lIG9mIHRoZSB0eXBlICJ2aXJ0dWFsLTxlbmdpbmU+Ij8KCj4gTm93IGxpc3RlbiB0byB0 aGlzLi4gaG93IGFib3V0IHdlIGV4cG9ydCB0aGUgZW5naW5lIG5hbWVzIHZpYSB0aGUgcXVlcnkg QVBJPwo+IFByaW1hcmlseSBJIHdhcyB0aGlua2luZyB0byBkaXN0aW5ndWlzaCBkaWZmZXJlbmNl IGluc3RhbmNlIG9mIHZpcnR1YWwsIGJ1dAo+IHRoZW4gaXQgd291bGQgYWxzbyBsZXNzZW4gdGhl IHJlbGlhbmNlIG9uIHRoZSBzdGF0aWMgbWFwLiBUaG91Z2h0cz8KCkRvIHlvdSBtZWFuIHRoYXQg dGhlIG5hbWUgd291bGQgYmUgcHJvdmlkZWQgYnkgdGhlIGRyaXZlcj8KCk90aGVyIHRoYW4gaW1w cm92aW5nIHRoZSBkZWJ1ZyBpbmZvcm1hdGlvbiwgaXMgdGhlIG5hbWUKZm9ybWF0dGluZyBnaXZp bmcgYW55IGFkdmFudGFnZSBpZiB3ZSBjYW4gZGlzdGluZ3Vpc2ggYnkKY2xhc3MvaW5zdGFuY2Uv ZmxhZ3M/CgpXZSBjYW4ndCB1c2UgaXQgYW55d2F5IGZvciB0ZXN0IGNyZWF0aW9uLgoKWy4uLl0K Cj4gPiArCQl1aW50OF90IG5lbmdpbmVzID0gKHBhcmFtLnNpemUgLQo+ID4gKwkJCQlzaXplb2Yo c3RydWN0IGk5MTVfY29udGV4dF9wYXJhbV9lbmdpbmVzKSkgLwo+ID4gKwkJCQlzaXplb2YoZW5n aW5lcy0+Y2xhc3NfaW5zdGFuY2VbMF0pOwo+IAo+IEknZCBwcm9iYWJseSBqdXN0IHVzZSB1bnNp Z25lZCBpbnQuCgpPaC4uLiBJIGhhdmUgc2V0IHUzMiBpbiB0aGUgaW50ZWxfZW5naW5lX2RhdGEs IEkgZGlkbid0IHJlbGlhc2UsCkkgYXNzdW1lIHRoYXQgbmVuZ2luZXMgd291bGQgbmV2ZXIgYmUg aGlnaGVyIHRoYW4gNjQgKGlmIHRoYXQKaGFwcGVucyB3ZSBjYW4ndCBoYW5kbGUgaXQgaGVyZSku CgpCdXQgQ2hyaXMgaXMgY29uc2lkZXJpbmcgdGhlIGNhc2Ugd2Ugd2lsbCBoYXZlIG1vcmUgdGhh IDY0CmVuZ2luZXMsIEkgY2FuIHNldCBpdCB0byB1MzIsIG9mIGNvdXJzZS4KClsuLi5dCgo+ID4g KyNkZWZpbmUgZm9yX2VhY2hfZW5naW5lX2NsYXNzX2luc3RhbmNlKGZkX18sIGN0eF9fLCBlX18p IFwKPiA+ICsJZm9yIChzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEgaV9fID0gaW50ZWxfaW5pdF9l bmdpbmVfbGlzdChmZF9fLCBjdHhfXyk7IFwKPiA+ICsJCSgoZV9fKSA9IChpX18ubiA8IGlfXy5u ZW5naW5lcykgPyAmaV9fLmVuZ2luZXNbaV9fLm5dIDogTlVMTCk7IFwKPiA+ICsJCQlpX18ubisr KQo+IAo+IERvIHdlIHdhbnQgYSBjb250ZXh0IHBhcmFtZXRlciBpbiB0aGlzIGhlbHBlciwgb3Ig ZXZlbiB0aGlzIGhlbHBlciBhdCBhbGw/IEkKPiB0aG91Z2h0IHdlIGNhbiBlbmQgdXAgd2l0aCBv bmx5IHR3bywgZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lIGFuZAo+IGZvcl9lYWNoX2NvbnRleHRf ZW5naW5lIC0gYnV0IEkgZ3Vlc3MgaXQgaXMgb3BlbiBmb3IgZGlzY3Vzc2lvbi4KCkkgZG9uJ3Qg a25vdyBvZiBwb3NzaWJsZSB1c2UgY2FzZXMgdGhhdCBkbyBvciBkb24ndCBuZWVkIGN0eApvdXRz aWRlIHRoZSBmb3JfZWFjaC4uLigpLgoKSWYgeW91IGRvbid0IHNlZSBhbnkgdXNlIG9mIHRoZSBj b250ZXh0IGluZGV4IG91dHNpZGUgdGhlCmZvcl9lYWNoIEkgY2FuIGNyZWF0ZSB0aGUgY29udGV4 dCBpbnNpZGUgdGhlIGluaXRfbGlzdCBmdW5jdGlvbi4KCkJ1dCwgSSBoYXZlIGEgbGl0dGxlIGNv bmNlcm4gYWJvdXQgdGhlIGRlc3RyYWN0aW9uIG9mIHRoYXQKY29udGV4dC4gSWYgdGhlIGZvcl9l YWNoLi4uIGdldHMgaW50ZXJydXB0ZWQgaW4gdGhlIG1pZGRsZSBvZiB0aGUKbG9vcCwgd2UgbG9z ZSB0aGUgY29udGV4dC4KClsuLi5dCgo+ID4gQEAgLTQzNCw3ICs0MzQsNyBAQCBidXN5X2NoZWNr X2FsbChpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKmUs Cj4gPiAgIAlpID0gMDsKPiA+ICAgCWZkWzBdID0gLTE7Cj4gPiAtCWZvcl9lYWNoX2VuZ2luZV9j bGFzc19pbnN0YW5jZShnZW1fZmQsIGVfKSB7Cj4gPiArCWZvcl9lYWNoX2VuZ2luZV9jbGFzc19p bnN0YW5jZShnZW1fZmQsIDAsIGVfKSB7Cj4gPiAgIAkJaWYgKGUgPT0gZV8pCj4gPiAgIAkJCWJ1 c3lfaWR4ID0gaTsKPiA+IEBAIC00OTcsNyArNDk3LDcgQEAgbW9zdF9idXN5X2NoZWNrX2FsbChp bnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKmUsCj4gPiAg IAl1bnNpZ25lZCBpbnQgaWRsZV9pZHgsIGk7Cj4gPiAgIAlpID0gMDsKPiA+IC0JZm9yX2VhY2hf ZW5naW5lX2NsYXNzX2luc3RhbmNlKGdlbV9mZCwgZV8pIHsKPiA+ICsJZm9yX2VhY2hfZW5naW5l X2NsYXNzX2luc3RhbmNlKGdlbV9mZCwgMCwgZV8pIHsKPiA+ICAgCQlpZiAoZSA9PSBlXykKPiA+ ICAgCQkJaWRsZV9pZHggPSBpOwo+ID4gICAJCWVsc2UgaWYgKHNwaW4pCj4gPiBAQCAtNTU0LDcg KzU1NCw3IEBAIGFsbF9idXN5X2NoZWNrX2FsbChpbnQgZ2VtX2ZkLCBjb25zdCB1bnNpZ25lZCBp bnQgbnVtX2VuZ2luZXMsCj4gPiAgIAl1bnNpZ25lZCBpbnQgaTsKPiA+ICAgCWkgPSAwOwo+ID4g LQlmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCBlKSB7Cj4gPiArCWZvcl9l YWNoX2VuZ2luZV9jbGFzc19pbnN0YW5jZShnZW1fZmQsIDAsIGUpIHsKPiA+ICAgCQlpZiAoc3Bp bikKPiA+ICAgCQkJX19zdWJtaXRfc3Bpbl9iYXRjaChnZW1fZmQsIHNwaW4sIGUsIDY0KTsKPiA+ ICAgCQllbHNlCj4gPiBAQCAtMTY4Myw3ICsxNjgzLDcgQEAgaWd0X21haW4KPiA+ICAgCQlpZ3Rf cmVxdWlyZV9nZW0oZmQpOwo+ID4gICAJCWlndF9yZXF1aXJlKGk5MTVfdHlwZV9pZCgpID4gMCk7 Cj4gPiAtCQlmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZmQsIGUpCj4gPiArCQlmb3Jf ZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZmQsIDAsIGUpCj4gPiAgIAkJCW51bV9lbmdpbmVz Kys7Cj4gPiAgIAl9Cj4gPiAKPiAKPiBMb29rcyBsaWtlIHRoaXMgd291bGQgd29yay4gSnVzdCB0 aGUgcXVlc3Rpb24gb2YgdmlydHVhbCBlbmdpbmUsIHNldCBvZgo+IGNob3NlbiBpdGVyYXRvcnMs IGFuZCBtYXliZSBzb21lIG5pdHMuCgpZZXMsIGFzIHdlIGRpc2N1c3NlZCwgcmlnaHQgYWZ0ZXIg dGhpcyBwYXRjaHNldCBJIHdpbGwgZG8gdGhlCmZvcl9lYWNoX3BoeXNpY2FsLgoKV2hhdCBhcmUg dGhlIG5pdHM/IEkgbG92ZSBuaXRzIDopCgpBbmRpCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaWd0LWRldg==