From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D7E36E05A for ; Thu, 21 Mar 2019 11:38:23 +0000 (UTC) Date: Thu, 21 Mar 2019 13:38:21 +0200 From: Andi Shyti Message-ID: <20190321113821.GB1774@intel.intel> References: <20190321010015.1317-1-andi.shyti@intel.com> <20190321010015.1317-5-andi.shyti@intel.com> <155315355875.22764.5134530389425285211@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <155315355875.22764.5134530389425285211@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH v14 4/5] lib/i915: add gem_engine_topology library and for_each loop definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: IGT dev , Andi Shyti List-ID: SGkgQ2hyaXMsCgo+ID4gK3N0YXRpYyB2b2lkIHF1ZXJ5X2VuZ2luZXMoaW50IGZkLAo+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcXVlcnlfZW5naW5lX2luZm8g KnF1ZXJ5X2VuZ2luZXMpCj4gCj4gUGFzcyBpbiB0aGUgbGVuZ3RoIG9mIHRoZSBxdWVyeV9lbmdp bmVzIGJsb2NrIGkuZS4gZG9uJ3QganVzdCBhc3N1bWUKPiBpdGVtLmxlbmd0aC4gQW5kIEknbSBz dGlsbCB3b3JyeWluZyBhYm91dCB3aGF0IGhhcHBlbnMgd2hlbiBpdCBpcwo+IGdyZWF0ZXIgdGhh biA2NCBlbmdpbmVzLgoKT0ssIGxvb2tzIHRoZSBzYW1lIHRvIG1lLCBidXQgc3VyZSwgSSBjYW4g c2V0IGl0ZW0ubGVuZ3RoCm91dHNpZGUgcXVlcnlfZW5naW5lcygpLgoKPiA+ICsgICAgICAgaWYg KF9fZ2VtX2NvbnRleHRfZ2V0X3BhcmFtKGZkLCAmcGFyYW0pKSB7Cj4gPiArICAgICAgICAgICAg ICAgLyogaWYga2VybmVsIGRvZXMgbm90IHN1cHBvcnQgZW5naW5lL2NvbnRleHQgbWFwcGluZyAq Lwo+IAo+IFdlIGFsc28gdGFrZSB0aGlzIHBhdGggaWYgd2UgaGF2ZSBtb3JlIHRoYW4gNjQgZW5n aW5lcy4KCkJ1dCBJIGhhdmVuJ3QgZm91bmQgYW55d2hlcmUgaW4gdGhlIGdldF9wYXJhbSgpIGFu ZAppOTE1X3F1ZXJ5X2lvY3RsKCkgaW4gdGhlIGRyaXZlciB3aGVyZSB0aGlzIGNhc2UgaXMgY29u c2lkZXJlZC4KCkRvbid0IHdlIHJlY2VpdmUgLUVJTlZBTCBvbmx5IHdoZW4gImFyZ3MtPnNpemUg PCBzaXplIj8KClRoZSBzZXRfZW5naW5lcyB3b3VsZCBmYWlsIGlmIHdlIHRyeSB0byBkbyB0aGF0 LiBJIGRvbid0IHNlZSB0aGlzCmEgcGxhdXNpYmxlIHRoaW5nIHRvIGhhcHBlbiAodW5sZXNzLCBv ZiBjb3Vyc2UsIEkgbWlzc2VkIGl0LAp3aGljaCBpcyB2ZXJ5IGxpa2VseSkuCgpJbiBhbnkgY2Fz ZSwgd2UgZG9uJ3QgaGF2ZSBhbiBlcnJvciBjb250cm9sIGluIGVuZ2luZV9kYXRhIGFuZCB3ZQp3 b3VsZCBuZXZlciB1bmRlcnN0YW5kIHdoZXRoZXIgdGhlcmUgaXMgc29tdGhpbmcgc2NyZXdlZCB1 cC4KCkkgd2FzIHRoaW5raW5nIHRoYXQgSSBjYW4gYWRkIGluIHRoZSBzdHJ1Y3R1cmUgYW4gImVy cm9yIgp2YXJpYWJsZSBzbyB0aGF0IHdlIHF1aXQgdGhlIGxvb3AgaWYgc29tZXRoaW5nIHdyb25n IGhhcHBlbnMsCmUuZy4gd2UgcmVjZWl2ZSBzaXplID4gM2YuCgo+ID4gKyAgICAgICAgICAgICAg IF9fZm9yX2VhY2hfZW5naW5lX2NsYXNzX2luc3RhbmNlKGUyKSB7Cj4gPiArICAgICAgICAgICAg ICAgICAgICAgICB1aW50NjRfdCBmbGFnczsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgIGlmICghZ2VtX2hhc19lbmdpbmUoZmQsIGUyLT5jbGFzcywgZTItPmluc3RhbmNlKSkKPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cj4gPiArCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICBmbGFncyA9IGdlbV9jbGFzc19pbnN0YW5jZV90b19lYl9mbGFn cyhmZCwgZTItPmNsYXNzLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZTItPmluc3RhbmNlKTsKPiAKPiBZb3UgYWRkZWQg dGhlIGZpZWxkIHRvIHRoZSBzdGF0aWMgc3RydWN0LCB5b3UgbWlnaHQgYXMgd2VsbCBwb3B1bGF0 ZSBpdAo+IGFzIHdlbGwsIGFuZCBqdXN0IHVzZSBlMi0+ZmxhZ3MuIEFuZCB0aGVuIHlvdSB3b3Vs ZG4ndCBldmVuIG5lZWQgdG8KPiByZXBlYXQgdGhlIGNvbXB1dGF0aW9uIGZvciBnZW1faGFzX2Vu Z2luZS4KCm1ha2VzIHNlbnNlLgoKPiA+ICtzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEgaW50ZWxf aW5pdF9lbmdpbmVfbGlzdChpbnQgZmQsIHVpbnQzMl90IGN0eF9pZCk7Cj4gPiArCj4gPiArI2Vu ZGlmIC8qIEdFTV9FTkdJTkVfVE9QT0xPR1lfSCAqLwo+ID4gZGlmZiAtLWdpdCBhL2xpYi9pZ3Rf Z3QuaCBiL2xpYi9pZ3RfZ3QuaAo+ID4gaW5kZXggNDc1YzBiM2MzY2M2Li44NGVhNGFmNTM5MmQg MTAwNjQ0Cj4gPiAtLS0gYS9saWIvaWd0X2d0LmgKPiA+ICsrKyBiL2xpYi9pZ3RfZ3QuaAo+IAo+ IEFuZCB3ZSBuZWVkIHRvIGJyZWFrIGF3YXkgZnJvbSBpZ3RfZ3QuaCwgdGhlc2Ugd2lsbCBhbGwg YmUgZ29vZCBpbnNpZGUKPiBnZW1fZW5naW5lX3RvcG9sb2d5LmggSSB0aGluay4KCkkgd2FzIHRo aW5raW5nIHRoZSBzYW1lLCBidXQgZ2l2ZW4gdGhhdCBhbGwgdGhlIGZvcl9lYWNoIGFyZSBpbgpp Z3RfZ3QuaCBJIGd1ZXNzIHRoYXQncyB0aGUgcmlnaHQgcGxhY2UgZm9yIGNvbnNpc3RlbmNlLCB1 bmxlc3MKd2UgbW92ZSBhbGwgdGhlIGZvcl9lYWNoLCB1bnRpbCB3ZSB3aWxsIGdldCByaWQgb2Yg YWxsIHRoZQpsZWdhY3kuCgpBbmRpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0 LWRldg==