From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id E24D46E092 for ; Thu, 21 Mar 2019 12:18:05 +0000 (UTC) Date: Thu, 21 Mar 2019 14:18:02 +0200 From: Andi Shyti Message-ID: <20190321121802.GC1774@intel.intel> References: <20190321010015.1317-1-andi.shyti@intel.com> <20190321010015.1317-5-andi.shyti@intel.com> <34e42d43-c18b-d832-6971-505146fbec71@linux.intel.com> <20190321112343.GA1774@intel.intel> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [igt-dev] [PATCH v14 4/5] lib/i915: add gem_engine_topology library and for_each loop definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin Cc: IGT dev , Andi Shyti List-ID: SGkgVHZydGtvLAoKPiA+ID4gPiArewo+ID4gPiA+ICsJc3RhdGljIGNvbnN0IGNoYXIgKnVua19u YW1lID0gInVuayI7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJZTItPmNsYXNzICAgID0gY2xhc3M7Cj4g PiA+ID4gKwllMi0+aW5zdGFuY2UgPSBpbnN0YW5jZTsKPiA+ID4gPiArCWUyLT5mbGFncyAgICA9 IGZsYWdzOwo+ID4gPiA+ICsKPiA+ID4gPiArCWlmIChuYW1lKSB7Cj4gPiA+ID4gKwkJZTItPm5h bWUgPSBuYW1lOwo+ID4gPiAKPiA+ID4gVGhpcyBwYXRoIGlzIHVzZWQgb25seSBmb3IgdGhlIGxl Z2FjeSBmYWxsIGJhY2sgbW9kZSBzbyBJIGFtIGNvbnRlbXBsYXRpbmcKPiA+ID4gd2hldGhlciBp cyBpcyBldmVuIHdvcnRoIGhhdmluZyB0aGUgbmFtZSBwYXNzZWQgaW4uCj4gPiAKPiA+IHllcywg anVzdCB3YW50ZWQgdG8gYmUgY29uc2lzdGVudC4gQXQgdGhlIGJpZ2lubmluZyB0aGUKPiA+IGR1 cF9lbmdpbmUgaGFkIGEgYmlnZ2VyIHJvbGUsIGJ1dCB0aGVuIEkgZGVtb3RlZCBpdCB0byBqdXN0 IGRvaW5nCj4gPiB0aGlzLgo+ID4gCj4gPiA+IFRoZSBpZiB5b3UgZmluZCBhIHZpcnR1YWwgZW5n aW5lIGluIHRoZSBsaXN0ICgKPiA+ID4gSTkxNV9FTkdJTkVfQ0xBU1NfSU5WQUxJRC9JOTE1X0VO R0lORV9DTEFTU19JTlZBTElEX1ZJUlRVQUwpIHlvdSBjb3VsZCBzZXQKPiA+ID4gdGhlIG5hbWUg dG8gInZpcnR1YWwiIG9yIHNvbWV0aGluZy4KPiA+IAo+ID4gZG8gd2UgcmVhbGx5IG5lZWQgYSBu YW1lIG9mIHRoZSB0eXBlICJ2aXJ0dWFsLTxlbmdpbmU+Ij8KPiAKPiBQcm9iYWJseSBub3QuIFBs YWluICJ2aXJ0dWFsIiBzb3VuZHMgb2suCgpPSyEKCj4gPiA+ID4gKyNkZWZpbmUgZm9yX2VhY2hf ZW5naW5lX2NsYXNzX2luc3RhbmNlKGZkX18sIGN0eF9fLCBlX18pIFwKPiA+ID4gPiArCWZvciAo c3RydWN0IGludGVsX2VuZ2luZV9kYXRhIGlfXyA9IGludGVsX2luaXRfZW5naW5lX2xpc3QoZmRf XywgY3R4X18pOyBcCj4gPiA+ID4gKwkJKChlX18pID0gKGlfXy5uIDwgaV9fLm5lbmdpbmVzKSA/ ICZpX18uZW5naW5lc1tpX18ubl0gOiBOVUxMKTsgXAo+ID4gPiA+ICsJCQlpX18ubisrKQo+ID4g PiAKPiA+ID4gRG8gd2Ugd2FudCBhIGNvbnRleHQgcGFyYW1ldGVyIGluIHRoaXMgaGVscGVyLCBv ciBldmVuIHRoaXMgaGVscGVyIGF0IGFsbD8gSQo+ID4gPiB0aG91Z2h0IHdlIGNhbiBlbmQgdXAg d2l0aCBvbmx5IHR3bywgZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lIGFuZAo+ID4gPiBmb3JfZWFj aF9jb250ZXh0X2VuZ2luZSAtIGJ1dCBJIGd1ZXNzIGl0IGlzIG9wZW4gZm9yIGRpc2N1c3Npb24u Cj4gPiAKPiA+IEkgZG9uJ3Qga25vdyBvZiBwb3NzaWJsZSB1c2UgY2FzZXMgdGhhdCBkbyBvciBk b24ndCBuZWVkIGN0eAo+ID4gb3V0c2lkZSB0aGUgZm9yX2VhY2guLi4oKS4KPiA+IAo+ID4gSWYg eW91IGRvbid0IHNlZSBhbnkgdXNlIG9mIHRoZSBjb250ZXh0IGluZGV4IG91dHNpZGUgdGhlCj4g PiBmb3JfZWFjaCBJIGNhbiBjcmVhdGUgdGhlIGNvbnRleHQgaW5zaWRlIHRoZSBpbml0X2xpc3Qg ZnVuY3Rpb24uCj4gPiAKPiA+IEJ1dCwgSSBoYXZlIGEgbGl0dGxlIGNvbmNlcm4gYWJvdXQgdGhl IGRlc3RyYWN0aW9uIG9mIHRoYXQKPiA+IGNvbnRleHQuIElmIHRoZSBmb3JfZWFjaC4uLiBnZXRz IGludGVycnVwdGVkIGluIHRoZSBtaWRkbGUgb2YgdGhlCj4gPiBsb29wLCB3ZSBsb3NlIHRoZSBj b250ZXh0Lgo+IAo+IEkgYW0gbm90IGZvbGxvd2luZyBob3cgd2UgbG9zZSB0aGUgY29udGV4dD8K Ck9LLCB5b3UgYXJlIHRhbGtpbmcgYWJvdXQgZm9yX2VhY2hfcGh5c2ljYWwuLi4gc29ycnksIHNv bWV0aW1lcyBJCm1pZ2h0IGdldCBsb3N0LgoKPiBJIHdhcyBqdXN0IGRpc2N1c3Npbmcgb2Ygb3Vy IGRlc2lyZWQgZW5kIGdhbWUgaW4gdGhlcm1zIG9mIG51bWJlciBhbmQKPiBzaWduYXR1cmUgZm9y IGZvcl9lYWNoXy4uIGl0ZXJhdG9ycy4KPiAKPiBGb3IgbWUgZm9yX2VhY2hfcGh5c2ljYWxfZW5n aW5lIGRvZXNuJ3QgbmVlZCB0aGUgY29udGV4dCBzaW5jZSBpdCBpcyBhYm91dAo+IHBoeXNpY2Fs IGVuZ2luZXMgLSBub3QgZW5naW5lIGZyb20gdGhlIGVuZ2luZSBtYXAuIE1heWJlIHRoYXQgb25l IHNob3VsZAo+IGV2ZW4gaGF2ZSBzb21lIGFzc2VydHMgdGhlbiB0byBtYWtlIHN1cmUgc29tZW9u ZSBoYXNuJ3QgcmUtY29uZmlndXJlZCB0aGUKPiBkZWZhdWx0IGNvbnRleHQuCj4gCj4gQW5kIHdl IGhhdmUgX19mb3JfZWFjaF9waHlzaWNhbF9lbmdpbmUgd2hpY2ggdXNlcyB0aGUgc3RhdGljIHRh YmxlLCBmb3IKPiBzdWJ0ZXN0IGVudW1lcmF0aW9uLgo+IAo+IFRoZW4gZm9yX2VhY2hfY29udGV4 dF9lbmdpbmUgaXMgdGhlIGZ1bGx5IGZlYXR1cmVkIG9uZSwgd2hpY2ggaGFzIHRoZQo+IGNvbnRl eHQgaWQgaW4gcGFyYW1ldGVycy4KPiAKPiBDYW4gd2Ugc29sdmUgYWxsIHVzZSBjYXNlcyB3aXRo IHRob3NlIHRocmVlIG9yIHdlIG5lZWQgbW9kZT8KCk9mIGNvdXJzZSB5ZXMsIFdlIHdpbGwgaGF2 ZSBpbiB0aGlzIGNhc2UgdGhlc2UgdGhyZWU6CgpfX2Zvcl9lYWNoX3BoeXNpY2FsX2VuZ2luZShl KQoKZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lKGZkLCBlKSAvKiBkb2Vzbid0IG5lZWQgY29udGV4 dCAqLwoKZm9yX2VhY2hfZW5naW5lX2NsYXNzX2luc3RhbmNlKGZkLCBjdHgsIGUpCgoKUFMKV2hh dCBJIG1lYW50IGJlZm9yZSBpcyB0aGF0IHRoYXQgd2UgY291bGQgaGF2ZSBhCgpmb3JfZWFjaF9l bmdpbmVfY2xhc3NfaW5zdGFuY2UoZmQsIGUpCgp3aGVyZSB0aGUgY29udGV4dCBpcyBjcmVhdGVk IGluc2lkZSB0aGUgZm9yX2VhY2gsIGJ1dCBpbiBjYXNlIG9mOgoKICBmb3JfZWFjaF9lbmdpbmVf Y2xhc3NfaW5zdGFuY2UoZmQsIGUpIHsgLyogPC0tLSBjcmVhdGVzIGNvbnRleHQgaW4gaW50ZWxf aW5pdF9lbmdpbmVfbGlzdCgpICovCiAgICBpZiAoPGFueV9jb25kaXRpb24+KQogICAgICBicmVh azsgLyogPC0tLS0gd2UgZG9uJ3QgaGF2ZSB0aW1lIHRvIGNhbGwgZ2VtX2NvbnRleHRfZGVzdHJv eSgpICovCiAgfQoKQnV0IHlvdSB3ZXJlIHJlZmVycmluZyB0byBwaHlzaWNhbCBlbmdpbmVzLCBh bmQgaW4gdGhhdCBjYXNlCnRoZXJlIGFyZSBubyBpc3N1ZXMuCgo+ID4gPiA+IEBAIC00MzQsNyAr NDM0LDcgQEAgYnVzeV9jaGVja19hbGwoaW50IGdlbV9mZCwgY29uc3Qgc3RydWN0IGludGVsX2V4 ZWN1dGlvbl9lbmdpbmUyICplLAo+ID4gPiA+ICAgIAlpID0gMDsKPiA+ID4gPiAgICAJZmRbMF0g PSAtMTsKPiA+ID4gPiAtCWZvcl9lYWNoX2VuZ2luZV9jbGFzc19pbnN0YW5jZShnZW1fZmQsIGVf KSB7Cj4gPiA+ID4gKwlmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCAwLCBl Xykgewo+ID4gPiA+ICAgIAkJaWYgKGUgPT0gZV8pCj4gPiA+ID4gICAgCQkJYnVzeV9pZHggPSBp Owo+ID4gPiA+IEBAIC00OTcsNyArNDk3LDcgQEAgbW9zdF9idXN5X2NoZWNrX2FsbChpbnQgZ2Vt X2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKmUsCj4gPiA+ID4gICAg CXVuc2lnbmVkIGludCBpZGxlX2lkeCwgaTsKPiA+ID4gPiAgICAJaSA9IDA7Cj4gPiA+ID4gLQlm b3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCBlXykgewo+ID4gPiA+ICsJZm9y X2VhY2hfZW5naW5lX2NsYXNzX2luc3RhbmNlKGdlbV9mZCwgMCwgZV8pIHsKPiA+ID4gPiAgICAJ CWlmIChlID09IGVfKQo+ID4gPiA+ICAgIAkJCWlkbGVfaWR4ID0gaTsKPiA+ID4gPiAgICAJCWVs c2UgaWYgKHNwaW4pCj4gPiA+ID4gQEAgLTU1NCw3ICs1NTQsNyBAQCBhbGxfYnVzeV9jaGVja19h bGwoaW50IGdlbV9mZCwgY29uc3QgdW5zaWduZWQgaW50IG51bV9lbmdpbmVzLAo+ID4gPiA+ICAg IAl1bnNpZ25lZCBpbnQgaTsKPiA+ID4gPiAgICAJaSA9IDA7Cj4gPiA+ID4gLQlmb3JfZWFjaF9l bmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCBlKSB7Cj4gPiA+ID4gKwlmb3JfZWFjaF9lbmdp bmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCAwLCBlKSB7Cj4gPiA+ID4gICAgCQlpZiAoc3BpbikK PiA+ID4gPiAgICAJCQlfX3N1Ym1pdF9zcGluX2JhdGNoKGdlbV9mZCwgc3BpbiwgZSwgNjQpOwo+ ID4gPiA+ICAgIAkJZWxzZQo+ID4gPiA+IEBAIC0xNjgzLDcgKzE2ODMsNyBAQCBpZ3RfbWFpbgo+ ID4gPiA+ICAgIAkJaWd0X3JlcXVpcmVfZ2VtKGZkKTsKPiA+ID4gPiAgICAJCWlndF9yZXF1aXJl KGk5MTVfdHlwZV9pZCgpID4gMCk7Cj4gPiA+ID4gLQkJZm9yX2VhY2hfZW5naW5lX2NsYXNzX2lu c3RhbmNlKGZkLCBlKQo+ID4gPiA+ICsJCWZvcl9lYWNoX2VuZ2luZV9jbGFzc19pbnN0YW5jZShm ZCwgMCwgZSkKPiA+ID4gPiAgICAJCQludW1fZW5naW5lcysrOwo+ID4gPiA+ICAgIAl9Cj4gPiA+ ID4gCj4gPiA+IAo+ID4gPiBMb29rcyBsaWtlIHRoaXMgd291bGQgd29yay4gSnVzdCB0aGUgcXVl c3Rpb24gb2YgdmlydHVhbCBlbmdpbmUsIHNldCBvZgo+ID4gPiBjaG9zZW4gaXRlcmF0b3JzLCBh bmQgbWF5YmUgc29tZSBuaXRzLgo+ID4gCj4gPiBZZXMsIGFzIHdlIGRpc2N1c3NlZCwgcmlnaHQg YWZ0ZXIgdGhpcyBwYXRjaHNldCBJIHdpbGwgZG8gdGhlCj4gPiBmb3JfZWFjaF9waHlzaWNhbC4K PiA+IAo+ID4gV2hhdCBhcmUgdGhlIG5pdHM/IEkgbG92ZSBuaXRzIDopCj4gCj4gSnVzdCB0aGlu Z3MgbGlrZSB0eXBlcyBhbmQgY29kaW5nIHN0eWxlLiA6KSBBbmQgc29tZSBtb3JlIGRldGFpbHMg ZnJvbQo+IENocmlzJyByZXZpZXcuCgpUaGFua3MhCkFuZGkKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pZ3QtZGV2