From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] runner/job_list: print error when job list is empty
Date: Thu, 21 Mar 2019 14:44:49 +0200 [thread overview]
Message-ID: <20190321124449.30686-1-simon.ser@intel.com> (raw)
Using a filter that doesn't match any test name resulted in the runner
silently failing. Print an error message so that the user understands
why the runner fails.
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
runner/job_list.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/runner/job_list.c b/runner/job_list.c
index 97bbb0be..f5c16af3 100644
--- a/runner/job_list.c
+++ b/runner/job_list.c
@@ -133,6 +133,7 @@ static bool filtered_job_list(struct job_list *job_list,
{
FILE *f;
char buf[128];
+ bool ok;
if (job_list->entries != NULL) {
fprintf(stderr, "Caller didn't clear the job list, this shouldn't happen\n");
@@ -179,7 +180,11 @@ static bool filtered_job_list(struct job_list *job_list,
&settings->exclude_regexes);
}
- return job_list->size != 0;
+ ok = job_list->size != 0;
+ if (!ok) {
+ fprintf(stderr, "Filter didn't match any job name\n");
+ }
+ return ok;
}
static bool job_list_from_test_list(struct job_list *job_list,
--
2.21.0
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-03-21 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 12:44 Simon Ser [this message]
2019-03-21 13:22 ` [igt-dev] ✓ Fi.CI.BAT: success for runner/job_list: print error when job list is empty Patchwork
2019-03-22 2:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-25 11:19 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-03-25 13:51 ` Ser, Simon
2019-03-25 13:59 ` Petri Latvala
2019-04-15 14:29 ` Ser, Simon
2019-04-16 9:56 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321124449.30686-1-simon.ser@intel.com \
--to=simon.ser@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox