Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Run basic test on simulation

Kumar Valsan, Prathap
2019-03-22T13:44:32Z

On Fri, Mar 22, 2019 at 07:19:01AM +0000, Chris Wilson wrote:
> Quoting Prathap Kumar Valsan (2019-03-21 23:06:13)
> > Basic test don't take long to complete, so allow basic test to
> > run on simulation.
> > ---
> > tests/i915/gem_exec_gttfill.c | 13 ++++++++-----
> > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
> > index efd612bb..92c3cf62 100644
> > --- a/tests/i915/gem_exec_gttfill.c
> > +++ b/tests/i915/gem_exec_gttfill.c
> > @@ -144,7 +144,8 @@ static void fillgtt(int fd, unsigned ring, int timeout)
> > count = size / BATCH_SIZE + 1;
> > igt_debug("Using %'d batches to fill %'llu aperture on %d engines\n",
> > count, (long long)size, nengine);
> > - intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
> > + if (!igt_run_in_simulation())
> > + intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
>
> No. That is too ugly. You are basically saying that memory limits don't
> matter for simulation -- unless the reader is aware of the convoluted
> story in the setup and that we've previously marked as anything that
> requires to check memory is not suitable for the slow simulator.
>
Chris,
gem_exec_gtfill@basic has been marked as a test that we need to run on
simulation. https://jira.devtools.intel.com/browse/VLK-1649
This is the intention behind trying to enable this test.

Will follow-up in the Jira to understand what we need to run for this
test.
> Why do you want to run this on the simulator? Write that test.
> -Chris