From: Andi Shyti <andi.shyti@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v15 4/5] lib/i915: add gem_engine_topology library and for_each loop definition
Date: Fri, 22 Mar 2019 12:06:45 +0200 [thread overview]
Message-ID: <20190322100645.GC1557@intel.intel> (raw)
In-Reply-To: <ecde4c61-b09d-e586-fbc1-02d131cad552@linux.intel.com>
> > + ret = __gem_context_get_param(fd, ¶m);
> > +
> > + nengines = param.size > sizeof(struct i915_context_param_engines) ?
> > + (param.size - sizeof(struct i915_context_param_engines)) /
> > + sizeof(engines->class_instance[0]) :
> > + 0;
> > +
> > + if (nengines > I915_EXEC_RING_MASK + 1) {
> > + engine_data.error = ret ? ret : -EINVAL;
> > + return engine_data;
> > + }
> > +
> > + if (__gem_context_get_param(fd, ¶m)) {
>
> Why are you calling get_param twice btw?
yes... please, don't bother... while moving things around I
forgot it. Thanks!
I told Chris yeterday, my distraction will kill me once :)
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-22 10:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 16:05 [igt-dev] [PATCH v15 0/5] new engine discovery interface Andi Shyti
2019-03-21 16:05 ` [igt-dev] [PATCH v15 1/5] lib/igt_gt: remove unnecessary argument Andi Shyti
2019-03-21 16:05 ` [igt-dev] [PATCH v15 2/5] lib: ioctl_wrappers: reach engines by index as well Andi Shyti
2019-03-21 16:08 ` Chris Wilson
2019-03-21 16:14 ` Andi Shyti
2019-03-21 16:16 ` Chris Wilson
2019-03-21 16:45 ` Tvrtko Ursulin
2019-03-21 16:05 ` [igt-dev] [PATCH v15 3/5] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-03-21 16:05 ` [igt-dev] [PATCH v15 4/5] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-03-22 7:47 ` Tvrtko Ursulin
2019-03-22 7:59 ` Chris Wilson
2019-03-22 9:56 ` Tvrtko Ursulin
2019-03-22 9:59 ` Chris Wilson
2019-03-22 10:03 ` Andi Shyti
2019-03-22 9:51 ` Andi Shyti
2019-03-22 10:10 ` Tvrtko Ursulin
2019-03-22 9:58 ` Tvrtko Ursulin
2019-03-22 10:06 ` Andi Shyti [this message]
2019-03-22 10:46 ` Tvrtko Ursulin
2019-03-21 16:05 ` [igt-dev] [PATCH v15 5/5] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test Andi Shyti
2019-03-21 17:08 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-03-22 9:02 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322100645.GC1557@intel.intel \
--to=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox