public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: fix typo in check_analog_bridge
Date: Tue, 26 Mar 2019 15:32:30 +0200	[thread overview]
Message-ID: <20190326133230.31950-1-simon.ser@intel.com> (raw)

This function checks whether a port is an analog bridge. Analog
bridges provide their own EDID thus the vendor should be different
from "IGT".

There was a typo that made the function always return true for VGA
ports. The condition was essentially:

    thing != 'I' || thing != 'T'

which is always true.

Apparently this didn't cause any harm, but it's probably better to fix
it anyway in case some tests were skipped and shouldn't.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 tests/kms_chamelium.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index c2090037..2dc1049d 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -199,7 +199,7 @@ check_analog_bridge(data_t *data, struct chamelium_port *port)
 
 	/* Analog bridges provide their own EDID */
 	if (edid_vendor[0] != 'I' || edid_vendor[1] != 'G' ||
-	    edid_vendor[0] != 'T')
+	    edid_vendor[2] != 'T')
 		return true;
 
 	return false;
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-03-26 13:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 13:32 Simon Ser [this message]
2019-03-26 14:46 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium: fix typo in check_analog_bridge Patchwork
2019-03-26 19:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-26 20:06 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190326133230.31950-1-simon.ser@intel.com \
    --to=simon.ser@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox