Re: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: fix typo in check_analog_bridge

Antonio Argenziano
2019-03-26T20:06:14Z

On 26/03/19 06:32, Simon Ser wrote:
> This function checks whether a port is an analog bridge. Analog
> bridges provide their own EDID thus the vendor should be different
> from "IGT".
>
> There was a typo that made the function always return true for VGA
> ports. The condition was essentially:
>
> thing != 'I' || thing != 'T'
>
> which is always true.
>
> Apparently this didn't cause any harm, but it's probably better to fix
> it anyway in case some tests were skipped and shouldn't.
>

LGTM.
Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>

> Signed-off-by: Simon Ser <simon.ser@intel.com>
> ---
> tests/kms_chamelium.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> index c2090037..2dc1049d 100644
> --- a/tests/kms_chamelium.c
> +++ b/tests/kms_chamelium.c
> @@ -199,7 +199,7 @@ check_analog_bridge(data_t *data, struct chamelium_port *port)
>
> /* Analog bridges provide their own EDID */
> if (edid_vendor[0] != 'I' || edid_vendor[1] != 'G' ||
> - edid_vendor[0] != 'T')
> + edid_vendor[2] != 'T')
> return true;
>
> return false;
>