From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id F35BB6E0BC for ; Wed, 27 Mar 2019 08:26:27 +0000 (UTC) Date: Wed, 27 Mar 2019 09:26:23 +0100 From: Boris Brezillon Message-ID: <20190327092623.2258f092@collabora.com> In-Reply-To: <20190228141918.26043-5-daniel.vetter@ffwll.ch> References: <20190228141918.26043-1-daniel.vetter@ffwll.ch> <20190228141918.26043-5-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 5/9] tests/kms_lease: test implicit primary plane usage in setcrtc ioctl List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Vetter Cc: IGT development , Daniel Vetter , Keith Packard List-ID: T24gVGh1LCAyOCBGZWIgMjAxOSAxNToxOToxNCArMDEwMApEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPiB3cm90ZToKCj4gQWdhaW4gd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhh dCBhIGxlYXNlIGNhbid0IHVzZSBwbGFuZXMgaXQncyBub3QKPiBhbGxvd2VkIHRvIHRocm91Z2gg bGVnYWN5IGlvY3Rscy4gU2V0Q3J0YyBpcyBhIGJpdCBtb3JlIHRyaWNreSwgc2luY2UKCgkgIF4g InRvIHVzZSB0aHJvdWdoIj8KCj4gd2Ugc2hvdWxkIHN0aWxsIGFsbG93IHRvIHNodXQgZG93biBh IENSVEMsIGUuZy4gd2hlbiB3ZSdyZSBhbGxvd2VkIHRvCj4gdXNlIG90aGVyIHBsYW5lcyBvbiB0 aGF0IENSVEMuCj4gCj4gQ3VycmVudCBrZXJuZWxzIGZhaWwgdGhpcy4KPiAKPiBDYzogS2VpdGgg UGFja2FyZCA8a2VpdGhwQGtlaXRocC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gLS0tCj4gIHRlc3RzL2ttc19sZWFzZS5jIHwg NjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Kwo+ICAxIGZpbGUgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS90 ZXN0cy9rbXNfbGVhc2UuYyBiL3Rlc3RzL2ttc19sZWFzZS5jCj4gaW5kZXggNjQ1M2M3YmVhZmQ4 Li5jMTFkMzdhZWFjN2EgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMva21zX2xlYXNlLmMKPiArKysgYi90 ZXN0cy9rbXNfbGVhc2UuYwo+IEBAIC0zNzIsNiArMzcyLDY1IEBAIHN0YXRpYyB2b2lkIHBhZ2Vf ZmxpcF9pbXBsaWNpdF9wbGFuZShkYXRhX3QgKmRhdGEpCj4gIAkJICAgICBjb25uZWN0b3JfaWRf dG9fb3V0cHV0KCZkYXRhLT5tYXN0ZXIuZGlzcGxheSwgZGF0YS0+Y29ubmVjdG9yX2lkKSk7Cj4g IH0KPiAgCj4gK3N0YXRpYyB2b2lkIHNldGNydGNfaW1wbGljaXRfcGxhbmUoZGF0YV90ICpkYXRh KQo+ICt7Cj4gKwl1aW50MzJfdCBvYmplY3RfaWRzWzNdOwo+ICsJc3RydWN0IGxvY2FsX2RybV9t b2RlX2NyZWF0ZV9sZWFzZSBtY2w7Cj4gKwlkcm1Nb2RlUGxhbmVSZXMgKnBsYW5lX3Jlc291cmNl czsKPiArCXVpbnQzMl90IHdyb25nX3BsYW5lX2lkID0gMDsKPiArCWlndF9vdXRwdXRfdCAqb3V0 cHV0ID0KPiArCQljb25uZWN0b3JfaWRfdG9fb3V0cHV0KCZkYXRhLT5tYXN0ZXIuZGlzcGxheSwK PiArCQkJCSAgICAgICBkYXRhLT5jb25uZWN0b3JfaWQpOwo+ICsJZHJtTW9kZU1vZGVJbmZvICpt b2RlID0gaWd0X291dHB1dF9nZXRfbW9kZShvdXRwdXQpOwo+ICsJaW50IGk7Cj4gKwo+ICsJLyog ZmluZCBhIHBsYW5lIHdoaWNoIGlzbid0IHRoZSBwcmltYXJ5IG9uZSBmb3IgdXMgKi8KPiArCXBs YW5lX3Jlc291cmNlcyA9IGRybU1vZGVHZXRQbGFuZVJlc291cmNlcyhkYXRhLT5tYXN0ZXIuZmQp Owo+ICsJZm9yIChpID0gMDsgaSA8IHBsYW5lX3Jlc291cmNlcy0+Y291bnRfcGxhbmVzOyBpKysp IHsKPiArCQlpZiAocGxhbmVfcmVzb3VyY2VzLT5wbGFuZXNbaV0gIT0gZGF0YS0+cGxhbmVfaWQp IHsKPiArCQkJd3JvbmdfcGxhbmVfaWQgPSBwbGFuZV9yZXNvdXJjZXMtPnBsYW5lc1tpXTsKPiAr CQkJYnJlYWs7Cj4gKwkJfQo+ICsJfQo+ICsJZHJtTW9kZUZyZWVQbGFuZVJlc291cmNlcyhwbGFu ZV9yZXNvdXJjZXMpOwo+ICsJaWd0X3JlcXVpcmUod3JvbmdfcGxhbmVfaWQpOwoKTWF5YmUgd2Ug Y291bGQgYWRkIGFuIGhlbHBlciB0byByZXRyaWV2ZSB3cm9uZ19wbGFuZV9pZCBpbnN0ZWFkIG9m CmR1cGxpY2F0aW5nIHRoZSBjb2RlLgoKPiArCj4gKwltY2wub2JqZWN0X2lkcyA9ICh1aW50NjRf dCkgKHVpbnRwdHJfdCkgJm9iamVjdF9pZHNbMF07Cj4gKwltY2wub2JqZWN0X2NvdW50ID0gMDsK PiArCW1jbC5mbGFncyA9IDA7Cj4gKwo+ICsJb2JqZWN0X2lkc1ttY2wub2JqZWN0X2NvdW50Kytd ID0gZGF0YS0+Y29ubmVjdG9yX2lkOwo+ICsJb2JqZWN0X2lkc1ttY2wub2JqZWN0X2NvdW50Kytd ID0gZGF0YS0+Y3J0Y19pZDsKPiArCj4gKwlkcm1TZXRDbGllbnRDYXAoZGF0YS0+bWFzdGVyLmZk LCBEUk1fQ0xJRU5UX0NBUF9VTklWRVJTQUxfUExBTkVTLCAwKTsKPiArCWRvX29yX2RpZShjcmVh dGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSk7Cj4gKwlkcm1TZXRDbGllbnRDYXAoZGF0 YS0+bWFzdGVyLmZkLCBEUk1fQ0xJRU5UX0NBUF9VTklWRVJTQUxfUExBTkVTLCAxKTsKPiArCj4g KwkvKiBTZXQgYSBtb2RlIG9uIHRoZSBsZWFzZWQgb3V0cHV0ICovCj4gKwlpZ3RfYXNzZXJ0X2Vx KDAsIHByZXBhcmVfY3J0YygmZGF0YS0+bWFzdGVyLCBkYXRhLT5jb25uZWN0b3JfaWQsIGRhdGEt PmNydGNfaWQpKTsKClNhbWUgZ29lcyBmb3IgdGhvc2UgY3JlYXRlLWxlYXNlK3ByZXBhcmUtQ1JU QyBzdGVwcy4KCj4gKwo+ICsJLyogc2FuaXR5IGNoZWNrICovCj4gKwlkb19vcl9kaWUoZHJtTW9k ZVNldENydGMoZGF0YS0+bWFzdGVyLmZkLCBkYXRhLT5jcnRjX2lkLCAtMSwKPiArCQkJCSAwLCAw LCBvYmplY3RfaWRzLCAxLCBtb2RlKSk7Cj4gKwlkb19vcl9kaWUoZHJtTW9kZVNldENydGMobWNs LmZkLCBkYXRhLT5jcnRjX2lkLCAtMSwKPiArCQkJCSAwLCAwLCBvYmplY3RfaWRzLCAxLCBtb2Rl KSk7Cj4gKwljbG9zZShtY2wuZmQpOwo+ICsKPiArCW9iamVjdF9pZHNbbWNsLm9iamVjdF9jb3Vu dCsrXSA9IHdyb25nX3BsYW5lX2lkOwo+ICsJZG9fb3JfZGllKGNyZWF0ZV9sZWFzZShkYXRhLT5t YXN0ZXIuZmQsICZtY2wpKTsKPiArCj4gKwlpZ3RfYXNzZXJ0X2VxKGRybU1vZGVTZXRDcnRjKG1j bC5mZCwgZGF0YS0+Y3J0Y19pZCwgLTEsCj4gKwkJCQkgICAgIDAsIDAsIG9iamVjdF9pZHMsIDEs IG1vZGUpLAo+ICsJCSAgICAgIC1FQUNDRVMpOwo+ICsJLyogbWFrZSBzdXJlIHdlIGFyZSBhbGxv d2VkIHRvIHR1cm4gdGhlIENSVEMgb2ZmICovCj4gKwlkb19vcl9kaWUoZHJtTW9kZVNldENydGMo bWNsLmZkLCBkYXRhLT5jcnRjX2lkLAo+ICsJCQkJIDAsIDAsIDAsIE5VTEwsIDAsIE5VTEwpKTsK CkRvIHdlIGFjdHVhbGx5IHRlc3QgdGhlIGNhc2Ugd2hlcmUgdGhlIGxlc3NvciBoYXMgc2V0dXAg dGhlIENSVEMgd2l0aCBhCnBsYW5lIHRoYXQncyBub3QgYWNjZXNzaWJsZSBieSB0aGUgbGVzc2Uu IEkgdGhpbmsgdGhhdCdzIHdoYXQgeW91IHdlcmUKdHJ5aW5nIHRvIHRlc3QgaGVyZSwgYnV0IEkg ZG9uJ3Qgc2VlIHdoZXJlIGl0J3MgZG9uZSBpbiB0aGUgY29kZS4KU2hvdWxkbid0IHdlIGhhdmUg c29tZXRoaW5nIGxpa2U6CgoJZG9fb3JfZGllKGRybU1vZGVTZXRDcnRjKGRhdGEtPm1hc3Rlci5m ZCwgZGF0YS0+Y3J0Y19pZCwgLTEsCgkJCQkgMCwgMCwgb2JqZWN0X2lkcywgMSwgbW9kZSkpOwoJ aWd0X2Fzc2VydF9lcSgwLCBkcm1Nb2RlU2V0Q3J0YyhtY2wuZmQsIGRhdGEtPmNydGNfaWQsIDAs IDAsIDAsCgkJCQkJTlVMTCwgMCwgTlVMTCkpOwoKCkxvb2tzIGdvb2Qgb3RoZXJ3aXNlLgoKUmV2 aWV3ZWQtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGNvbGxhYm9yYS5jb20+ Cgo+ICsJY2xvc2UobWNsLmZkKTsKPiArCj4gKwljbGVhbnVwX2NydGMoJmRhdGEtPm1hc3RlciwK PiArCQkgICAgIGNvbm5lY3Rvcl9pZF90b19vdXRwdXQoJmRhdGEtPm1hc3Rlci5kaXNwbGF5LCBk YXRhLT5jb25uZWN0b3JfaWQpKTsKPiArfQo+ICsKPiAgLyogVGVzdCBsaXN0aW5nIGxlc3NlZXMg Ki8KPiAgc3RhdGljIHZvaWQgbGVzc2VlX2xpc3QoZGF0YV90ICpkYXRhKQo+ICB7Cj4gQEAgLTEw ODYsNiArMTE0NSw3IEBAIGlndF9tYWluCj4gIAkJeyAibGVhc2VfaW52YWxpZF9jcnRjIiwgbGVh c2VfaW52YWxpZF9jcnRjIH0sCj4gIAkJeyAibGVhc2VfaW52YWxpZF9wbGFuZSIsIGxlYXNlX2lu dmFsaWRfcGxhbmUgfSwKPiAgCQl7ICJwYWdlX2ZsaXBfaW1wbGljaXRfcGxhbmUiLCBwYWdlX2Zs aXBfaW1wbGljaXRfcGxhbmUgfSwKPiArCQl7ICJzZXRjcnRjX2ltcGxpY2l0X3BsYW5lIiwgc2V0 Y3J0Y19pbXBsaWNpdF9wbGFuZSB9LAo+ICAJCXsgfQo+ICAJfSwgKmY7Cj4gIAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxp c3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2