From: Boris Brezillon <boris.brezillon@collabora.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: IGT development <igt-dev@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Keith Packard <keithp@keithp.com>
Subject: Re: [igt-dev] [PATCH i-g-t 6/9] tests/kms_lease: test implicit cursor plane usage
Date: Wed, 27 Mar 2019 09:28:15 +0100 [thread overview]
Message-ID: <20190327092815.59500dae@collabora.com> (raw)
In-Reply-To: <20190228141918.26043-6-daniel.vetter@ffwll.ch>
On Thu, 28 Feb 2019 15:19:15 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Figured I'll only test the SetCursor interface since in the kernel
> it's all the same anyway, it's just libdrm that splits it up.
>
> Current kernels fail this.
>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> tests/kms_lease.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index c11d37aeac7a..7930d0737ace 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -431,6 +431,42 @@ static void setcrtc_implicit_plane(data_t *data)
> connector_id_to_output(&data->master.display, data->connector_id));
> }
>
> +static void cursor_implicit_plane(data_t *data)
> +{
> + uint32_t object_ids[3];
> + struct local_drm_mode_create_lease mcl;
> +
> + mcl.object_ids = (uint64_t) (uintptr_t) &object_ids[0];
> + mcl.object_count = 0;
> + mcl.flags = 0;
> +
> + object_ids[mcl.object_count++] = data->connector_id;
> + object_ids[mcl.object_count++] = data->crtc_id;
> +
> + drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 0);
> + do_or_die(create_lease(data->master.fd, &mcl));
> + drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> +
> + /* Set a mode on the leased output */
> + igt_assert_eq(0, prepare_crtc(&data->master, data->connector_id, data->crtc_id));
> +
> + /* sanity check */
> + do_or_die(drmModeSetCursor(data->master.fd, data->crtc_id, 0, 0, 0));
> + do_or_die(drmModeSetCursor(mcl.fd, data->crtc_id, 0, 0, 0));
> + close(mcl.fd);
> +
> + /* primary plane is never the cursor */
> + object_ids[mcl.object_count++] = data->plane_id;
> + do_or_die(create_lease(data->master.fd, &mcl));
> +
> + igt_assert_eq(drmModeSetCursor(mcl.fd, data->crtc_id, 0, 0, 0),
> + -EACCES);
> + close(mcl.fd);
> +
> + cleanup_crtc(&data->master,
> + connector_id_to_output(&data->master.display, data->connector_id));
> +}
> +
> /* Test listing lessees */
> static void lessee_list(data_t *data)
> {
> @@ -1146,6 +1182,7 @@ igt_main
> { "lease_invalid_plane", lease_invalid_plane },
> { "page_flip_implicit_plane", page_flip_implicit_plane },
> { "setcrtc_implicit_plane", setcrtc_implicit_plane },
> + { "cursor_implicit_plane", cursor_implicit_plane },
> { }
> }, *f;
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-27 8:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 14:19 [igt-dev] [PATCH i-g-t 1/9] tests/kms_addfb_basic: Check that only the owner can rmfb Daniel Vetter
2019-02-28 14:19 ` [igt-dev] [PATCH i-g-t 2/9] tests:core_prop_blob: Drop local_ prefixes Daniel Vetter
2019-02-28 14:29 ` Ville Syrjälä
2019-02-28 14:19 ` [igt-dev] [PATCH i-g-t 3/9] tests: s/core_prop_blob/kms_prop_blob Daniel Vetter
2019-02-28 14:30 ` Ville Syrjälä
2019-02-28 14:19 ` [igt-dev] [PATCH i-g-t 4/9] tests/kms_lease: test implicit primary plane usage in page_flip ioctl Daniel Vetter
2019-03-27 8:04 ` Boris Brezillon
2019-02-28 14:19 ` [igt-dev] [PATCH i-g-t 5/9] tests/kms_lease: test implicit primary plane usage in setcrtc ioctl Daniel Vetter
2019-03-27 8:26 ` Boris Brezillon
2019-03-27 9:21 ` Daniel Vetter
2019-03-27 10:10 ` Boris Brezillon
2019-03-27 12:14 ` Daniel Vetter
2019-02-28 14:19 ` [igt-dev] [PATCH i-g-t 6/9] tests/kms_lease: test implicit cursor plane usage Daniel Vetter
2019-03-27 8:28 ` Boris Brezillon [this message]
2019-02-28 14:19 ` [igt-dev] [PATCH i-g-t 7/9] tests/kms_lease: Adjust to kernel errno changes Daniel Vetter
2019-03-27 8:29 ` Boris Brezillon
2019-02-28 14:19 ` [igt-dev] [PATCH i-g-t 8/9] tests/kms_lease: Handle new errno from idr/xa double insert Daniel Vetter
2019-03-27 8:30 ` Boris Brezillon
2019-02-28 14:19 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: Check crtc used in atomic ioctl Daniel Vetter
2019-03-27 8:38 ` Boris Brezillon
2019-03-27 9:23 ` Daniel Vetter
2019-02-28 14:29 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_addfb_basic: Check that only the owner can rmfb Ville Syrjälä
2019-02-28 14:36 ` Chris Wilson
2019-02-28 15:44 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] " Patchwork
2019-02-28 18:05 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-28 9:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327092815.59500dae@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox