From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E3A46E152 for ; Wed, 27 Mar 2019 10:10:24 +0000 (UTC) Date: Wed, 27 Mar 2019 11:10:18 +0100 From: Boris Brezillon Message-ID: <20190327111018.0dbf2f9e@collabora.com> In-Reply-To: <20190327092115.GW2665@phenom.ffwll.local> References: <20190228141918.26043-1-daniel.vetter@ffwll.ch> <20190228141918.26043-5-daniel.vetter@ffwll.ch> <20190327092623.2258f092@collabora.com> <20190327092115.GW2665@phenom.ffwll.local> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 5/9] tests/kms_lease: test implicit primary plane usage in setcrtc ioctl List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Vetter Cc: IGT development , Keith Packard , Daniel Vetter List-ID: T24gV2VkLCAyNyBNYXIgMjAxOSAxMDoyMToxNSArMDEwMApEYW5pZWwgVmV0dGVyIDxkYW5pZWxA ZmZ3bGwuY2g+IHdyb3RlOgoKPiBPbiBXZWQsIE1hciAyNywgMjAxOSBhdCAwOToyNjoyM0FNICsw MTAwLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gPiBPbiBUaHUsIDI4IEZlYiAyMDE5IDE1OjE5 OjE0ICswMTAwCj4gPiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPiB3cm90 ZToKPiA+ICAgCj4gPiA+IEFnYWluIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgYSBsZWFzZSBj YW4ndCB1c2UgcGxhbmVzIGl0J3Mgbm90Cj4gPiA+IGFsbG93ZWQgdG8gdGhyb3VnaCBsZWdhY3kg aW9jdGxzLiBTZXRDcnRjIGlzIGEgYml0IG1vcmUgdHJpY2t5LCBzaW5jZSAgCj4gPiAKPiA+IAkg IF4gInRvIHVzZSB0aHJvdWdoIj8gIAo+IAo+IFl1cC4KPiAKPiA+ICAgCj4gPiA+IHdlIHNob3Vs ZCBzdGlsbCBhbGxvdyB0byBzaHV0IGRvd24gYSBDUlRDLCBlLmcuIHdoZW4gd2UncmUgYWxsb3dl ZCB0bwo+ID4gPiB1c2Ugb3RoZXIgcGxhbmVzIG9uIHRoYXQgQ1JUQy4KPiA+ID4gCj4gPiA+IEN1 cnJlbnQga2VybmVscyBmYWlsIHRoaXMuCj4gPiA+IAo+ID4gPiBDYzogS2VpdGggUGFja2FyZCA8 a2VpdGhwQGtlaXRocC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIHRlc3RzL2ttc19sZWFzZS5j IHwgNjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDYwIGluc2VydGlvbnMoKykKPiA+ID4gCj4gPiA+ IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfbGVhc2UuYyBiL3Rlc3RzL2ttc19sZWFzZS5jCj4gPiA+ IGluZGV4IDY0NTNjN2JlYWZkOC4uYzExZDM3YWVhYzdhIDEwMDY0NAo+ID4gPiAtLS0gYS90ZXN0 cy9rbXNfbGVhc2UuYwo+ID4gPiArKysgYi90ZXN0cy9rbXNfbGVhc2UuYwo+ID4gPiBAQCAtMzcy LDYgKzM3Miw2NSBAQCBzdGF0aWMgdm9pZCBwYWdlX2ZsaXBfaW1wbGljaXRfcGxhbmUoZGF0YV90 ICpkYXRhKQo+ID4gPiAgCQkgICAgIGNvbm5lY3Rvcl9pZF90b19vdXRwdXQoJmRhdGEtPm1hc3Rl ci5kaXNwbGF5LCBkYXRhLT5jb25uZWN0b3JfaWQpKTsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAr c3RhdGljIHZvaWQgc2V0Y3J0Y19pbXBsaWNpdF9wbGFuZShkYXRhX3QgKmRhdGEpCj4gPiA+ICt7 Cj4gPiA+ICsJdWludDMyX3Qgb2JqZWN0X2lkc1szXTsKPiA+ID4gKwlzdHJ1Y3QgbG9jYWxfZHJt X21vZGVfY3JlYXRlX2xlYXNlIG1jbDsKPiA+ID4gKwlkcm1Nb2RlUGxhbmVSZXMgKnBsYW5lX3Jl c291cmNlczsKPiA+ID4gKwl1aW50MzJfdCB3cm9uZ19wbGFuZV9pZCA9IDA7Cj4gPiA+ICsJaWd0 X291dHB1dF90ICpvdXRwdXQgPQo+ID4gPiArCQljb25uZWN0b3JfaWRfdG9fb3V0cHV0KCZkYXRh LT5tYXN0ZXIuZGlzcGxheSwKPiA+ID4gKwkJCQkgICAgICAgZGF0YS0+Y29ubmVjdG9yX2lkKTsK PiA+ID4gKwlkcm1Nb2RlTW9kZUluZm8gKm1vZGUgPSBpZ3Rfb3V0cHV0X2dldF9tb2RlKG91dHB1 dCk7Cj4gPiA+ICsJaW50IGk7Cj4gPiA+ICsKPiA+ID4gKwkvKiBmaW5kIGEgcGxhbmUgd2hpY2gg aXNuJ3QgdGhlIHByaW1hcnkgb25lIGZvciB1cyAqLwo+ID4gPiArCXBsYW5lX3Jlc291cmNlcyA9 IGRybU1vZGVHZXRQbGFuZVJlc291cmNlcyhkYXRhLT5tYXN0ZXIuZmQpOwo+ID4gPiArCWZvciAo aSA9IDA7IGkgPCBwbGFuZV9yZXNvdXJjZXMtPmNvdW50X3BsYW5lczsgaSsrKSB7Cj4gPiA+ICsJ CWlmIChwbGFuZV9yZXNvdXJjZXMtPnBsYW5lc1tpXSAhPSBkYXRhLT5wbGFuZV9pZCkgewo+ID4g PiArCQkJd3JvbmdfcGxhbmVfaWQgPSBwbGFuZV9yZXNvdXJjZXMtPnBsYW5lc1tpXTsKPiA+ID4g KwkJCWJyZWFrOwo+ID4gPiArCQl9Cj4gPiA+ICsJfQo+ID4gPiArCWRybU1vZGVGcmVlUGxhbmVS ZXNvdXJjZXMocGxhbmVfcmVzb3VyY2VzKTsKPiA+ID4gKwlpZ3RfcmVxdWlyZSh3cm9uZ19wbGFu ZV9pZCk7ICAKPiA+IAo+ID4gTWF5YmUgd2UgY291bGQgYWRkIGFuIGhlbHBlciB0byByZXRyaWV2 ZSB3cm9uZ19wbGFuZV9pZCBpbnN0ZWFkIG9mCj4gPiBkdXBsaWNhdGluZyB0aGUgY29kZS4gIAo+ IAo+IEhtLCB3aGVyZSBpcyBpdCBkdXBsaWNhdGVkPyBUaGUgb3RoZXIgdmVyeSBzaW1pbGFyIGxv b3AgbG9va3MgZm9yIHRoZQo+IHdvcm5nIGNvbm5lY3RvciwgYW5kIHRoZXJlJ3MgYSBmZXcgb3Ro ZXIgbG9vcHMgdG8gbG9vayBmb3IgdGhlIHJpZ2h0Cj4gcGxhbmUvY29ubmVjdG9yLiBJIHRoaW5r IHRoZXkncmUgYWxsIGRpZmZlcmVudC4KPiA+ICAgCj4gPiA+ICsKPiA+ID4gKwltY2wub2JqZWN0 X2lkcyA9ICh1aW50NjRfdCkgKHVpbnRwdHJfdCkgJm9iamVjdF9pZHNbMF07Cj4gPiA+ICsJbWNs Lm9iamVjdF9jb3VudCA9IDA7Cj4gPiA+ICsJbWNsLmZsYWdzID0gMDsKPiA+ID4gKwo+ID4gPiAr CW9iamVjdF9pZHNbbWNsLm9iamVjdF9jb3VudCsrXSA9IGRhdGEtPmNvbm5lY3Rvcl9pZDsKPiA+ ID4gKwlvYmplY3RfaWRzW21jbC5vYmplY3RfY291bnQrK10gPSBkYXRhLT5jcnRjX2lkOwo+ID4g PiArCj4gPiA+ICsJZHJtU2V0Q2xpZW50Q2FwKGRhdGEtPm1hc3Rlci5mZCwgRFJNX0NMSUVOVF9D QVBfVU5JVkVSU0FMX1BMQU5FUywgMCk7Cj4gPiA+ICsJZG9fb3JfZGllKGNyZWF0ZV9sZWFzZShk YXRhLT5tYXN0ZXIuZmQsICZtY2wpKTsKPiA+ID4gKwlkcm1TZXRDbGllbnRDYXAoZGF0YS0+bWFz dGVyLmZkLCBEUk1fQ0xJRU5UX0NBUF9VTklWRVJTQUxfUExBTkVTLCAxKTsKPiA+ID4gKwo+ID4g PiArCS8qIFNldCBhIG1vZGUgb24gdGhlIGxlYXNlZCBvdXRwdXQgKi8KPiA+ID4gKwlpZ3RfYXNz ZXJ0X2VxKDAsIHByZXBhcmVfY3J0YygmZGF0YS0+bWFzdGVyLCBkYXRhLT5jb25uZWN0b3JfaWQs IGRhdGEtPmNydGNfaWQpKTsgIAo+ID4gCj4gPiBTYW1lIGdvZXMgZm9yIHRob3NlIGNyZWF0ZS1s ZWFzZStwcmVwYXJlLUNSVEMgc3RlcHMuICAKPiAKPiBUaGVyZSdzIGEgaGVscGVyIGZvciB0aGUg Y29tbW9uIGNhc2UsIGJ1dCBmb3IgdGhlc2UgIndyb25nIiBsZWFzZXMgdGhlcmUncwo+IGFsd2F5 cyBzdWJ0bGUgZGlmZmVyZW5jZXMuIEEgaGVscGVyIHdvdWxkIGJlIGJlIGFib3V0IGFzIG11Y2gg Y29kZSBhcyBqdXN0Cj4gb3Blbi1jb2RpbmcgaXQuIE1heWJlIHdlIGNvdWxkIG1vdmUgdGhlIFVO SVZFUlNBTF9QTEFORVMgYXMgYSBtb2RlIGZsYWcKPiBpbnRvIGNyZWF0ZV9sZWFzZSwgYnV0IGdp dmVuIGhvdyBvZnRlbiBJIHNjcmVhbWVkIGF0IG15IHRlc3RzIGZvciBub3QKPiB3b3JraW5nIGJl Y2F1c2UgSSBnb3QgdGhhdCBvbmUgd3JvbmcsIEkgdGhpbmsgaXQncyBiZXR0ZXIgdG8gYmUgZXhw bGljaXQuCj4gPiAgIAo+ID4gPiArCj4gPiA+ICsJLyogc2FuaXR5IGNoZWNrICovCj4gPiA+ICsJ ZG9fb3JfZGllKGRybU1vZGVTZXRDcnRjKGRhdGEtPm1hc3Rlci5mZCwgZGF0YS0+Y3J0Y19pZCwg LTEsCj4gPiA+ICsJCQkJIDAsIDAsIG9iamVjdF9pZHMsIDEsIG1vZGUpKTsKPiA+ID4gKwlkb19v cl9kaWUoZHJtTW9kZVNldENydGMobWNsLmZkLCBkYXRhLT5jcnRjX2lkLCAtMSwKPiA+ID4gKwkJ CQkgMCwgMCwgb2JqZWN0X2lkcywgMSwgbW9kZSkpOwo+ID4gPiArCWNsb3NlKG1jbC5mZCk7Cj4g PiA+ICsKPiA+ID4gKwlvYmplY3RfaWRzW21jbC5vYmplY3RfY291bnQrK10gPSB3cm9uZ19wbGFu ZV9pZDsKPiA+ID4gKwlkb19vcl9kaWUoY3JlYXRlX2xlYXNlKGRhdGEtPm1hc3Rlci5mZCwgJm1j bCkpOwo+ID4gPiArCj4gPiA+ICsJaWd0X2Fzc2VydF9lcShkcm1Nb2RlU2V0Q3J0YyhtY2wuZmQs IGRhdGEtPmNydGNfaWQsIC0xLAo+ID4gPiArCQkJCSAgICAgMCwgMCwgb2JqZWN0X2lkcywgMSwg bW9kZSksCj4gPiA+ICsJCSAgICAgIC1FQUNDRVMpOwo+ID4gPiArCS8qIG1ha2Ugc3VyZSB3ZSBh cmUgYWxsb3dlZCB0byB0dXJuIHRoZSBDUlRDIG9mZiAqLwo+ID4gPiArCWRvX29yX2RpZShkcm1N b2RlU2V0Q3J0YyhtY2wuZmQsIGRhdGEtPmNydGNfaWQsCj4gPiA+ICsJCQkJIDAsIDAsIDAsIE5V TEwsIDAsIE5VTEwpKTsgIAo+ID4gCj4gPiBEbyB3ZSBhY3R1YWxseSB0ZXN0IHRoZSBjYXNlIHdo ZXJlIHRoZSBsZXNzb3IgaGFzIHNldHVwIHRoZSBDUlRDIHdpdGggYQo+ID4gcGxhbmUgdGhhdCdz IG5vdCBhY2Nlc3NpYmxlIGJ5IHRoZSBsZXNzZS4gSSB0aGluayB0aGF0J3Mgd2hhdCB5b3Ugd2Vy ZQo+ID4gdHJ5aW5nIHRvIHRlc3QgaGVyZSwgYnV0IEkgZG9uJ3Qgc2VlIHdoZXJlIGl0J3MgZG9u ZSBpbiB0aGUgY29kZS4KPiA+IFNob3VsZG4ndCB3ZSBoYXZlIHNvbWV0aGluZyBsaWtlOgo+ID4g Cj4gPiAJZG9fb3JfZGllKGRybU1vZGVTZXRDcnRjKGRhdGEtPm1hc3Rlci5mZCwgZGF0YS0+Y3J0 Y19pZCwgLTEsCj4gPiAJCQkJIDAsIDAsIG9iamVjdF9pZHMsIDEsIG1vZGUpKTsgIAo+IAo+IFNh bml0eSBjaGVjayBhYm92ZSBkb2VzIGV4YWN0bHkgdGhhdC4KClllcywgYnV0IHdyb25nX3BsYW5l X2lkIGlzIG5vdCBwYXJ0IG9mIHRoZSBvYmplY3QgbGlzdCBpbiB5b3VyIHNhbml0eQpjaGVjaywg aXMgaXQ/Cgo+IAo+ID4gCWlndF9hc3NlcnRfZXEoMCwgZHJtTW9kZVNldENydGMobWNsLmZkLCBk YXRhLT5jcnRjX2lkLCAwLCAwLCAwLAo+ID4gCQkJCQlOVUxMLCAwLCBOVUxMKSk7ICAKPiAKPiBU aGF0J3MgdGhlIGxpbmUgcmlnaHQgYWJvdmUgd3JhcHBlZCBpbiB0aGUgZG9fb3JfZGllLgoKQXJl IHlvdSBzdXJlIHdyb25nX3BsYW5lX2lkIHdhcyBlbmFibGVkIHdoZW4geW91IGNhbGwgZHJtTW9k ZVNldENydGMoKQp0byBkaXNhYmxlIHRoZSBDUlRDPyBJZiBpdCB3YXNuJ3QsIHRoYXQgbWVhbnMg eW91J3JlIG5vdCByZWFsbHkgdGVzdGluZwp0aGUgJ2Rpc2FibGUgQ1JUQyBldmVuIGlmIG90aGVy IHBsYW5lcyBJIGRvbid0IG93biBhcmUgc3RpbGwgYXR0YWNoZWQgdG8KaXQnLiBCdXQgSSdtIHBy b2JhYmx5IG1pc3Npbmcgc29tZXRoaW5nLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2lndC1kZXY=