Re: [igt-dev] [PATCH i-g-t] runner: Make taint aborts more verbose

[Petri Latvala <petri.latvala@intel.com>]

On Mon, Nov 26, 2018 at 02:22:00PM +0200, Petri Latvala wrote:
> On Mon, Nov 26, 2018 at 12:36:44PM +0200, Arkadiusz Hiler wrote:
> > On Mon, Nov 26, 2018 at 09:12:46AM +0000, Chris Wilson wrote:
> > > Quoting Arkadiusz Hiler (2018-11-26 08:52:22)
> > > > Provide the reader with the taint names and a short explanation, as well
> > > > as point in the direction of the dmesg for more details.
> > > > 
> > > > Cc: Petri Latvala <petri.latvala@intel.com>
> > > > Cc: Martin Peres <martin.peres@linux.intel.com>
> > > > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > > > ---
> > > >  runner/executor.c | 42 ++++++++++++++++++++++++++++++++----------
> > > >  1 file changed, 32 insertions(+), 10 deletions(-)
> > > > 
> > > > diff --git a/runner/executor.c b/runner/executor.c
> > > > index 2038c3fd..954cd9a7 100644
> > > > --- a/runner/executor.c
> > > > +++ b/runner/executor.c
> > > > @@ -139,24 +139,46 @@ static char *handle_lockdep(void)
> > > >  
> > > >  static char *handle_taint(void)
> > > >  {
> > > > -       const unsigned long bad_taints =
> > > > -               0x20  | /* TAINT_PAGE */
> > > > -               0x80  | /* TAINT_DIE */
> > > > -               0x200; /* TAINT_OOPS */
> > > > -       unsigned long taints = 0;
> > > > +       /* see Linux's include/linux/kernel.h */
> > > > +       static const struct {
> > > > +               unsigned long bit;
> > > > +               const char *explanation;
> > > > +       } taints[] = {
> > > > +         {(1 << 5), "TAINT_BAD_PAGE: Bad page reference or an unexpected page flags."},
> > > > +         {(1 << 7), "TAINT_DIE: Kernel has died - BUG/OOPS."},
> > > > +         {(1 << 9), "TAINT_WARN: WARN_ON has happened."},
> > > 
> > > Pure noise, these don't add any useful information, so why? The only
> > > information is the explanation in dmesg. Checking tainted is just
> > > shorthand for us to determine a significant event.
> > 
> > People not knowing what taint means (or that it is a "bit field") were
> > getting confused by those aborts. I just got tired of explaining that we
> > don't check for "unsafe module option taint" which is usually the first
> > result they get while greping dmesg for "taint".
> 
> 
> Yeah this has been causing confusion in all kinds of circles.
> 
> In general it's always better to explain numbers in outputs meant for
> humans. Surely if people ask about stuff, adding explanations to it is
> useful information by definition?


We've had too many questions about the aborts right about now.

Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev