public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 8/8] tests/fbcon_fbt: Do not keep opening debugfs_fd at every setup_drm() call
Date: Wed, 27 Mar 2019 13:03:31 -0700	[thread overview]
Message-ID: <20190327200331.28602-8-jose.souza@intel.com> (raw)
In-Reply-To: <20190327200331.28602-1-jose.souza@intel.com>

As debugfs_fd is used even after the teardown_drm() call, it do not
closes it causing it to open another debugfs_fd at every call to
setup_drm().
Let move the opening of debugfs_fd to setup_environment() and only
open it once, also lets close it before leave the test.

Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/kms_fbcon_fbt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index 66f214c5..f7ff671b 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -64,7 +64,6 @@ static void setup_drm(struct drm_info *drm)
 		return;
 
 	drm->fd = drm_open_driver_master(DRIVER_INTEL);
-	drm->debugfs_fd = igt_debugfs_dir(drm->fd);
 
 	drm->res = drmModeGetResources(drm->fd);
 	igt_require(drm->res);
@@ -295,6 +294,7 @@ static void setup_environment(struct drm_info *drm)
 
 	drm_fd = drm_open_driver_master(DRIVER_INTEL);
 	igt_require(drm_fd >= 0);
+	drm->debugfs_fd = igt_debugfs_dir(drm_fd);
 	igt_assert(close(drm_fd) == 0);
 
 	/*
@@ -311,6 +311,8 @@ static void teardown_environment(struct drm_info *drm)
 {
 	if (drm->fd >= 0)
 		teardown_drm(drm);
+
+	close(drm->debugfs_fd);
 }
 
 igt_main
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-03-27 20:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 20:03 [igt-dev] [PATCH i-g-t v2 1/8] tests/fbcon_fbt: Use psr_wait_entry() to wait PSR be enabled José Roberto de Souza
2019-03-27 20:03 ` [igt-dev] [PATCH i-g-t v2 2/8] tests/fbcon_fbt: Allow fbcon to bind when running this test José Roberto de Souza
2019-03-27 20:03 ` [igt-dev] [PATCH i-g-t v2 3/8] tests/fbcon_fbt: Add wait_until_update() callback to features José Roberto de Souza
2019-04-09 21:41   ` Dhinakaran Pandiyan
2019-04-10 20:31     ` Souza, Jose
2019-04-10 20:42       ` Pandiyan, Dhinakaran
2019-04-10 22:04         ` Souza, Jose
2019-03-27 20:03 ` [igt-dev] [PATCH i-g-t v2 4/8] tests/fbcon_fbt: Use psr_wait_update() to test updates in PSR José Roberto de Souza
2019-03-27 20:03 ` [igt-dev] [PATCH i-g-t v2 5/8] tests/fbcon_fbt: Add and use psr_long_wait_update() " José Roberto de Souza
2019-04-09 17:55   ` Maarten Lankhorst
2019-04-10 21:08     ` Souza, Jose
2019-03-27 20:03 ` [igt-dev] [PATCH i-g-t v2 6/8] tests/fbcon_fbt: Enable cursor blinking José Roberto de Souza
2019-04-09 17:59   ` Maarten Lankhorst
2019-03-27 20:03 ` [igt-dev] [PATCH i-g-t v2 7/8] tests/fbcon_fbt: Do not try to open the same driver twice as master José Roberto de Souza
2019-04-09 17:55   ` Maarten Lankhorst
2019-04-10 21:07     ` Souza, Jose
2019-03-27 20:03 ` José Roberto de Souza [this message]
2019-04-09 18:01   ` [igt-dev] [PATCH i-g-t v2 8/8] tests/fbcon_fbt: Do not keep opening debugfs_fd at every setup_drm() call Maarten Lankhorst
2019-03-27 21:01 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/8] tests/fbcon_fbt: Use psr_wait_entry() to wait PSR be enabled Patchwork
2019-03-28 17:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190327200331.28602-8-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox