From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 445106E335 for ; Thu, 28 Mar 2019 09:12:00 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id v21so16519512edq.4 for ; Thu, 28 Mar 2019 02:12:00 -0700 (PDT) Date: Thu, 28 Mar 2019 10:11:56 +0100 From: Daniel Vetter Message-ID: <20190328091156.GW2665@phenom.ffwll.local> References: <20190315150442.10237-1-nicholas.kazlauskas@amd.com> <20190315150442.10237-2-nicholas.kazlauskas@amd.com> <974428ef-cafe-6897-cfd8-e77d5e0fae2c@amd.com> <70caeba3-f023-bb42-860d-535f50fc44ae@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70caeba3-f023-bb42-860d-535f50fc44ae@amd.com> Subject: Re: [igt-dev] [PATCH i-g-t v2 2/3] lib/debugfs: Don't do CRC sanity checks on amdgpu List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Kazlauskas, Nicholas" Cc: "igt-dev@lists.freedesktop.org" List-ID: T24gV2VkLCBNYXIgMjcsIDIwMTkgYXQgMDU6MTc6MjFQTSArMDAwMCwgS2F6bGF1c2thcywgTmlj aG9sYXMgd3JvdGU6Cj4gT24gMy8yNy8xOSAxOjA5IFBNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ ID4gT24gV2VkLCBNYXIgMjcsIDIwMTkgYXQgNDoxMSBQTSBXZW50bGFuZCwgSGFycnkgPEhhcnJ5 LldlbnRsYW5kQGFtZC5jb20+IHdyb3RlOgo+ID4+Cj4gPj4KPiA+Pgo+ID4+IE9uIDIwMTktMDMt MTUgMTE6MDQgYS5tLiwgTmljaG9sYXMgS2F6bGF1c2thcyB3cm90ZToKPiA+Pj4gQSBibGFjayBG QiBvbiBhbWRncHUgcmV0dXJucyBhIENSQyBvZiAoMCwgMCwgMCksIHdoaWNoIElHVCBjb25zaWRl cnMKPiA+Pj4gc3VzcGljaW91cy4gQWxsIG91ciBDUkMgdmFsdWVzIGFyZSBhbHNvIDE2LWJpdCBz byBhIHZhbHVlIG9mIDB4ZmZmZmZmZmYKPiA+Pj4gY2FuJ3QgYmUgb2J0YWluZWQuCj4gPj4+Cj4g Pj4+IERyb3AgdGhlIHN1c3BpY2lvdXMgQ1JDIGNoZWNrcyBvbiBhbWRncHUgYnkgY2hlY2tpbmcg dGhlIGRldmljZSBpbgo+ID4+PiBjcmNfc2FuaXR5X2NoZWNrcy4gV2UgbmVlZCB0aGUgZHJtX2Zk IGZvciB0aGlzIHNvIHBhc3MgaW4gcGlwZV9jcmMKPiA+Pj4gdG8gdGhlIGZ1bmN0aW9uIHRvIGdl dCBpdC4gSXQgbWFrZXMgbW9yZSBzZW5zZSB0byBtZSB0byBkbyBpdCB0aGlzCj4gPj4+IHdheSB0 aGFuIHRvIGR1cGxpY2F0ZSBjb2RlIGFuZCB0aGUgZXhwbGFuYXRpb24gb24gYm90aCBjYWxscyB0 bwo+ID4+PiBjcmNfc2FuaXR5X2NoZWNrcy4KPiA+Pj4KPiA+Pj4gdjI6IHJlYmFzZQo+ID4+Pgo+ ID4+PiBDYzogTGVvIExpIDxzdW5wZW5nLmxpQGFtZC5jb20+Cj4gPj4+IENjOiBIYXJyeSBXZW50 bGFuZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4KPiA+Pj4gU2lnbmVkLW9mZi1ieTogTmljaG9s YXMgS2F6bGF1c2thcyA8bmljaG9sYXMua2F6bGF1c2thc0BhbWQuY29tPgo+ID4+Cj4gPj4gUmV2 aWV3ZWQtYnk6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29tPgo+ID4gCj4g PiBIbSwgSSB0aGluayBzaW1wbGVyIHRvIGp1c3QgZHJvcCB0aGlzIHRlc3QgZW50aXJlbHkuIEl0 J3Mga2luZGEgYm9ndXMuCj4gPiBPciBhdCBsZWFzdCBoYXZlIHRoZSBzYW5pdHkgY2hlY2sgb25s eSBmb3IgdGhlIGttc19waXBlX2NyY19iYXNpYwo+ID4gdGVzdGNhc2VzLiBCdXQgSSBndWVzcyB0 aGlzIHdvcmtzIHRvby4KPiA+IC1EYW5pZWwKPiBJc24ndCBpdCBzdGlsbCB1c2VmdWwgdG8ga2Vl cCB0aGlzIGFyb3VuZCBmb3Igb3RoZXIgdGVzdHMgb24gaTkxNT8gU2luY2UgCj4gdGhvc2Ugc3Bl Y2lhbCBjb2RlcyBjb3VsZCBoYXBwZW4gYW55d2hlcmUgZnJvbSBteSB1bmRlcnN0YW5kaW5nLgo+ IAo+IE5vdCBzdXJlIGlmIHRoZXNlIGFyZSByZWFsbHkgdXNlZnVsIGZvciBhbnkgb3RoZXIgZHJp dmVycywgYnV0IEkgZmlndXJlZCAKPiBpdCB3YXMgZWFzaWVyIHRvIGp1c3QgbWFrZSBhbiBleGNl cHRpb24gaW4gdGhpcyBjYXNlIGZvciBhbWRncHUgc2luY2UgCj4gdGhlIHRlc3RzIGFyZSBleHBs aWNpdGx5IGJvZ3VzIG9uIGl0LgoKSXQgZXNzZW50aWFsbHkgdGVzdHMgZm9yICJkaWQgd2UgbmV2 ZXIgcmVjb3JkIGEgY3JjIGFuZCBpdCdzIHN0aWxsIGFsbCAwIgphbmQgImhhcyB0aGUgaHcgZGll ZCBhbmQgcmV0dXJucyBhbGwgMXMiLiBCdXQgdGhvc2UgdmFsdWVzIGNhbiBoYXBwZW4gdG9vLApz byBJJ20gbm90IHN1cmUgaXQncyBhbGwgdGhhdCB1c2VmdWwgcmVhbGx5IGV2ZW4gb24gaTkxNS4K CkV4Y2VwdCBtYXliZSBpbiB0aGUgYmFzaWMgImRvIG91ciBjcmNzIHByb2R1Y2UgdXNlZnVsIGRh dGEiIHRlc3RjYXNlLCBhbmQKdGhlcmUgd2UgY291bGQgcGVyaGFwcyBkbyBhbiBleHBsaWNpdCBp ZiAoaW50ZWwpIHsgY3JjIHNhbml0eSBjaGVja3MgZm9yCmk5MTUgKSBsb2dpYy4KCkp1c3QgYSBk cml2ZS1ieSBpZGVhIHJlYWxseS4KLURhbmllbAo+IAo+IE5pY2hvbGFzIEthemxhdXNrYXMKPiAK PiA+IAo+ID4+Cj4gPj4gSGFycnkKPiA+Pgo+ID4+PiAtLS0KPiA+Pj4gICBsaWIvaWd0X2RlYnVn ZnMuYyB8IDEwICsrKysrKystLS0KPiA+Pj4gICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQo+ID4+Pgo+ID4+PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9kZWJ1 Z2ZzLmMgYi9saWIvaWd0X2RlYnVnZnMuYwo+ID4+PiBpbmRleCA3ODQ5ZmFhZC4uZGQyMjljMDkg MTAwNjQ0Cj4gPj4+IC0tLSBhL2xpYi9pZ3RfZGVidWdmcy5jCj4gPj4+ICsrKyBiL2xpYi9pZ3Rf ZGVidWdmcy5jCj4gPj4+IEBAIC04NzIsMTEgKzg3MiwxNSBAQCBpZ3RfcGlwZV9jcmNfZ2V0X2Ny Y3MoaWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjLCBpbnQgbl9jcmNzLAo+ID4+PiAgICAgICAgcmV0 dXJuIG47Cj4gPj4+ICAgfQo+ID4+Pgo+ID4+PiAtc3RhdGljIHZvaWQgY3JjX3Nhbml0eV9jaGVj a3MoaWd0X2NyY190ICpjcmMpCj4gPj4+ICtzdGF0aWMgdm9pZCBjcmNfc2FuaXR5X2NoZWNrcyhp Z3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqY3JjKQo+ID4+PiAgIHsKPiA+Pj4g ICAgICAgIGludCBpOwo+ID4+PiAgICAgICAgYm9vbCBhbGxfemVybyA9IHRydWU7Cj4gPj4+Cj4g Pj4+ICsgICAgIC8qIEFueSBDUkMgdmFsdWUgY2FuIGJlIGNvbnNpZGVyZWQgdmFsaWQgb24gYW1k Z3B1IGhhcmR3YXJlLiAqLwo+ID4+PiArICAgICBpZiAoaXNfYW1kZ3B1X2RldmljZShwaXBlX2Ny Yy0+ZmQpKQo+ID4+PiArICAgICAgICAgICAgIHJldHVybjsKPiA+Pj4gKwo+ID4+PiAgICAgICAg Zm9yIChpID0gMDsgaSA8IGNyYy0+bl93b3JkczsgaSsrKSB7Cj4gPj4+ICAgICAgICAgICAgICAg IGlndF93YXJuX29uX2YoY3JjLT5jcmNbaV0gPT0gMHhmZmZmZmZmZiwKPiA+Pj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiU3VzcGljaW91cyBDUkM6IGl0IGxvb2tzIGxpa2UgdGhlIENS QyAiCj4gPj4+IEBAIC05MzAsNyArOTM0LDcgQEAgdm9pZCBpZ3RfcGlwZV9jcmNfZ2V0X3Npbmds ZShpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqY3JjKQo+ID4+PiAgIHsKPiA+ Pj4gICAgICAgIHJlYWRfb25lX2NyYyhwaXBlX2NyYywgY3JjKTsKPiA+Pj4KPiA+Pj4gLSAgICAg Y3JjX3Nhbml0eV9jaGVja3MoY3JjKTsKPiA+Pj4gKyAgICAgY3JjX3Nhbml0eV9jaGVja3MocGlw ZV9jcmMsIGNyYyk7Cj4gPj4+ICAgfQo+ID4+Pgo+ID4+PiAgIC8qKgo+ID4+PiBAQCAtOTU5LDcg Kzk2Myw3IEBAIGlndF9waXBlX2NyY19nZXRfY3VycmVudChpbnQgZHJtX2ZkLCBpZ3RfcGlwZV9j cmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqY3JjKQo+ID4+PiAgICAgICAgICAgICAgICB9Cj4g Pj4+ICAgICAgICB9IHdoaWxlIChpZ3RfdmJsYW5rX2JlZm9yZV9lcShjcmMtPmZyYW1lLCB2Ymxh bmspKTsKPiA+Pj4KPiA+Pj4gLSAgICAgY3JjX3Nhbml0eV9jaGVja3MoY3JjKTsKPiA+Pj4gKyAg ICAgY3JjX3Nhbml0eV9jaGVja3MocGlwZV9jcmMsIGNyYyk7Cj4gPj4+ICAgfQo+ID4+Pgo+ID4+ PiAgIC8qKgo+ID4+Pgo+ID4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gPj4gaWd0LWRldiBtYWlsaW5nIGxpc3QKPiA+PiBpZ3QtZGV2QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+ID4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaWd0LWRldgo+ID4gCj4gPiAKPiA+IAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFp bGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==