Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_kms: Clear pipe color management properties on reset.

Ville Syrjälä
2019-03-29T10:40:17Z

On Fri, Mar 29, 2019 at 11:35:25AM +0100, Maarten Lankhorst wrote:
> Just like we try to sanitize all properties in igt_plane_reset, we
> should do the same for pipe properties. Loading a wrong lut could
> affect passing and failing tests, so we need to be careful and set
> sane defaults for everything.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
> lib/igt_kms.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 43f45997073c..05cb9bd22090 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1804,6 +1804,15 @@ static void igt_pipe_reset(igt_pipe_t *pipe)
> igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_ACTIVE, 0);
> igt_pipe_obj_clear_prop_changed(pipe, IGT_CRTC_OUT_FENCE_PTR);
>
> + if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM))
> + igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_CTM, 0);
> +
> + if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_GAMMA_LUT))
> + igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_GAMMA_LUT, 0);
> +
> + if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_DEGAMMA_LUT))
> + igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_DEGAMMA_LUT, 0);
> +
> pipe->out_fence_fd = -1;
> }
>
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel