From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_kms: Clear pipe color management properties on reset.
Date: Fri, 29 Mar 2019 12:40:10 +0200 [thread overview]
Message-ID: <20190329104010.GT3888@intel.com> (raw)
In-Reply-To: <20190329103526.12364-1-maarten.lankhorst@linux.intel.com>
On Fri, Mar 29, 2019 at 11:35:25AM +0100, Maarten Lankhorst wrote:
> Just like we try to sanitize all properties in igt_plane_reset, we
> should do the same for pipe properties. Loading a wrong lut could
> affect passing and failing tests, so we need to be careful and set
> sane defaults for everything.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> lib/igt_kms.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 43f45997073c..05cb9bd22090 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1804,6 +1804,15 @@ static void igt_pipe_reset(igt_pipe_t *pipe)
> igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_ACTIVE, 0);
> igt_pipe_obj_clear_prop_changed(pipe, IGT_CRTC_OUT_FENCE_PTR);
>
> + if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM))
> + igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_CTM, 0);
> +
> + if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_GAMMA_LUT))
> + igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_GAMMA_LUT, 0);
> +
> + if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_DEGAMMA_LUT))
> + igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_DEGAMMA_LUT, 0);
> +
> pipe->out_fence_fd = -1;
> }
>
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-29 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 10:35 [igt-dev] [PATCH i-g-t 1/2] lib/igt_kms: Clear pipe color management properties on reset Maarten Lankhorst
2019-03-29 10:35 ` [igt-dev] [PATCH i-g-t 2/2] otests/kms_yuv: Add yuv specific tests, v5 Maarten Lankhorst
2019-03-29 10:40 ` Ville Syrjälä [this message]
2019-03-29 11:21 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] lib/igt_kms: Clear pipe color management properties on reset Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-04-03 10:30 [igt-dev] [PATCH i-g-t 1/2] " Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329104010.GT3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox