From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5A106E8E0 for ; Fri, 29 Mar 2019 12:43:37 +0000 (UTC) Date: Fri, 29 Mar 2019 14:43:34 +0200 From: Andi Shyti Message-ID: <20190329124334.GD1167@intel.intel> References: <20190328192206.1591-1-andi.shyti@intel.com> <20190328192206.1591-7-andi.shyti@intel.com> <5962ecab-4406-96a1-c279-0efba329356e@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5962ecab-4406-96a1-c279-0efba329356e@linux.intel.com> Subject: Re: [igt-dev] [PATCH v16 6/8] lib: igt_gt: make gem_engine_can_store_dword() check engine class List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin Cc: IGT dev , Andi Shyti List-ID: PiA+ICtib29sIGdlbV9jYW5fc3RvcmVfZHdvcmQoaW50IGZkLCB1aW50NjRfdCBlbmdpbmUpCj4g Cj4gWWVhaCBlYi0+ZmxhZ3MgaXMgdTY0LCBhbHRob3VnaCB3ZSBkb24ndCBuZWVkIGl0IGFsbCBo ZXJlLiBPa2F5LCBJIGRvbid0IG1pbmQuCgpoZXJlIGZsYWdzICh1NjQpLCBjbGFzcyAodTE2KSBh bmQgZW5naW5lICh1OCBpcyBlbm91Z2gpIGFyZQpzb21laG93IGNvbmZ1c2luZ2x5IG1peGVkLi4u IG5lZWQgdG8gY2hlY2sgYmV0dGVyIHRoZSB0eXBlIHJhbmdlCkkgbmVlZC4KCj4gPiArYm9vbCBn ZW1fZW5naW5lX2Nhbl9zdG9yZV9kd29yZChpbnQgZmQsIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVj dXRpb25fZW5naW5lMiAqZSkKPiA+ICt7Cj4gPiArCWlmICghZ2VtX2hhc19lbmdpbmVfdG9wb2xv Z3koZmQpKQo+ID4gKwkJcmV0dXJuIGdlbV9jYW5fc3RvcmVfZHdvcmQoZmQsIGUtPmZsYWdzKTsK PiA+ICsKPiA+ICsJcmV0dXJuIGdlbV9jbGFzc19jYW5fc3RvcmVfZHdvcmQoZmQsIGUtPmNsYXNz KTsKPiA+ICt9Cj4gCj4gQ291bGRuJ3QgeW91IGFsd2F5cyB1c2UgY2xhc3M/CgpIb3cgZG8geW91 IGRpc3Rpbmd1aXNoIGJldHdlZW4gZWIgZmxhZ3MgYXMgZW5naW5lIGFuZCBjb250ZXh0Cm1hcHBp bmcsIHRoZW4/CgpJbiB0aGVvcnkgdGhpcyBmdW5jdGlvbiBzaG91bGQgbm90IHdvcmsgaW4gYWxs IHRoZSBjYXNlcywgYmVjYXVzZQppdCBhc3N1bWVzIHRoYXQgZS0+ZmxhZ3MgaGFzIGFsd2F5cyBh IG1lbmluZ2Z1bCB2YWx1ZS4KCldoaWxlIGlmIHRoaXMgaXMgY2FsbGVkIGR1cmluZyBhIF9fZm9y X2VhY2hfc3RhdGljX2VuZ2luZSAod2hpY2gKc2hvdWxkIG5ldmVyIGJlIHVzZWQgaW4gbXkgZHJl YW0gd29ybGQpLCBmbGFncyBpcyBhbHdheXMgJzAnLiBJbgp0aGUgbmV4dCBwYXRjaGVzIEkgdHJp ZWQgdG8gYmUgY2FyZWZ1bCB0byB0aGlzIGNhc2UgKF90cmllZF8sIGVoPyAgOikgKQoKKEJUVywg dGhpcyBpcyBhIHByb3Bvc2FsLCBiZWNhdXNlIHRoZSBsZWdhY3kgdXNhZ2Ugb2YKaW50ZWxfZXhl Y3V0aW9uX2VuZ2luZXMyIGxpc3QgaXMgdXNlZCBhIGxvdCkKCj4gYm9vbCBnZW1fY2FuX3N0b3Jl X2R3b3JkKGludCBmZCwgdWludDY0X3QgZW5naW5lKQo+IHsKPiAJdTE2IGNsYXNzID0gZWJfZW5n aW5lX3RvX2NsYXNzKGVuZ2luZSk7CgpZZXMsIEkgbmVlZCB0aGlzIGV4dHJhIHN0ZXAsIGFzc3Vt aW5nIHRoYXQgZW5naW5lIGlzIGFsd2F5cyBhbgplYl9mbGFnLgoKSW4gdGhlIGxhc3QgcGF0Y2hz ZXQgeW91IHJlY29tbWVuZGVkIHRoZSBmb2xsb3dpbmc6CgogIC8vIGlvY3RsIGFuZCBzdHVmZi4u IGJ1bW1lci4uLiA6KAogIHJldCA9IGdlbV9jb250ZXh0X2dldF9lbmdpbmVfbWFwX2NsYXNzX2lu c3RhbmNlKGZkLCBvcHRzLT5jdHgsIG9wdHMtPmVuZ2luZSwKICAmY2xhc3MsICZpbnN0YW5jZSk7 ICAgICAKICBpZiAocmV0KSAvLyBlcnJvciA9IG5vIG1hcCA9IG1lYW5zIG9wdHMtPmVuZ2luZSBp cyBlYiBmbGFncwogICAgICAgICAgY2hlY2sgbGVnYWN5IGdlbV9jYW5fc3RvcmVfZHdvcmQKICBl bHNlCiAgICAgICAgICBjaGVjayB1c2luZyBuZXcgZ2VtX2VuZ2luZV9jYW5fc3RvcmVfZHdvcmQo Y2xhc3MsIGluc3RhbmNlKQoKd2hpY2ggSSBkaWQgaGVyZSAoc3RpbGwgaXQgd29ya3Mgb25seSBv dXQgZnJvbQpfX2Zvcl9lYWNoX3N0YXRpY19lbmdpbmUpLgoKQW5kaQpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3Qt ZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lndC1kZXY=