Re: [igt-dev] [PATCH v16 5/8] tests: gem_exec_basic: add engine discovery test

Tvrtko Ursulin
2019-03-29T11:39:55Z

On 28/03/2019 19:22, Andi Shyti wrote:
> The "exec-engines-ctx" and "exec-physical-engines-ctx" are two
> demo subtest inserted in the gem_exec_basic
> test. The main goal is to reach the engines by using
> the new uapi interfacing with 'gem_topology_has_engine()'.
>
> The two cases get the list of both virtual and physical and only
> physical engines and makes sure they actually exist.
>
> Signed-off-by: Andi Shyti <andi.shyti@intel.com>
> ---
> tests/i915/gem_exec_basic.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index dcb83864b1c1..ed3388952146 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -135,6 +135,32 @@ igt_main
> gtt(fd, e->exec_id | e->flags);
> }
>
> + igt_subtest("exec-engines-ctx") {
> + uint64_t ctx_id;
> + struct intel_execution_engine2 *e2;
> +
> + ctx_id = gem_context_create(fd);
> +
> + for_each_context_engine(fd, ctx_id, e2)
> + igt_assert(gem_context_has_engine(fd, ctx_id,
> + e2->flags));
> +
> + gem_context_destroy(fd, ctx_id);
> + }
> +
> + igt_subtest("exec-physical-engines-ctx") {
> + uint64_t ctx_id;
> + struct intel_execution_engine2 *e2;
> +
> + ctx_id = gem_context_create(fd);

In this one you don't want a context. It creates a mismatch between
execbuf sent by gem_context_has_engine and a context which hasn't been
configured to use engine index addressing.

Regards,

Tvrtko

> +
> + __for_each_physical_engine(fd, e2)
> + igt_assert(gem_context_has_engine(fd, ctx_id,
> + e2->flags));
> +
> + gem_context_destroy(fd, ctx_id);
> + }
> +
> igt_fixture {
> igt_stop_hang_detector();
> close(fd);