Re: [igt-dev] [PATCH v16 2/8] lib: ioctl_wrappers: reach engines by index as well

Andi Shyti
2019-03-29T11:59:39Z

Hi Tvrtko,

> > + /*
> > + * 'engine' value can either store an execbuf engine selector
> > + * or a context map index; for the latter case we do not expect
> > + * to have any value at bit 13 and 14 (BSD1/2 selector),
> > + * therefore, we assume that the following check is safe it wouldn't
> > + * produce any result and we don't exepct anyway to have more than
> > + * one engine mapped in 'unit64_t engine'.
>
> typo in expect and uint.

thanks :)

> I think here you meant that we don't expect more than (1 << 13 - 1) engines?

Yes, indeed :)

> With the comment tidied:
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Thanks a lot!

Andi