From: Daniel Vetter <daniel@ffwll.ch>
To: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: ville.syrjala@intel.com, martin.peres@intel.com,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v1 3/3] igt/tests: Tolerate if kernel can't have all planes
Date: Mon, 1 Apr 2019 09:30:39 +0200 [thread overview]
Message-ID: <20190401073039.GV2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190401072847.GU2665@phenom.ffwll.local>
On Mon, Apr 01, 2019 at 09:28:47AM +0200, Daniel Vetter wrote:
> On Fri, Mar 29, 2019 at 01:29:01PM +0200, Stanislav Lisovskiy wrote:
> > With some upcoming changes i915 might not allow
> > all sprite planes enabled, depending on available
> > bandwidth limitation. Thus the test need to decrement
> > amount of planes and try again, instead of panicking.
> >
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>
> I'm looking at a similar problem in kms_concurrent, and I think we now
> also need to randomize the planes we pick. With bw limits (and other stuff
> really, this is just the one we're hitting now) we'd otherwise have a good
> chance of not testing the last few planes. By randomizing which planes
> we're picking we should be able to make things a lot more interesting for
> the kernel.
igt_permute_array (for an array of plane indices probably) should help
with that.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-01 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 11:28 [igt-dev] [PATCH i-g-t v1 0/3] kms_atomic_transition improvements Stanislav Lisovskiy
2019-03-29 11:28 ` [igt-dev] [PATCH i-g-t v1 1/3] igt/tests/kms_atomic_transition: Skip transition, if no changes done Stanislav Lisovskiy
2019-03-29 11:29 ` [igt-dev] [PATCH i-g-t v1 2/3] igt/tests: Remove redundant code in kms_atomic_transition Stanislav Lisovskiy
2019-03-29 11:29 ` [igt-dev] [PATCH i-g-t v1 3/3] igt/tests: Tolerate if kernel can't have all planes Stanislav Lisovskiy
2019-04-01 7:28 ` Daniel Vetter
2019-04-01 7:30 ` Daniel Vetter [this message]
2019-04-01 7:40 ` Daniel Vetter
2019-03-29 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_atomic_transition improvements Patchwork
2019-03-29 14:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401073039.GV2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
--cc=stanislav.lisovskiy@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox